[PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub releases

[PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub releases

[Vincent Fu]

Jens, here is a patch that should allow AppVeyor to upload Windows
installers as GitHub releases. This will require you to change the
authentication key in the patch to get it working.

Here are the steps:

- Go to https://github.com/settings/tokens and generate a GitHub token
  with public_repo scope.
- Go to https://ci.appveyor.com/tools/encrypt (and login) and encrypt
  the GitHub token from the previous step.
- Replace the token in the patch (under auth_token: secure:) with the
  one from the previous step.

To test this, push a tag for a commit on the master branch to GitHub and
we should end up with a Windows installer at
https://github.com/axboe/fio/releases

Vincent Fu (1):
  ci: upload tagged AppVeyor installers as GitHub releases

 .appveyor.yml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

-- 
2.25.1

[PATCH 1/1] ci: upload tagged AppVeyor installers as GitHub releases

[Vincent Fu]

Deploy Windows installers built by AppVeyor as releases on GitHub. This
process is triggered only when tags are uploaded to the repository.

Patch was created using this guide:
https://www.appveyor.com/docs/deployment/github/

- Generate a GitHub authentication token with public_repo scope:
  https://github.com/settings/tokens
- Login to AppVeyor and encrypt GitHub token: Account -> Encrypt YAML
  https://ci.appveyor.com/tools/encrypt
- Insert encrypted token in appveyor.yml on the secure: line under
  auth_token:

With APPVEYOR_REPO_TAG set to true only tags pushed to GitHub will have
Cygwin MSI installers uploaded as releases to GitHub.

Signed-off-by: Vincent Fu <vincent.fu@samsung.com>
---
 .appveyor.yml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/.appveyor.yml b/.appveyor.yml
index b94eefe3..26dac850 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -50,5 +50,18 @@ after_build:
 test_script:
   - python.exe t/run-fio-tests.py --artifact-root test-artifacts --debug
 
+deploy:
+  - provider: GitHub
+    description: fio Windows installer
+    auth_token:                      # encrypted token from GitHub
+      secure: d3L1R3DFM3HKJkD3CgL4IGQj/YlnYTGkJd1XH2cglXBv90P9rrioPJZ/nTwmh+zg
+    artifact: fio.msi                # upload installer to release assets
+    draft: false
+    prerelease: false
+    on:
+      branch: master                 # release from this branch only
+      APPVEYOR_REPO_TAG: true        # deploy on tag push only
+      DISTRO: cygwin
+
 on_finish:
   - 'bash.exe -lc "cd \"${APPVEYOR_BUILD_FOLDER}\" && [ -d test-artifacts ] && 7z a -t7z test-artifacts.7z test-artifacts -xr!foo.0.0 -xr!latency.?.0 -xr!fio_jsonplus_clat2csv.test && appveyor PushArtifact test-artifacts.7z'
-- 
2.25.1

Re: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub releases

[Jens Axboe]

On 8/8/22 11:51 AM, Vincent Fu wrote:
> Jens, here is a patch that should allow AppVeyor to upload Windows
> installers as GitHub releases. This will require you to change the
> authentication key in the patch to get it working.
> 
> Here are the steps:
> 
> - Go to https://github.com/settings/tokens and generate a GitHub token
>   with public_repo scope.
> - Go to https://ci.appveyor.com/tools/encrypt (and login) and encrypt
>   the GitHub token from the previous step.
> - Replace the token in the patch (under auth_token: secure:) with the
>   one from the previous step.
> 
> To test this, push a tag for a commit on the master branch to GitHub and
> we should end up with a Windows installer at
> https://github.com/axboe/fio/releases

I applied the patch and updated the key, and pushed a test tag. Let's
see if this works!

-- 
Jens Axboe

RE: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub releases

[Vincent Fu]

> -----Original Message-----
> From: Jens Axboe [mailto:axboe@kernel.dk]
> Sent: Tuesday, August 9, 2022 9:10 AM
> To: Vincent Fu <vincent.fu@samsung.com>; fio@vger.kernel.org
> Subject: Re: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub
> releases
> 
> On 8/8/22 11:51 AM, Vincent Fu wrote:
> > Jens, here is a patch that should allow AppVeyor to upload Windows
> > installers as GitHub releases. This will require you to change the
> > authentication key in the patch to get it working.
> >
> > Here are the steps:
> >
> > - Go to
> https://urldefense.com/v3/__https://protect2.fireeye.com/v1/url?k=c8
> 0f25f5-a98430c5-c80eaeba-000babffaa23-
> 3f07539697a6da96&q=1&e=45f36b0d-35d2-4c2a-aef9-
> 90e3373c4279&u=https*3A*2F*2Fgithub.com*2Fsettings*2Ftokens__;JS
> UlJSU!!EwVzqGoTKBqv-0DWAJBm!SJyx37c-
> uGuy9NpnV5_ZzaNEOaD1EfQNjLo4jOdIQy0f7WVg4DpC6sONHJAQ8Zr8lj
> eY8cdCF7DRyQ4DJPjr$   and generate a GitHub token
> >   with public_repo scope.
> > - Go to
> https://urldefense.com/v3/__https://protect2.fireeye.com/v1/url?k=2d
> 5a7dad-4cd1689d-2d5bf6e2-000babffaa23-
> 3a43175ee01cf1ff&q=1&e=45f36b0d-35d2-4c2a-aef9-
> 90e3373c4279&u=https*3A*2F*2Fci.appveyor.com*2Ftools*2Fencrypt_
> _;JSUlJSU!!EwVzqGoTKBqv-0DWAJBm!SJyx37c-
> uGuy9NpnV5_ZzaNEOaD1EfQNjLo4jOdIQy0f7WVg4DpC6sONHJAQ8Zr8lj
> eY8cdCF7DRyYwsre62$   (and login) and encrypt
> >   the GitHub token from the previous step.
> > - Replace the token in the patch (under auth_token: secure:) with the
> >   one from the previous step.
> >
> > To test this, push a tag for a commit on the master branch to GitHub
> and
> > we should end up with a Windows installer at
> >
> https://urldefense.com/v3/__https://protect2.fireeye.com/v1/url?k=b0
> b86c03-d1337933-b0b9e74c-000babffaa23-
> f158594c84169011&q=1&e=45f36b0d-35d2-4c2a-aef9-
> 90e3373c4279&u=https*3A*2F*2Fgithub.com*2Faxboe*2Ffio*2Frelease
> s__;JSUlJSUl!!EwVzqGoTKBqv-0DWAJBm!SJyx37c-
> uGuy9NpnV5_ZzaNEOaD1EfQNjLo4jOdIQy0f7WVg4DpC6sONHJAQ8Zr8lj
> eY8cdCF7DRyYd9Cf7z$
> 
> I applied the patch and updated the key, and pushed a test tag. Let's
> see if this works!
> 
> --
> Jens Axboe

Jens, if you don't want to wait you can kill this build:

https://ci.appveyor.com/project/axboe/fio/builds/44416419

And then this one should (fingers crossed) push installers to GitHub:

https://ci.appveyor.com/project/axboe/fio/builds/44416420

RE: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub releases

[Vincent Fu]

> -----Original Message-----
> From: Vincent Fu [mailto:vincent.fu@samsung.com]
> Sent: Tuesday, August 9, 2022 9:31 AM
> To: Jens Axboe <axboe@kernel.dk>; fio@vger.kernel.org
> Subject: RE: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub
> releases
> 
> > -----Original Message-----
> > From: Jens Axboe [mailto:axboe@kernel.dk]
> > Sent: Tuesday, August 9, 2022 9:10 AM
> > To: Vincent Fu <vincent.fu@samsung.com>; fio@vger.kernel.org
> > Subject: Re: [PATCH 0/1] ci: upload tagged AppVeyor installers as
> GitHub
> > releases
> >

<snip>

> >
> > I applied the patch and updated the key, and pushed a test tag. Let's
> > see if this works!
> >
> > --
> > Jens Axboe
> 
> Jens, if you don't want to wait you can kill this build:
> 
<snip>
> 
> And then this one should (fingers crossed) push installers to GitHub:
> 
<snip>

Ok I had to make a small tweak but I think it is all working now:

https://github.com/axboe/fio/releases

I pushed a tag to git.kernel.dk which got automatically pushed to GitHub
which then triggered the AppVeyor build and eventually we ended up with
the release artifacts on GitHub.

Re: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub releases

[Jens Axboe]

On 8/9/22 10:19 AM, Vincent Fu wrote:
>> -----Original Message-----
>> From: Vincent Fu [mailto:vincent.fu@samsung.com]
>> Sent: Tuesday, August 9, 2022 9:31 AM
>> To: Jens Axboe <axboe@kernel.dk>; fio@vger.kernel.org
>> Subject: RE: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub
>> releases
>>
>>> -----Original Message-----
>>> From: Jens Axboe [mailto:axboe@kernel.dk]
>>> Sent: Tuesday, August 9, 2022 9:10 AM
>>> To: Vincent Fu <vincent.fu@samsung.com>; fio@vger.kernel.org
>>> Subject: Re: [PATCH 0/1] ci: upload tagged AppVeyor installers as
>> GitHub
>>> releases
>>>
> 
> <snip>
> 
>>>
>>> I applied the patch and updated the key, and pushed a test tag. Let's
>>> see if this works!
>>>
>>> --
>>> Jens Axboe
>>
>> Jens, if you don't want to wait you can kill this build:
>>
> <snip>
>>
>> And then this one should (fingers crossed) push installers to GitHub:
>>
> <snip>
> 
> Ok I had to make a small tweak but I think it is all working now:
> 
> https://github.com/axboe/fio/releases
> 
> I pushed a tag to git.kernel.dk which got automatically pushed to GitHub
> which then triggered the AppVeyor build and eventually we ended up with
> the release artifacts on GitHub.

Excellent! Let's get a release tagged then...

-- 
Jens Axboe

Re: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub releases

[Vincent Fu]

On 8/9/22 16:40, Jens Axboe wrote:
> On 8/9/22 10:19 AM, Vincent Fu wrote:
>>> -----Original Message-----
>>> From: Vincent Fu [mailto:vincent.fu@samsung.com]
>>> Sent: Tuesday, August 9, 2022 9:31 AM
>>> To: Jens Axboe <axboe@kernel.dk>; fio@vger.kernel.org
>>> Subject: RE: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub
>>> releases
>>>
>>>> -----Original Message-----
>>>> From: Jens Axboe [mailto:axboe@kernel.dk]
>>>> Sent: Tuesday, August 9, 2022 9:10 AM
>>>> To: Vincent Fu <vincent.fu@samsung.com>; fio@vger.kernel.org
>>>> Subject: Re: [PATCH 0/1] ci: upload tagged AppVeyor installers as
>>> GitHub
>>>> releases
>>>>
>>
>> <snip>
>>
>>>>
>>>> I applied the patch and updated the key, and pushed a test tag. Let's
>>>> see if this works!
>>>>
>>>> --
>>>> Jens Axboe
>>>
>>> Jens, if you don't want to wait you can kill this build:
>>>
>> <snip>
>>>
>>> And then this one should (fingers crossed) push installers to GitHub:
>>>
>> <snip>
>>
>> Ok I had to make a small tweak but I think it is all working now:
>>
>> https://github.com/axboe/fio/releases
>>
>> I pushed a tag to git.kernel.dk which got automatically pushed to GitHub
>> which then triggered the AppVeyor build and eventually we ended up with
>> the release artifacts on GitHub.
> 
> Excellent! Let's get a release tagged then...
> 

Ok I think it all worked.

For each release AppVeyor will do two builds, one for the commit and one 
for the tag.

I only saw the first build, forgot about the second, and thought that 
the integration failed. So I deleted the tag on GitHub and then 
re-tagged it to manually trigger the release process. So AppVeyor did 
two builds for the tag which did no harm except waste their resources.

I also deleted the test release artifacts on GitHub from earlier today 
to clean things up.

Vincent

Re: [PATCH 0/1] ci: upload tagged AppVeyor installers as GitHub releases

[Jens Axboe]

On Mon, 8 Aug 2022 17:51:49 +0000, Vincent Fu wrote:
> Jens, here is a patch that should allow AppVeyor to upload Windows
> installers as GitHub releases. This will require you to change the
> authentication key in the patch to get it working.
> 
> Here are the steps:
> 
> - Go to https://github.com/settings/tokens and generate a GitHub token
>   with public_repo scope.
> - Go to https://ci.appveyor.com/tools/encrypt (and login) and encrypt
>   the GitHub token from the previous step.
> - Replace the token in the patch (under auth_token: secure:) with the
>   one from the previous step.
> 
> [...]

Applied, thanks!

[1/1] ci: upload tagged AppVeyor installers as GitHub releases
      (no commit info)

Best regards,
-- 
Jens Axboe