fio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* configure on FreeBSD reports "grep: The -P option is not supported"
@ 2022-09-19  3:33 Rebecca Cran
  2022-09-19 13:12 ` Vincent Fu
  0 siblings, 1 reply; 4+ messages in thread
From: Rebecca Cran @ 2022-09-19  3:33 UTC (permalink / raw)
  To: fio, Jens Axboe

It looks like commit 7ff204c83595cd7d6b7b6a813d9fda97afd25198 introduced an error on some systems such as FreeBSD, whose grep doesn't support -P.

num() {
   echo "$1" | grep -P -q "^[0-9]+$"
}

./configure now reports:

grep: The -P option is not supported
seed_buckets                  4

Is -P required?

-- 
Rebecca Cran


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: configure on FreeBSD reports "grep: The -P option is not supported"
  2022-09-19  3:33 configure on FreeBSD reports "grep: The -P option is not supported" Rebecca Cran
@ 2022-09-19 13:12 ` Vincent Fu
  2022-09-19 13:15   ` Rebecca Cran
  0 siblings, 1 reply; 4+ messages in thread
From: Vincent Fu @ 2022-09-19 13:12 UTC (permalink / raw)
  To: Rebecca Cran, fio, Jens Axboe

On 9/18/22 23:33, Rebecca Cran wrote:
> It looks like commit 7ff204c83595cd7d6b7b6a813d9fda97afd25198 introduced 
> an error on some systems such as FreeBSD, whose grep doesn't support -P.
> 
> num() {
>    echo "$1" | grep -P -q "^[0-9]+$"
> }
> 
> ./configure now reports:
> 
> grep: The -P option is not supported
> seed_buckets                  4
> 
> Is -P required?
> 

Hello Bex,

Does it work for you to replace -P with -E?

Alternatively, what if we replaced grep with

test "$1" -eq "$1" 2>/dev/null

Vincent

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: configure on FreeBSD reports "grep: The -P option is not supported"
  2022-09-19 13:12 ` Vincent Fu
@ 2022-09-19 13:15   ` Rebecca Cran
  2022-09-19 14:24     ` Vincent Fu
  0 siblings, 1 reply; 4+ messages in thread
From: Rebecca Cran @ 2022-09-19 13:15 UTC (permalink / raw)
  To: Vincent Fu, fio, Jens Axboe

On 9/19/22 07:12, Vincent Fu wrote:
> On 9/18/22 23:33, Rebecca Cran wrote:
>> It looks like commit 7ff204c83595cd7d6b7b6a813d9fda97afd25198 
>> introduced an error on some systems such as FreeBSD, whose grep 
>> doesn't support -P.
>>
>> num() {
>>    echo "$1" | grep -P -q "^[0-9]+$"
>> }
>>
>> ./configure now reports:
>>
>> grep: The -P option is not supported
>> seed_buckets                  4
>>
>> Is -P required?
>>
>
> Hello Bex,
>
> Does it work for you to replace -P with -E?
>
> Alternatively, what if we replaced grep with
>
> test "$1" -eq "$1" 2>/dev/null


Replacing it with -E works.


-- 

Rebecca Cran


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: configure on FreeBSD reports "grep: The -P option is not supported"
  2022-09-19 13:15   ` Rebecca Cran
@ 2022-09-19 14:24     ` Vincent Fu
  0 siblings, 0 replies; 4+ messages in thread
From: Vincent Fu @ 2022-09-19 14:24 UTC (permalink / raw)
  To: Rebecca Cran, fio, Jens Axboe

On 9/19/22 09:15, Rebecca Cran wrote:
> On 9/19/22 07:12, Vincent Fu wrote:
>> On 9/18/22 23:33, Rebecca Cran wrote:
>>> It looks like commit 7ff204c83595cd7d6b7b6a813d9fda97afd25198 
>>> introduced an error on some systems such as FreeBSD, whose grep 
>>> doesn't support -P.
>>>
>>> num() {
>>>    echo "$1" | grep -P -q "^[0-9]+$"
>>> }
>>>
>>> ./configure now reports:
>>>
>>> grep: The -P option is not supported
>>> seed_buckets                  4
>>>
>>> Is -P required?
>>>
>>
>> Hello Bex,
>>
>> Does it work for you to replace -P with -E?
>>
>> Alternatively, what if we replaced grep with
>>
>> test "$1" -eq "$1" 2>/dev/null
> 
> 
> Replacing it with -E works.
> 
> 
Bex, change committed here:

https://github.com/axboe/fio/commit/d14687025c0c61d047e4252036d1b024d62cb0a6

Thanks.

Vincent

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-19 14:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19  3:33 configure on FreeBSD reports "grep: The -P option is not supported" Rebecca Cran
2022-09-19 13:12 ` Vincent Fu
2022-09-19 13:15   ` Rebecca Cran
2022-09-19 14:24     ` Vincent Fu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).