fio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Global filename/job filename interaction
@ 2022-05-26 20:49 ` Phillip Chen
  2022-05-27 18:00   ` Vincent Fu
  0 siblings, 1 reply; 2+ messages in thread
From: Phillip Chen @ 2022-05-26 20:49 UTC (permalink / raw)
  To: fio

Hello,
I was surprised to find that global filenames are added to job filenames rather than being replaced by job filenames. For instance, running
fio --ioengine=libaio --io_size=40k --readwrite=randread --filename=/dev/sdd --direct=1 --exitall --debug=io --name=sdb_randread_1_4k --filename=/dev/sdb
with fio-3.30 will show reads to both /dev/sdb and /dev/sdd. Is this expected behaviour? And are there other parameters that work in this way? I couldn't find anything in the job file parameters documentation mentioning this behaviour, but perhaps I was looking in the wrong place or missed it.
Thank you for your attention,
Phillip Chen

Seagate Internal

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: Global filename/job filename interaction
  2022-05-26 20:49 ` Global filename/job filename interaction Phillip Chen
@ 2022-05-27 18:00   ` Vincent Fu
  0 siblings, 0 replies; 2+ messages in thread
From: Vincent Fu @ 2022-05-27 18:00 UTC (permalink / raw)
  To: Phillip Chen, fio

> -----Original Message-----
> From: Phillip Chen [mailto:phillip.a.chen@seagate.com]
> Sent: Thursday, May 26, 2022 4:50 PM
> To: fio@vger.kernel.org
> Subject: Global filename/job filename interaction
> 
> Hello,
> I was surprised to find that global filenames are added to job filenames
> rather than being replaced by job filenames. For instance, running
> fio --ioengine=libaio --io_size=40k --readwrite=randread --
> filename=/dev/sdd --direct=1 --exitall --debug=io --
> name=sdb_randread_1_4k --filename=/dev/sdb
> with fio-3.30 will show reads to both /dev/sdb and /dev/sdd. Is this
> expected behaviour? And are there other parameters that work in this
> way? I couldn't find anything in the job file parameters documentation
> mentioning this behaviour, but perhaps I was looking in the wrong place
> or missed it.
> Thank you for your attention,
> Phillip Chen
> 
> Seagate Internal

options.c:str_filename_cb parses the filename option. Since fio allows
users to specify multiple files by separating names with a colon, for
each filename specified the function calls add_file() to add the new
file to the job's file array.

I believe what is happening is that sdd was added to the job's file
array when the [global] section was parsed and then sdb was added to the
file array when the [sdb_randread_1_4k] section was parsed. So the job
ran as if you had specified filename=/dev/sdd:/dev/sdb.

Unless someone wants to change this behavior perhaps the thing to do is
to document it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-27 18:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20220526205022uscas1p2e26aefb34e7daa30817eeb6d85a6c8cd@uscas1p2.samsung.com>
2022-05-26 20:49 ` Global filename/job filename interaction Phillip Chen
2022-05-27 18:00   ` Vincent Fu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).