From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH 1/4] generic/459: ensure that the lvm devices have been created
Date: Tue, 15 Mar 2022 20:30:09 -0700 [thread overview]
Message-ID: <164740140920.3371628.4554997239924071993.stgit@magnolia> (raw)
In-Reply-To: <164740140348.3371628.12967562090320741592.stgit@magnolia>
From: Darrick J. Wong <djwong@kernel.org>
Once in a /very/ long while this test fails because _mkfs_dev can't find
the LVM thinp volume after it's been created. Since the "solution" du
jour seems to be to sprinkle udevadm settle calls everywhere, do that
here in the hopes that will fix it.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
tests/generic/459 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/generic/459 b/tests/generic/459
index cda19e6e..57d58e55 100755
--- a/tests/generic/459
+++ b/tests/generic/459
@@ -70,6 +70,7 @@ $LVM_PROG lvcreate --virtualsize $virtsize \
-T $vgname/$poolname \
-n $lvname >>$seqres.full 2>&1
+$UDEV_SETTLE_PROG &>/dev/null
_mkfs_dev /dev/mapper/$vgname-$lvname >>$seqres.full 2>&1
# Running the test over the original volume doesn't reproduce the problem
next prev parent reply other threads:[~2022-03-16 3:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 3:30 [PATCHSET 0/4] fstests: random fixes Darrick J. Wong
2022-03-16 3:30 ` Darrick J. Wong [this message]
2022-03-22 4:50 ` [PATCH 1/4] generic/459: ensure that the lvm devices have been created Zorro Lang
2022-03-16 3:30 ` [PATCH 2/4] common/xfs: fix broken code in _check_xfs_filesystem Darrick J. Wong
2022-03-22 4:57 ` Zorro Lang
2022-03-16 3:30 ` [PATCH 3/4] xfs/420: fix occasional test failures due to pagecache readahead Darrick J. Wong
2022-03-22 5:13 ` Zorro Lang
2022-03-22 16:10 ` Darrick J. Wong
2022-03-16 3:30 ` [PATCH 4/4] generic/673: fix golden output to reflect vfs setgid behavior Darrick J. Wong
2022-03-22 5:24 ` Zorro Lang
2022-03-16 22:12 ` [PATCH 5/4] xfs/076: only create files on the data device Darrick J. Wong
2022-03-22 8:31 ` Zorro Lang
2022-03-16 22:13 ` [PATCH 6/4] xfs/17[035]: fix intermittent failures when filesystem metadata gets large Darrick J. Wong
2022-03-22 7:15 ` Zorro Lang
2022-03-22 16:11 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164740140920.3371628.4554997239924071993.stgit@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).