From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/097: Remove wrong broken assignment operation
Date: Mon, 7 Oct 2019 08:12:44 -0700 [thread overview]
Message-ID: <20191007151244.GC13097@magnolia> (raw)
In-Reply-To: <1570432515-13184-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
On Mon, Oct 07, 2019 at 03:15:15PM +0800, Yang Xu wrote:
> On old kernel, since commit ded188b8609 ("xfs: Fix the situation that mount
> operation rejects corrupted XFS") running this case got the mismatched output,
> as below:
But why did the output mismatch? Did the fs heal itself? Did
allocating 5 more files somehow avoid touching the finobt? Is the
assignment logic in the loop broken?
--D
> -----------------------------------
> + check fs
> + corrupt image
> + mount image && modify files
> -broken: 1
> +broken: 0
> + repair fs
> + mount image (2)
> ------------------------------------
>
> It fails because the broken is always equal to 0 when _try_scratch_mount
> succeed. So remove this wrong assignment operation.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
> tests/xfs/097 | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/xfs/097 b/tests/xfs/097
> index 1cb7d69c..20791738 100755
> --- a/tests/xfs/097
> +++ b/tests/xfs/097
> @@ -81,8 +81,6 @@ done
> echo "+ mount image && modify files"
> broken=1
> if _try_scratch_mount >> $seqres.full 2>&1; then
> -
> - broken=0
> for x in `seq 65 70`; do
> touch "${TESTFILE}.${x}" 2> /dev/null && broken=0
> done
> --
> 2.18.1
>
>
>
next prev parent reply other threads:[~2019-10-07 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 7:15 [PATCH] xfs/097: Remove wrong broken assignment operation Yang Xu
2019-10-07 15:12 ` Darrick J. Wong [this message]
2019-10-08 2:39 ` Yang Xu
2019-10-14 16:39 ` Darrick J. Wong
2019-10-15 6:27 ` Yang Xu
2019-10-21 12:09 ` Yang Xu
2019-10-21 15:50 ` Darrick J. Wong
2019-10-22 1:49 ` Yang Xu
2019-10-22 1:55 ` Darrick J. Wong
2019-10-22 2:06 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007151244.GC13097@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=xuyang2018.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).