[PATCH] xfs/191-input-validation:Fix issue that the test takes too long

[PATCH] xfs/191-input-validation:Fix issue that the test takes too long

[Baihua Lu]

When test is passed, _check_filesystems will execute. If there is no
mkfs a new XFS filesystem $SCRATCH_DEV in this test, in the check
filesystems stage, xfs_logprint will be failed for having dirty log and
xfs_repaire will take a long time.

Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
 tests/xfs/191-input-validation | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
index b6658015..fd239dbb 100755
--- a/tests/xfs/191-input-validation
+++ b/tests/xfs/191-input-validation
@@ -34,7 +34,7 @@ _supported_os Linux
 _require_scratch
 _require_xfs_mkfs_validation
 
-
+_scratch_mkfs >/dev/null 2>&1
 
 rm -f $seqres.full
 echo silence is golden
-- 
2.17.1

Re: [PATCH] xfs/191-input-validation:Fix issue that the test takes too long

[Darrick J. Wong]

On Wed, Nov 27, 2019 at 02:41:31AM -0800, Baihua Lu wrote:
> After this test is passed, checking filesystems will execute. Then
> xfs_logprint will be failed and xfs_repair will take a long time because
> there is not really creating the file system in this test and wipefs
> executes before this test. So there is no need checking filesystems.
> 
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>

Ok, looks fine.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  tests/xfs/191-input-validation | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
> index b6658015..db427349 100755
> --- a/tests/xfs/191-input-validation
> +++ b/tests/xfs/191-input-validation
> @@ -31,7 +31,7 @@ _cleanup()
>  # Modify as appropriate.
>  _supported_fs xfs
>  _supported_os Linux
> -_require_scratch
> +_require_scratch_nocheck
>  _require_xfs_mkfs_validation
>  
>  
> -- 
> 2.17.1
> 

[PATCH] xfs/191-input-validation:Fix issue that the test takes too long

[Baihua Lu]

After this test is passed, checking filesystems will execute. Then
xfs_logprint will be failed and xfs_repair will take a long time because
there is not really creating the file system in this test and wipefs
executes before this test. So there is no need checking filesystems.

Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
 tests/xfs/191-input-validation | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
index b6658015..db427349 100755
--- a/tests/xfs/191-input-validation
+++ b/tests/xfs/191-input-validation
@@ -31,7 +31,7 @@ _cleanup()
 # Modify as appropriate.
 _supported_fs xfs
 _supported_os Linux
-_require_scratch
+_require_scratch_nocheck
 _require_xfs_mkfs_validation
 
 
-- 
2.17.1

Re: [PATCH] xfs/191-input-validation:Fix issue that the test takes too long

[Darrick J. Wong]

On Tue, Nov 26, 2019 at 05:23:36AM +0000, Baihua Lu wrote:
> In this test, we don't need to check filesystem on the scratch device for there is not
> really creating the file system. If _check_filesystems executes, xfs_logprint will be
> failed for having dirty log and xfs_repaire will take a long time.

Where did the dirty log come from if we didn't actually format anything?
I thought I had taught fstests to wipefs the scratch device between
each test...

(No objections to the diff itself, I'm simply curious about the commit
message.)

--D

> 
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
> ---
>  tests/xfs/191-input-validation | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
> index b6658015..db427349 100755
> --- a/tests/xfs/191-input-validation
> +++ b/tests/xfs/191-input-validation
> @@ -31,7 +31,7 @@ _cleanup()
>  # Modify as appropriate.
>  _supported_fs xfs
>  _supported_os Linux
> -_require_scratch
> +_require_scratch_nocheck
>  _require_xfs_mkfs_validation
>  
>  
> -- 
> 2.17.1
> 

[PATCH] xfs/191-input-validation:Fix issue that the test takes too long

[Baihua Lu]

In this test, we don't need to check filesystem on the scratch device for there is not
really creating the file system. If _check_filesystems executes, xfs_logprint will be
failed for having dirty log and xfs_repaire will take a long time.

Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
 tests/xfs/191-input-validation | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
index b6658015..db427349 100755
--- a/tests/xfs/191-input-validation
+++ b/tests/xfs/191-input-validation
@@ -31,7 +31,7 @@ _cleanup()
 # Modify as appropriate.
 _supported_fs xfs
 _supported_os Linux
-_require_scratch
+_require_scratch_nocheck
 _require_xfs_mkfs_validation
 
 
-- 
2.17.1