FSTests Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] fstests: add perf to the list of test directories
@ 2020-02-18 14:29 Josef Bacik
  2020-02-19 11:52 ` Zorro Lang
  2020-02-23 12:56 ` Eryu Guan
  0 siblings, 2 replies; 3+ messages in thread
From: Josef Bacik @ 2020-02-18 14:29 UTC (permalink / raw)
  To: kernel-team, fstests, linux-btrfs

I noticed that despite having PERF_CONFIGNAME set I wasn't getting the
perf/ tests run when I used -g auto.  This is because it's not included
in the list of directories to look at.  Fix this so that perf tests get
run as well.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/check b/check
index 89f3358a..9e7b6134 100755
--- a/check
+++ b/check
@@ -44,7 +44,7 @@ timestamp=${TIMESTAMP:=false}
 
 rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
 
-SRC_GROUPS="generic shared"
+SRC_GROUPS="generic shared perf"
 export SRC_DIR="tests"
 
 usage()
-- 
2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fstests: add perf to the list of test directories
  2020-02-18 14:29 [PATCH] fstests: add perf to the list of test directories Josef Bacik
@ 2020-02-19 11:52 ` Zorro Lang
  2020-02-23 12:56 ` Eryu Guan
  1 sibling, 0 replies; 3+ messages in thread
From: Zorro Lang @ 2020-02-19 11:52 UTC (permalink / raw)
  To: Josef Bacik; +Cc: fstests

On Tue, Feb 18, 2020 at 09:29:45AM -0500, Josef Bacik wrote:
> I noticed that despite having PERF_CONFIGNAME set I wasn't getting the
> perf/ tests run when I used -g auto.  This is because it's not included
> in the list of directories to look at.  Fix this so that perf tests get
> run as well.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
>  check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/check b/check
> index 89f3358a..9e7b6134 100755
> --- a/check
> +++ b/check
> @@ -44,7 +44,7 @@ timestamp=${TIMESTAMP:=false}
>  
>  rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
>  
> -SRC_GROUPS="generic shared"
> +SRC_GROUPS="generic shared perf"

Looks good to me, if the maintainer won't prefer moving perf/001 to generic/ :)

Thanks,
Zorro

>  export SRC_DIR="tests"
>  
>  usage()
> -- 
> 2.24.1
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fstests: add perf to the list of test directories
  2020-02-18 14:29 [PATCH] fstests: add perf to the list of test directories Josef Bacik
  2020-02-19 11:52 ` Zorro Lang
@ 2020-02-23 12:56 ` Eryu Guan
  1 sibling, 0 replies; 3+ messages in thread
From: Eryu Guan @ 2020-02-23 12:56 UTC (permalink / raw)
  To: Josef Bacik; +Cc: kernel-team, fstests, linux-btrfs

On Tue, Feb 18, 2020 at 09:29:45AM -0500, Josef Bacik wrote:
> I noticed that despite having PERF_CONFIGNAME set I wasn't getting the
> perf/ tests run when I used -g auto.  This is because it's not included
> in the list of directories to look at.  Fix this so that perf tests get
> run as well.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

I don't think the perf test infra is widely used by developers and
testers yet, so adding perf tests to default 'auto' tests would bring
unexpected failures.

So I think it's better to keep it not run by default for now, and if you
want to run perf tests in your test env, you could do it easily by
adding "-g perf/auto" option to "./check", e.g.

	./check -g auto -g perf/auto

And if there're frequent users of the perf infra, please reply this
thread and let us know, it'd be interesting to know how many users are
there.

Thanks,
Eryu

> ---
>  check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/check b/check
> index 89f3358a..9e7b6134 100755
> --- a/check
> +++ b/check
> @@ -44,7 +44,7 @@ timestamp=${TIMESTAMP:=false}
>  
>  rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
>  
> -SRC_GROUPS="generic shared"
> +SRC_GROUPS="generic shared perf"
>  export SRC_DIR="tests"
>  
>  usage()
> -- 
> 2.24.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18 14:29 [PATCH] fstests: add perf to the list of test directories Josef Bacik
2020-02-19 11:52 ` Zorro Lang
2020-02-23 12:56 ` Eryu Guan

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git