From: Christoph Hellwig <hch@lst.de>
To: fstests@vger.kernel.org
Cc: jlayton@kernel.org
Subject: [PATCH] xfstests: remove generic/484
Date: Mon, 24 Feb 2020 14:29:26 -0800 [thread overview]
Message-ID: <20200224222926.694991-1-hch@lst.de> (raw)
Generic/484 tests functionality that isn't really related to file
systems, and has failed every since it was added. Remove it as it
serves no puropse in xfstests.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/generic/484 | 51 -------------------------------------------
tests/generic/484.out | 2 --
tests/generic/group | 1 -
3 files changed, 54 deletions(-)
delete mode 100755 tests/generic/484
delete mode 100644 tests/generic/484.out
diff --git a/tests/generic/484 b/tests/generic/484
deleted file mode 100755
index d83380ac..00000000
--- a/tests/generic/484
+++ /dev/null
@@ -1,51 +0,0 @@
-#! /bin/bash
-# SPDX-License-Identifier: GPL-2.0
-# Copyright (c) 2018 Red Hat Inc. All Rights Reserved.
-#
-# FS QA Test 484
-#
-# POSIX requires that record locks are preserved across an execve(2). But
-# there's bug that record locks are released if process is multithreaded at the
-# time that execve is called.
-#
-# Fixed by patch from Jeff Layton:
-# locks: change POSIX lock ownership on execve when files_struct is displaced
-#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
-
-here=`pwd`
-tmp=/tmp/$$
-status=1 # failure is the default!
-trap "_cleanup; exit \$status" 0 1 2 3 15
-
-_cleanup()
-{
- cd /
- rm -f $tmp.*
-}
-
-# get standard environment, filters and checks
-. ./common/rc
-. ./common/filter
-
-# remove previous $seqres.full before test
-rm -f $seqres.full
-
-# real QA test starts here
-_supported_fs generic
-_supported_os Linux
-_require_test
-_require_test_program "t_locks_execve"
-
-# prepare a 4k testfile in TEST_DIR
-$XFS_IO_PROG -f -c "pwrite -S 0xFF 0 4096" \
- $TEST_DIR/t_lock_execve_file >> $seqres.full 2>&1
-
-$here/src/t_locks_execve $TEST_DIR/t_lock_execve_file
-
-# success, all done
-echo "Silence is golden"
-status=0
-exit
diff --git a/tests/generic/484.out b/tests/generic/484.out
deleted file mode 100644
index 94f2f0bd..00000000
--- a/tests/generic/484.out
+++ /dev/null
@@ -1,2 +0,0 @@
-QA output created by 484
-Silence is golden
diff --git a/tests/generic/group b/tests/generic/group
index ff79a597..dc95b77b 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -486,7 +486,6 @@
481 auto quick log metadata
482 auto metadata replay
483 auto quick log metadata
-484 auto quick
485 auto quick insert
486 auto quick attr
487 auto quick eio
--
2.24.1
next reply other threads:[~2020-02-24 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 22:29 Christoph Hellwig [this message]
2020-02-24 22:37 ` [PATCH] xfstests: remove generic/484 Darrick J. Wong
2020-02-26 7:50 ` Zorro Lang
2020-02-26 15:22 ` Murphy Zhou
2020-03-01 14:32 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224222926.694991-1-hch@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).