Re: [PATCH] xfstests: remove generic/484

[Murphy Zhou <xzhou@redhat.com>]

On Wed, Feb 26, 2020 at 03:50:09PM +0800, Zorro Lang wrote:
> On Mon, Feb 24, 2020 at 02:29:26PM -0800, Christoph Hellwig wrote:
> > Generic/484 tests functionality that isn't really related to file
> > systems, and has failed every since it was added.  Remove it as it
> > serves no puropse in xfstests.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> 
> CC the original author of this case. To make sure if he has more
> opinions about this change, and if he'd like to shift it to LTP
> if xfstests decides to remove this case at last.

Okay for me to remove it. It seems very hard to fix.

I'll try LTP, :)

Thanks.
> 
> >  tests/generic/484     | 51 -------------------------------------------
> >  tests/generic/484.out |  2 --
> >  tests/generic/group   |  1 -
> >  3 files changed, 54 deletions(-)
> >  delete mode 100755 tests/generic/484
> >  delete mode 100644 tests/generic/484.out
> > 
> > diff --git a/tests/generic/484 b/tests/generic/484
> > deleted file mode 100755
> > index d83380ac..00000000
> > --- a/tests/generic/484
> > +++ /dev/null
> > @@ -1,51 +0,0 @@
> > -#! /bin/bash
> > -# SPDX-License-Identifier: GPL-2.0
> > -# Copyright (c) 2018 Red Hat Inc.  All Rights Reserved.
> > -#
> > -# FS QA Test 484
> > -#
> > -# POSIX requires that record locks are preserved across an execve(2). But
> > -# there's bug that record locks are released if process is multithreaded at the
> > -# time that execve is called.
> > -#
> > -# Fixed by patch from Jeff Layton:
> > -# locks: change POSIX lock ownership on execve when files_struct is displaced
> > -#
> > -seq=`basename $0`
> > -seqres=$RESULT_DIR/$seq
> > -echo "QA output created by $seq"
> > -
> > -here=`pwd`
> > -tmp=/tmp/$$
> > -status=1	# failure is the default!
> > -trap "_cleanup; exit \$status" 0 1 2 3 15
> > -
> > -_cleanup()
> > -{
> > -	cd /
> > -	rm -f $tmp.*
> > -}
> > -
> > -# get standard environment, filters and checks
> > -. ./common/rc
> > -. ./common/filter
> > -
> > -# remove previous $seqres.full before test
> > -rm -f $seqres.full
> > -
> > -# real QA test starts here
> > -_supported_fs generic
> > -_supported_os Linux
> > -_require_test
> > -_require_test_program "t_locks_execve"
> > -
> > -# prepare a 4k testfile in TEST_DIR
> > -$XFS_IO_PROG -f -c "pwrite -S 0xFF 0 4096" \
> > -	$TEST_DIR/t_lock_execve_file >> $seqres.full 2>&1
> > -
> > -$here/src/t_locks_execve $TEST_DIR/t_lock_execve_file
> > -
> > -# success, all done
> > -echo "Silence is golden"
> > -status=0
> > -exit
> > diff --git a/tests/generic/484.out b/tests/generic/484.out
> > deleted file mode 100644
> > index 94f2f0bd..00000000
> > --- a/tests/generic/484.out
> > +++ /dev/null
> > @@ -1,2 +0,0 @@
> > -QA output created by 484
> > -Silence is golden
> > diff --git a/tests/generic/group b/tests/generic/group
> > index ff79a597..dc95b77b 100644
> > --- a/tests/generic/group
> > +++ b/tests/generic/group
> > @@ -486,7 +486,6 @@
> >  481 auto quick log metadata
> >  482 auto metadata replay
> >  483 auto quick log metadata
> > -484 auto quick
> >  485 auto quick insert
> >  486 auto quick attr
> >  487 auto quick eio
> > -- 
> > 2.24.1
> > 

-- 
Murphy