From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Vladimir Zapolskiy <vladimir@tuxera.com>
Cc: Eryu Guan <guaneryu@gmail.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] generic/079: remove assignment of the test to acl and attr groups
Date: Mon, 13 Jul 2020 09:46:12 -0700 [thread overview]
Message-ID: <20200713164612.GJ7600@magnolia> (raw)
In-Reply-To: <20200713122648.16837-1-vladimir@tuxera.com>
On Mon, Jul 13, 2020 at 03:26:48PM +0300, Vladimir Zapolskiy wrote:
> The test does not belong to acl group of tests, and expectedly the test
> is supposed to pass on a filesystem which supports file attributes but
> not ACLs.
>
> In addition the test should be removed from attr group of tests, because
> the attr group specifies tests which operate over extended file attributes,
> this test does not fall into this category.
>
> The change is intended to improve the assignment of tests to groups
> to get better testing coverage, if a list of run tests is selected by
> test group attributes.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/generic/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index d9ab9a31f2ed..3d7effe6d72a 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -81,7 +81,7 @@
> 076 metadata rw udf auto quick stress
> 077 acl attr auto enospc
> 078 auto quick metadata
> -079 acl attr ioctl metadata auto quick
> +079 auto quick ioctl metadata
> 080 auto quick
> 081 auto quick
> 082 auto quick quota
> --
> 2.25.1
>
prev parent reply other threads:[~2020-07-13 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 12:26 [PATCH] generic/079: remove assignment of the test to acl and attr groups Vladimir Zapolskiy
2020-07-13 16:46 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713164612.GJ7600@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=vladimir@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).