From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <guaneryu@gmail.com>,
fstests@vger.kernel.org, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs/010,030: filter AG header CRC error warnings
Date: Wed, 15 Jul 2020 09:57:23 -0700 [thread overview]
Message-ID: <20200715165723.GJ7625@magnolia> (raw)
In-Reply-To: <20200714071346.GY1938@dhcp-12-102.nay.redhat.com>
On Tue, Jul 14, 2020 at 03:13:46PM +0800, Zorro Lang wrote:
> On Mon, Jul 13, 2020 at 11:49:30AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Filter out the new AG header CRC verification warnings in xfs_repair
> > since these tests were built before that existed.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > tests/xfs/010 | 6 +++++-
> > tests/xfs/030 | 2 ++
> > 2 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/xfs/010 b/tests/xfs/010
> > index c341795d..ec23507a 100755
> > --- a/tests/xfs/010
> > +++ b/tests/xfs/010
> > @@ -113,7 +113,11 @@ _check_scratch_fs
> > # nuke the finobt root, repair will have to regenerate from the inobt
> > _corrupt_finobt_root $SCRATCH_DEV
> >
> > -_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks
>
> I think this patch is based on another patch which hasn't been merged, right?
> Due to I can't find the *sed -e '/^bad finobt block/d'* on current xfstests-dev
> master branch, which HEAD is:
> aae8fbec generic/270: wait for fsstress processes to be killed
Oops, yeah, I forgot that my development branch has multiple patches to
those tests. Now that xfsprogs for-next has updated I guess I should
clean all those up and send them for real.
--D
> Thanks,
> Zorro
>
> > +filter_finobt_repair() {
> > + sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
> > +}
> > +
> > +_scratch_xfs_repair 2>&1 | filter_finobt_repair
> >
> > status=0
> > exit
> > diff --git a/tests/xfs/030 b/tests/xfs/030
> > index 8f95331a..a270e36c 100755
> > --- a/tests/xfs/030
> > +++ b/tests/xfs/030
> > @@ -43,6 +43,8 @@ _check_ag()
> > -e '/^bad agbno AGBNO for rmapbt/d' \
> > -e '/^bad agbno AGBNO for refcntbt/d' \
> > -e '/^bad inobt block count/d' \
> > + -e '/^agf has bad CRC/d' \
> > + -e '/^agi has bad CRC/d' \
> > -e '/^bad finobt block count/d' \
> > -e '/^Missing reverse-mapping record.*/d' \
> > -e '/^unknown block state, ag AGNO, block.*/d'
> >
>
next prev parent reply other threads:[~2020-07-15 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 18:49 [PATCH] xfs/010,030: filter AG header CRC error warnings Darrick J. Wong
2020-07-14 7:13 ` Zorro Lang
2020-07-15 16:57 ` Darrick J. Wong [this message]
2020-07-29 2:51 Darrick J. Wong
2020-07-29 4:49 ` Zorro Lang
2020-07-29 14:50 ` Darrick J. Wong
2020-08-26 8:23 ` Yang Xu
2020-08-28 1:33 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715165723.GJ7625@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).