From: Nikolay Borisov <nborisov@suse.com>
To: guan@eryu.me
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org,
Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH] btrfs/162: Stop using device mount option
Date: Fri, 24 Jul 2020 16:12:50 +0300 [thread overview]
Message-ID: <20200724131250.3377-1-nborisov@suse.com> (raw)
btrfs is clever enough to figure out which devices constitute the sprout
fs even without specifying them explicitly with -o device. Additionally,
explicitly settings the devices via -o device reduces coverage of the
test since it didn't detect breakage a local change introduced. Without
-o device instead this breakage was detected.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
tests/btrfs/162 | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/btrfs/162 b/tests/btrfs/162
index 7f119be057b7..ff3c50b1be54 100755
--- a/tests/btrfs/162
+++ b/tests/btrfs/162
@@ -69,11 +69,10 @@ create_sprout_seed()
create_next_sprout()
{
- run_check _mount -o device=$dev_seed $dev_sprout_seed $SCRATCH_MNT
+ run_check _mount $dev_sprout_seed $SCRATCH_MNT
_run_btrfs_util_prog device add -f $dev_sprout $SCRATCH_MNT
_scratch_unmount
- run_check _mount -o device=$dev_seed,device=$dev_sprout_seed \
- $dev_sprout $SCRATCH_MNT
+ run_check _mount $dev_sprout $SCRATCH_MNT
echo -- sprout --
od -x $SCRATCH_MNT/foobar
}
--
2.17.1
next reply other threads:[~2020-07-24 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 13:12 Nikolay Borisov [this message]
2020-07-30 2:57 ` [PATCH] btrfs/162: Stop using device mount option Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724131250.3377-1-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).