* [PATCH] common/config: Allow sections names to contain hyphen
@ 2020-06-25 12:37 Nikolay Borisov
2020-08-26 16:04 ` Nikolay Borisov
2020-08-30 16:25 ` Eryu Guan
0 siblings, 2 replies; 3+ messages in thread
From: Nikolay Borisov @ 2020-06-25 12:37 UTC (permalink / raw)
To: guaneryu; +Cc: fstests, Nikolay Borisov
Current regular expression in get_config_sections allows section names
to consist of alphanumeric character and underscore. Extend it to
also allow the hyphen '-' character.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
common/config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/config b/common/config
index 8023273da115..63d486125a76 100644
--- a/common/config
+++ b/common/config
@@ -449,7 +449,7 @@ known_hosts()
# in the section name otherwise the section will not be resognised.
# Section name must be contained between square brackets.
get_config_sections() {
- sed -n -e "s/^\[\([[:alnum:]_]*\)\]/\1/p" < $1
+ sed -n -e "s/^\[\([[:alnum:]_-]*\)\]/\1/p" < $1
}
if [ ! -f "$HOST_OPTIONS" ]; then
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] common/config: Allow sections names to contain hyphen
2020-06-25 12:37 [PATCH] common/config: Allow sections names to contain hyphen Nikolay Borisov
@ 2020-08-26 16:04 ` Nikolay Borisov
2020-08-30 16:25 ` Eryu Guan
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Borisov @ 2020-08-26 16:04 UTC (permalink / raw)
To: guaneryu; +Cc: fstests
On 25.06.20 г. 15:37 ч., Nikolay Borisov wrote:
> Current regular expression in get_config_sections allows section names
> to consist of alphanumeric character and underscore. Extend it to
> also allow the hyphen '-' character.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
This patch seems to have fallen through the cracks so - ping ?
> common/config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/config b/common/config
> index 8023273da115..63d486125a76 100644
> --- a/common/config
> +++ b/common/config
> @@ -449,7 +449,7 @@ known_hosts()
> # in the section name otherwise the section will not be resognised.
> # Section name must be contained between square brackets.
> get_config_sections() {
> - sed -n -e "s/^\[\([[:alnum:]_]*\)\]/\1/p" < $1
> + sed -n -e "s/^\[\([[:alnum:]_-]*\)\]/\1/p" < $1
> }
>
> if [ ! -f "$HOST_OPTIONS" ]; then
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] common/config: Allow sections names to contain hyphen
2020-06-25 12:37 [PATCH] common/config: Allow sections names to contain hyphen Nikolay Borisov
2020-08-26 16:04 ` Nikolay Borisov
@ 2020-08-30 16:25 ` Eryu Guan
1 sibling, 0 replies; 3+ messages in thread
From: Eryu Guan @ 2020-08-30 16:25 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: guaneryu, fstests
On Thu, Jun 25, 2020 at 03:37:44PM +0300, Nikolay Borisov wrote:
> Current regular expression in get_config_sections allows section names
> to consist of alphanumeric character and underscore. Extend it to
> also allow the hyphen '-' character.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Sorry, this patch fell off my radar.. Applied!
Thanks,
Eryu
> ---
> common/config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/config b/common/config
> index 8023273da115..63d486125a76 100644
> --- a/common/config
> +++ b/common/config
> @@ -449,7 +449,7 @@ known_hosts()
> # in the section name otherwise the section will not be resognised.
> # Section name must be contained between square brackets.
> get_config_sections() {
> - sed -n -e "s/^\[\([[:alnum:]_]*\)\]/\1/p" < $1
> + sed -n -e "s/^\[\([[:alnum:]_-]*\)\]/\1/p" < $1
> }
>
> if [ ! -f "$HOST_OPTIONS" ]; then
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-30 16:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-25 12:37 [PATCH] common/config: Allow sections names to contain hyphen Nikolay Borisov
2020-08-26 16:04 ` Nikolay Borisov
2020-08-30 16:25 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).