about the format problem at generic/556, and supply a fix patch

about the format problem at generic/556, and supply a fix patch

[蔡晓斌]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]


Hi, when I test my project with xfstests, I found that format problem at generic/556, it looks no like a script, so I adjust format and look so well.


Below is the concent of the patch, and patch file at attachments:



From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
From: "cai.xiaobin" <cai.xiaobin@gd-linux.com>
Date: Wed, 20 Mar 2024 11:13:29 +0800
Subject: [PATCH] generic/556: reverse the order of comments to make the file
 look more like a script file


---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/tests/generic/556 b/tests/generic/556
index 404a3243..ccefbcc4 100755
--- a/tests/generic/556
+++ b/tests/generic/556
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
-- 
2.25.1


Thank you and looking forward to your reply.

[-- Attachment #2: 0001-generic-556-reverse-the-order-of-comments-to-make-th.patch --]
[-- Type: application/octet-stream, Size: 682 bytes --]

From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
From: "cai.xiaobin" <cai.xiaobin@gd-linux.com>
Date: Wed, 20 Mar 2024 11:13:29 +0800
Subject: [PATCH] generic/556: reverse the order of comments to make the file
 look more like a script file

---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/556 b/tests/generic/556
index 404a3243..ccefbcc4 100755
--- a/tests/generic/556
+++ b/tests/generic/556
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
-- 
2.25.1

Re: about the format problem at generic/556, and supply a fix patch

[David Disseldorp]

Hi,

On Tue, 2 Apr 2024 09:41:49 +0800 (CST), 蔡晓斌 wrote:
...
> From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
> From: "cai.xiaobin" <cai.xiaobin@gd-linux.com>
> Date: Wed, 20 Mar 2024 11:13:29 +0800
> Subject: [PATCH] generic/556: reverse the order of comments to make the file
>  look more like a script file
> 
> 
> ---
>  tests/generic/556 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/tests/generic/556 b/tests/generic/556
> index 404a3243..ccefbcc4 100755
> --- a/tests/generic/556
> +++ b/tests/generic/556
> @@ -1,5 +1,5 @@
> -# SPDX-License-Identifier: GPL-2.0+
>  #!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0+
>  # FS QA Test No. 556
>  #
>  # Test the basic functionality of filesystems with case-insensitive

Looks fine to me, although I'd suggest a simpler patch description:
  generic/556: move shebang to first line

Reviewed-by: David Disseldorp <ddiss@suse.de>

Re:Re: about the format problem at generic/556, and supply a fix patch

[蔡晓斌]

At 2024-04-02 12:51:35, "David Disseldorp" <ddiss@suse.de> wrote:
>Hi,
>
>On Tue, 2 Apr 2024 09:41:49 +0800 (CST), 蔡晓斌 wrote:
>...
>> From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
>> From: "cai.xiaobin" <cai.xiaobin@gd-linux.com>
>> Date: Wed, 20 Mar 2024 11:13:29 +0800
>> Subject: [PATCH] generic/556: reverse the order of comments to make the file
>>  look more like a script file
>> 
>> 
>> ---
>>  tests/generic/556 | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> 
>> diff --git a/tests/generic/556 b/tests/generic/556
>> index 404a3243..ccefbcc4 100755
>> --- a/tests/generic/556
>> +++ b/tests/generic/556
>> @@ -1,5 +1,5 @@
>> -# SPDX-License-Identifier: GPL-2.0+
>>  #!/bin/bash
>> +# SPDX-License-Identifier: GPL-2.0+
>>  # FS QA Test No. 556
>>  #
>>  # Test the basic functionality of filesystems with case-insensitive
>
>Looks fine to me, although I'd suggest a simpler patch description:
>  generic/556: move shebang to first line

>
>Reviewed-by: David Disseldorp <ddiss@suse.de>


Wow, your suggestion is good. Do I need to provide another patch with a correction commit?
Thank you for your reply.

Re: Re: about the format problem at generic/556, and supply a fix patch

[Zorro Lang]

On Tue, Apr 02, 2024 at 02:22:14PM +0800, 蔡晓斌 wrote:
> 
> 
> 
> At 2024-04-02 12:51:35, "David Disseldorp" <ddiss@suse.de> wrote:
> >Hi,
> >
> >On Tue, 2 Apr 2024 09:41:49 +0800 (CST), 蔡晓斌 wrote:
> >...
> >> From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
> >> From: "cai.xiaobin" <cai.xiaobin@gd-linux.com>
> >> Date: Wed, 20 Mar 2024 11:13:29 +0800
> >> Subject: [PATCH] generic/556: reverse the order of comments to make the file
> >>  look more like a script file
> >> 
> >> 
> >> ---
> >>  tests/generic/556 | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> 
> >> diff --git a/tests/generic/556 b/tests/generic/556
> >> index 404a3243..ccefbcc4 100755
> >> --- a/tests/generic/556
> >> +++ b/tests/generic/556
> >> @@ -1,5 +1,5 @@
> >> -# SPDX-License-Identifier: GPL-2.0+
> >>  #!/bin/bash
> >> +# SPDX-License-Identifier: GPL-2.0+
> >>  # FS QA Test No. 556
> >>  #
> >>  # Test the basic functionality of filesystems with case-insensitive
> >
> >Looks fine to me, although I'd suggest a simpler patch description:
> >  generic/556: move shebang to first line
> 
> >
> >Reviewed-by: David Disseldorp <ddiss@suse.de>
> 
> 
> Wow, your suggestion is good. Do I need to provide another patch with a correction commit?
> Thank you for your reply.

Looks like there're many special characters in this patch, please send a
normal "pure text" patch, with a proper subject and commit log. 

Thanks,
Zorro

Re:Re: Re: about the format problem at generic/556, and supply a fix patch

[蔡晓斌]

[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]


At 2024-04-03 18:54:45, "Zorro Lang" <zlang@redhat.com> wrote:
>On Tue, Apr 02, 2024 at 02:22:14PM +0800, 蔡晓斌 wrote:
>> 
>
>Looks like there're many special characters in this patch, please send a
>normal "pure text" patch, with a proper subject and commit log. 

>
The content of patch as below and see attachment for the file.

From edf74d60a83554ad2c85a86ab032767eafe75a9e Mon Sep 17 00:00:00 2001
From: cz0807bin <caixiaobin0807@163.com>
Date: Sun, 7 Apr 2024 09:47:20 +0800
Subject: [PATCH] generic/556: move shebang to first line.

There is format problem of tests/generic/556 file and looks not like a script when it run.
So makes a change of order of first line to looks well.
---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/556 b/tests/generic/556
index 404a3243..ccefbcc4 100755
--- a/tests/generic/556
+++ b/tests/generic/556
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
-- 
2.25.1

If there is any question about the patch, please tell me how to do, and I will fix it.
Thank you for reply.

[-- Attachment #2: 0001-generic-556-move-shebang-to-first-line.patch --]
[-- Type: application/octet-stream, Size: 773 bytes --]

From edf74d60a83554ad2c85a86ab032767eafe75a9e Mon Sep 17 00:00:00 2001
From: cz0807bin <caixiaobin0807@163.com>
Date: Sun, 7 Apr 2024 09:47:20 +0800
Subject: [PATCH] generic/556: move shebang to first line.

There is format problem of tests/generic/556 file and looks not like a script when it run.
So makes a change of order of first line to looks well.
---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/556 b/tests/generic/556
index 404a3243..ccefbcc4 100755
--- a/tests/generic/556
+++ b/tests/generic/556
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
-- 
2.25.1

Re: Re: Re: about the format problem at generic/556, and supply a fix patch

[Zorro Lang]

On Sun, Apr 07, 2024 at 10:10:34AM +0800, 蔡晓斌 wrote:
> 
> At 2024-04-03 18:54:45, "Zorro Lang" <zlang@redhat.com> wrote:
> >On Tue, Apr 02, 2024 at 02:22:14PM +0800, 蔡晓斌 wrote:
> >> 
> >
> >Looks like there're many special characters in this patch, please send a
> >normal "pure text" patch, with a proper subject and commit log. 
> 
> >
> The content of patch as below and see attachment for the file.

Generally we don't accept a patch as an attachment. But as this patch
is simple, I don't mind manually changing it and commit with your name
(for once). But ...

> 
> From edf74d60a83554ad2c85a86ab032767eafe75a9e Mon Sep 17 00:00:00 2001
> From: cz0807bin <caixiaobin0807@163.com>

Is the "cz0807bin" your name ?

> Date: Sun, 7 Apr 2024 09:47:20 +0800
> Subject: [PATCH] generic/556: move shebang to first line.
> 
> There is format problem of tests/generic/556 file and looks not like a script when it run.
> So makes a change of order of first line to looks well.

Don't you need a Signoff-by ?

Thanks,
Zorro

> ---
>  tests/generic/556 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/556 b/tests/generic/556
> index 404a3243..ccefbcc4 100755
> --- a/tests/generic/556
> +++ b/tests/generic/556
> @@ -1,5 +1,5 @@
> -# SPDX-License-Identifier: GPL-2.0+
>  #!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0+
>  # FS QA Test No. 556
>  #
>  # Test the basic functionality of filesystems with case-insensitive
> -- 
> 2.25.1
> 
> If there is any question about the patch, please tell me how to do, and I will fix it.
> Thank you for reply.