[PATCH] generic/645: Add hint for expected failure with old kernel

[PATCH] generic/645: Add hint for expected failure with old kernel

[Taylor Jackson via B4 Relay]

From: Taylor Jackson <tjackson9431@gmail.com>

The following hint is added to reflect that any old kernel
without kernel commit dacfd001eaf2 (“fs/mnt_idmapping.c: Return
-EINVAL when no map is written”) is expected to fail this generic
645 test since without that commit, mount_setattr won’t return
EINVAL when attempting to create an idmapped mount using a user
namespace with no mappings.

Reported-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Taylor Jackson <tjackson9431@gmail.com>
---
 tests/generic/645 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/generic/645 b/tests/generic/645
index 556d2450..bcc3e3b5 100755
--- a/tests/generic/645
+++ b/tests/generic/645
@@ -17,6 +17,8 @@ _begin_fstest auto quick idmapped mount
 _supported_fs generic
 _require_idmapped_mounts
 _require_test
+_fixed_by_kernel_commit dacfd001eaf2 \
+	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
 
 echo "Silence is golden"
 

---
base-commit: e72e052d56c3f05e533f4b67056f86931f688368
change-id: 20240417-generic-test-645-18750d02523e

Best regards,
-- 
Taylor Jackson <tjackson9431@gmail.com>

Re: [PATCH] generic/645: Add hint for expected failure with old kernel

[Zorro Lang]

On Wed, Apr 17, 2024 at 07:34:24PM +0000, Taylor Jackson via B4 Relay wrote:
> From: Taylor Jackson <tjackson9431@gmail.com>
> 
> The following hint is added to reflect that any old kernel
> without kernel commit dacfd001eaf2 (“fs/mnt_idmapping.c: Return
> -EINVAL when no map is written”) is expected to fail this generic
> 645 test since without that commit, mount_setattr won’t return
> EINVAL when attempting to create an idmapped mount using a user
> namespace with no mappings.
> 
> Reported-by: Zorro Lang <zlang@redhat.com>
> Signed-off-by: Taylor Jackson <tjackson9431@gmail.com>
> ---
>  tests/generic/645 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/generic/645 b/tests/generic/645
> index 556d2450..bcc3e3b5 100755
> --- a/tests/generic/645
> +++ b/tests/generic/645
> @@ -17,6 +17,8 @@ _begin_fstest auto quick idmapped mount
>  _supported_fs generic
>  _require_idmapped_mounts
>  _require_test
> +_fixed_by_kernel_commit dacfd001eaf2 \
> +	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"

Thanks for helping to confirm that. Just, if it's not a regression bug
fix, maybe better to replace the "_fixed_by_kernel_commit" with the
"_wants_kernel_commit". If no objection, I can change that when I
merge this patch :)

Reviewed-by: Zorro Lang <zlang@redhat.com>

Thanks,
Zorro

>  
>  echo "Silence is golden"
>  
> 
> ---
> base-commit: e72e052d56c3f05e533f4b67056f86931f688368
> change-id: 20240417-generic-test-645-18750d02523e
> 
> Best regards,
> -- 
> Taylor Jackson <tjackson9431@gmail.com>
> 
> 
> 

Re: [PATCH] generic/645: Add hint for expected failure with old kernel

[Christian Brauner]

On Wed, Apr 17, 2024 at 07:34:24PM +0000, Taylor Jackson via B4 Relay wrote:
> From: Taylor Jackson <tjackson9431@gmail.com>
> 
> The following hint is added to reflect that any old kernel
> without kernel commit dacfd001eaf2 (“fs/mnt_idmapping.c: Return
> -EINVAL when no map is written”) is expected to fail this generic
> 645 test since without that commit, mount_setattr won’t return
> EINVAL when attempting to create an idmapped mount using a user
> namespace with no mappings.
> 
> Reported-by: Zorro Lang <zlang@redhat.com>
> Signed-off-by: Taylor Jackson <tjackson9431@gmail.com>
> ---

Thank you!
Reviewed-by: Christian Brauner <brauner@kernel.org>