[PATCH] fstests: btrfs/249, add _wants_kernel_commit

[PATCH] fstests: btrfs/249, add _wants_kernel_commit

[Anand Jain]

Add the _wants_kernel_commit tag for the benifit of testing on the older
kernels.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 tests/btrfs/249 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/btrfs/249 b/tests/btrfs/249
index 7cc4996e387b..1b79e52dbe05 100755
--- a/tests/btrfs/249
+++ b/tests/btrfs/249
@@ -13,7 +13,7 @@
 #  Dump 'btrfs filesystem usage', check it didn't fail
 #
 # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
-#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
+#   btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device
 #   btrfs-progs: read fsid from the sysfs in device_is_seed
 
 . ./common/preamble
@@ -29,6 +29,8 @@ _supported_fs btrfs
 _require_scratch_dev_pool 3
 _require_command "$WIPEFS_PROG" wipefs
 _require_btrfs_forget_or_module_loadable
+_wants_kernel_commit a26d60dedf9a \
+	"btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
 
 _scratch_dev_pool_get 2
 # use the scratch devices as seed devices
-- 
2.31.1

Re: [PATCH] fstests: btrfs/249, add _wants_kernel_commit

[Filipe Manana]

On Mon, Feb 13, 2023 at 9:58 AM Anand Jain <anand.jain@oracle.com> wrote:
>
> Add the _wants_kernel_commit tag for the benifit of testing on the older
> kernels.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
>  tests/btrfs/249 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/249 b/tests/btrfs/249
> index 7cc4996e387b..1b79e52dbe05 100755
> --- a/tests/btrfs/249
> +++ b/tests/btrfs/249
> @@ -13,7 +13,7 @@
>  #  Dump 'btrfs filesystem usage', check it didn't fail
>  #
>  # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
> -#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
> +#   btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device
>  #   btrfs-progs: read fsid from the sysfs in device_is_seed
>
>  . ./common/preamble
> @@ -29,6 +29,8 @@ _supported_fs btrfs
>  _require_scratch_dev_pool 3
>  _require_command "$WIPEFS_PROG" wipefs
>  _require_btrfs_forget_or_module_loadable
> +_wants_kernel_commit a26d60dedf9a \
> +       "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"

There's a btrfs-progs patch listed above, so you can also add a:

 _fixed_by_git_commit btrfs-progs xxxxxxxxxxxx "btrfs-progs: read fsid
from the sysfs in device_is_seed"

And with that, you can then remove the comment above with the patch
subjects, as it becomes redundant and pointless.

Thanks.

>
>  _scratch_dev_pool_get 2
>  # use the scratch devices as seed devices
> --
> 2.31.1
>

Re: [PATCH] fstests: btrfs/249, add _wants_kernel_commit

[Zorro Lang]

On Mon, Feb 13, 2023 at 05:45:09PM +0800, Anand Jain wrote:
> Add the _wants_kernel_commit tag for the benifit of testing on the older
> kernels.
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---

Besides this patch, you just sent another patchset:
  [PATCH 0/3] fstests: btrfs- add _fixed_by for new tests in the auto group
which try to add _fixed_by for some btrfs cases.

I think we don't need to "fix" these things one by one, by lots of small patch
pieces. If there's not special reason (e.g. someone case need more fix besides
adding _fixed_by), how about combine them into one patch which "clarify the
_fixed_by or _wants commits for btrfs cases (or only for someone group)"

Thanks,
Zorro

>  tests/btrfs/249 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/btrfs/249 b/tests/btrfs/249
> index 7cc4996e387b..1b79e52dbe05 100755
> --- a/tests/btrfs/249
> +++ b/tests/btrfs/249
> @@ -13,7 +13,7 @@
>  #  Dump 'btrfs filesystem usage', check it didn't fail
>  #
>  # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
> -#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
> +#   btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device
>  #   btrfs-progs: read fsid from the sysfs in device_is_seed
>  
>  . ./common/preamble
> @@ -29,6 +29,8 @@ _supported_fs btrfs
>  _require_scratch_dev_pool 3
>  _require_command "$WIPEFS_PROG" wipefs
>  _require_btrfs_forget_or_module_loadable
> +_wants_kernel_commit a26d60dedf9a \
> +	"btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
>  
>  _scratch_dev_pool_get 2
>  # use the scratch devices as seed devices
> -- 
> 2.31.1
> 

Re: [PATCH] fstests: btrfs/249, add _wants_kernel_commit

[Anand Jain]

On 2/14/23 14:17, Zorro Lang wrote:
> On Mon, Feb 13, 2023 at 05:45:09PM +0800, Anand Jain wrote:
>> Add the _wants_kernel_commit tag for the benifit of testing on the older
>> kernels.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
> 
> Besides this patch, you just sent another patchset:
>    [PATCH 0/3] fstests: btrfs- add _fixed_by for new tests in the auto group
> which try to add _fixed_by for some btrfs cases.
> 

  Recently, these were added to the auto group.

> I think we don't need to "fix" these things one by one, by lots of small patch
> pieces. 

  ok.

> If there's not special reason (e.g. someone case need more fix besides
> adding _fixed_by), how about combine them into one patch which "clarify the
> _fixed_by or _wants commits for btrfs cases (or only for someone group)"
> 

  Hmm.
  btrfs/249 needs _wants_kernel_commit; btrfs/198, btrfs/185, and
  btrfs/219 need _fixed_by_kernel_commit. Merge the latter and
  send as one patch?

Thanks, Anand


> Thanks,
> Zorro
> 
>>   tests/btrfs/249 | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/249 b/tests/btrfs/249
>> index 7cc4996e387b..1b79e52dbe05 100755
>> --- a/tests/btrfs/249
>> +++ b/tests/btrfs/249
>> @@ -13,7 +13,7 @@
>>   #  Dump 'btrfs filesystem usage', check it didn't fail
>>   #
>>   # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
>> -#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
>> +#   btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device
>>   #   btrfs-progs: read fsid from the sysfs in device_is_seed
>>   
>>   . ./common/preamble
>> @@ -29,6 +29,8 @@ _supported_fs btrfs
>>   _require_scratch_dev_pool 3
>>   _require_command "$WIPEFS_PROG" wipefs
>>   _require_btrfs_forget_or_module_loadable
>> +_wants_kernel_commit a26d60dedf9a \
>> +	"btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
>>   
>>   _scratch_dev_pool_get 2
>>   # use the scratch devices as seed devices
>> -- 
>> 2.31.1
>>
> 

Re: [PATCH] fstests: btrfs/249, add _wants_kernel_commit

[Anand Jain]

On 2/13/23 19:56, Filipe Manana wrote:
> On Mon, Feb 13, 2023 at 9:58 AM Anand Jain <anand.jain@oracle.com> wrote:
>>
>> Add the _wants_kernel_commit tag for the benifit of testing on the older
>> kernels.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>>   tests/btrfs/249 | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/249 b/tests/btrfs/249
>> index 7cc4996e387b..1b79e52dbe05 100755
>> --- a/tests/btrfs/249
>> +++ b/tests/btrfs/249
>> @@ -13,7 +13,7 @@
>>   #  Dump 'btrfs filesystem usage', check it didn't fail
>>   #
>>   # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
>> -#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
>> +#   btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device
>>   #   btrfs-progs: read fsid from the sysfs in device_is_seed
>>
>>   . ./common/preamble
>> @@ -29,6 +29,8 @@ _supported_fs btrfs
>>   _require_scratch_dev_pool 3
>>   _require_command "$WIPEFS_PROG" wipefs
>>   _require_btrfs_forget_or_module_loadable
>> +_wants_kernel_commit a26d60dedf9a \
>> +       "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
> 
> There's a btrfs-progs patch listed above, so you can also add a:
> 
>   _fixed_by_git_commit btrfs-progs xxxxxxxxxxxx "btrfs-progs: read fsid
> from the sysfs in device_is_seed"
> 
> And with that, you can then remove the comment above with the patch
> subjects, as it becomes redundant and pointless.
> 

  Got it. Fixing in v2.

Thanks.

> Thanks.
> 
>>
>>   _scratch_dev_pool_get 2
>>   # use the scratch devices as seed devices
>> --
>> 2.31.1
>>

Re: [PATCH] fstests: btrfs/249, add _wants_kernel_commit

[Zorro Lang]

On Wed, Feb 15, 2023 at 12:34:14AM +0800, Anand Jain wrote:
> On 2/14/23 14:17, Zorro Lang wrote:
> > On Mon, Feb 13, 2023 at 05:45:09PM +0800, Anand Jain wrote:
> > > Add the _wants_kernel_commit tag for the benifit of testing on the older
> > > kernels.
> > > 
> > > Signed-off-by: Anand Jain <anand.jain@oracle.com>
> > > ---
> > 
> > Besides this patch, you just sent another patchset:
> >    [PATCH 0/3] fstests: btrfs- add _fixed_by for new tests in the auto group
> > which try to add _fixed_by for some btrfs cases.
> > 
> 
>  Recently, these were added to the auto group.
> 
> > I think we don't need to "fix" these things one by one, by lots of small patch
> > pieces.
> 
>  ok.
> 
> > If there's not special reason (e.g. someone case need more fix besides
> > adding _fixed_by), how about combine them into one patch which "clarify the
> > _fixed_by or _wants commits for btrfs cases (or only for someone group)"
> > 
> 
>  Hmm.
>  btrfs/249 needs _wants_kernel_commit; btrfs/198, btrfs/185, and
>  btrfs/219 need _fixed_by_kernel_commit. Merge the latter and
>  send as one patch?

Either one or two patch are good to me, just don't need to one patch only add
one _fixed_by/_wants :)

Thanks,
Zorro

> 
> Thanks, Anand
> 
> 
> > Thanks,
> > Zorro
> > 
> > >   tests/btrfs/249 | 4 +++-
> > >   1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/btrfs/249 b/tests/btrfs/249
> > > index 7cc4996e387b..1b79e52dbe05 100755
> > > --- a/tests/btrfs/249
> > > +++ b/tests/btrfs/249
> > > @@ -13,7 +13,7 @@
> > >   #  Dump 'btrfs filesystem usage', check it didn't fail
> > >   #
> > >   # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
> > > -#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
> > > +#   btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device
> > >   #   btrfs-progs: read fsid from the sysfs in device_is_seed
> > >   . ./common/preamble
> > > @@ -29,6 +29,8 @@ _supported_fs btrfs
> > >   _require_scratch_dev_pool 3
> > >   _require_command "$WIPEFS_PROG" wipefs
> > >   _require_btrfs_forget_or_module_loadable
> > > +_wants_kernel_commit a26d60dedf9a \
> > > +	"btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
> > >   _scratch_dev_pool_get 2
> > >   # use the scratch devices as seed devices
> > > -- 
> > > 2.31.1
> > > 
> > 
> 

[PATCH v2] fstests: btrfs/249: add _wants_kernel_commit

[Anand Jain]

Add the _wants_kernel_commit tag for the benifit of testing on the older
kernels.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
v2: Include the necessary btrfs-progs patch.

 tests/btrfs/249 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/btrfs/249 b/tests/btrfs/249
index 7cc4996e387b..06cc444b5d7a 100755
--- a/tests/btrfs/249
+++ b/tests/btrfs/249
@@ -12,9 +12,6 @@
 #  Create a sprout filesystem (an rw device on top of a seed device)
 #  Dump 'btrfs filesystem usage', check it didn't fail
 #
-# Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
-#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
-#   btrfs-progs: read fsid from the sysfs in device_is_seed
 
 . ./common/preamble
 _begin_fstest auto quick seed volume
@@ -29,6 +26,10 @@ _supported_fs btrfs
 _require_scratch_dev_pool 3
 _require_command "$WIPEFS_PROG" wipefs
 _require_btrfs_forget_or_module_loadable
+_wants_kernel_commit a26d60dedf9a \
+	"btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
+_fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \
+	"btrfs-progs: read fsid from the sysfs in device_is_seed"
 
 _scratch_dev_pool_get 2
 # use the scratch devices as seed devices
-- 
2.31.1

Re: [PATCH v2] fstests: btrfs/249: add _wants_kernel_commit

[Filipe Manana]

On Wed, Feb 15, 2023 at 7:54 AM Anand Jain <anand.jain@oracle.com> wrote:
>
> Add the _wants_kernel_commit tag for the benifit of testing on the older
> kernels.

And the _fixed_by_git_commit tag for btrfs-progs too.
The subject is also no longer up to date too.

s/benifit/benefit/

Otherwise looks good, thanks

Reviewed-by: Filipe Manana <fdmanana@suse.com>


>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> v2: Include the necessary btrfs-progs patch.
>
>  tests/btrfs/249 | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/btrfs/249 b/tests/btrfs/249
> index 7cc4996e387b..06cc444b5d7a 100755
> --- a/tests/btrfs/249
> +++ b/tests/btrfs/249
> @@ -12,9 +12,6 @@
>  #  Create a sprout filesystem (an rw device on top of a seed device)
>  #  Dump 'btrfs filesystem usage', check it didn't fail
>  #
> -# Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
> -#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
> -#   btrfs-progs: read fsid from the sysfs in device_is_seed
>
>  . ./common/preamble
>  _begin_fstest auto quick seed volume
> @@ -29,6 +26,10 @@ _supported_fs btrfs
>  _require_scratch_dev_pool 3
>  _require_command "$WIPEFS_PROG" wipefs
>  _require_btrfs_forget_or_module_loadable
> +_wants_kernel_commit a26d60dedf9a \
> +       "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
> +_fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \
> +       "btrfs-progs: read fsid from the sysfs in device_is_seed"
>
>  _scratch_dev_pool_get 2
>  # use the scratch devices as seed devices
> --
> 2.31.1
>

Re: [PATCH v2] fstests: btrfs/249: add _wants_kernel_commit

[Anand Jain]

On 15/02/2023 18:55, Filipe Manana wrote:
> On Wed, Feb 15, 2023 at 7:54 AM Anand Jain <anand.jain@oracle.com> wrote:
>>
>> Add the _wants_kernel_commit tag for the benifit of testing on the older
>> kernels.
> 
> And the _fixed_by_git_commit tag for btrfs-progs too.
> The subject is also no longer up to date too.
> 
> s/benifit/benefit/
> 
> Otherwise looks good, thanks
> 
> Reviewed-by: Filipe Manana <fdmanana@suse.com>

Thanks. Fixed them in v3.
-Anand.

> 
> 
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>> v2: Include the necessary btrfs-progs patch.
>>
>>   tests/btrfs/249 | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/btrfs/249 b/tests/btrfs/249
>> index 7cc4996e387b..06cc444b5d7a 100755
>> --- a/tests/btrfs/249
>> +++ b/tests/btrfs/249
>> @@ -12,9 +12,6 @@
>>   #  Create a sprout filesystem (an rw device on top of a seed device)
>>   #  Dump 'btrfs filesystem usage', check it didn't fail
>>   #
>> -# Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
>> -#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
>> -#   btrfs-progs: read fsid from the sysfs in device_is_seed
>>
>>   . ./common/preamble
>>   _begin_fstest auto quick seed volume
>> @@ -29,6 +26,10 @@ _supported_fs btrfs
>>   _require_scratch_dev_pool 3
>>   _require_command "$WIPEFS_PROG" wipefs
>>   _require_btrfs_forget_or_module_loadable
>> +_wants_kernel_commit a26d60dedf9a \
>> +       "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
>> +_fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \
>> +       "btrfs-progs: read fsid from the sysfs in device_is_seed"
>>
>>   _scratch_dev_pool_get 2
>>   # use the scratch devices as seed devices
>> --
>> 2.31.1
>>

[PATCH v3] Subject: [PATCH v3] fstests: btrfs/249: add _wants_kernel_commit and _fixed_by_git_commit

[Anand Jain]

Add the _wants_kernel_commit tag for kernel and _fixed_by_git_commit tag
for the btrfs-progs for the benefit of testing on the older kernels and
the older btrfs-progs.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
---
v3: Fix title and change log
    Old title: fstests: btrfs/249: add _wants_kernel_commit
v2: Include the necessary btrfs-progs patch.

 tests/btrfs/249 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/btrfs/249 b/tests/btrfs/249
index 7cc4996e387b..06cc444b5d7a 100755
--- a/tests/btrfs/249
+++ b/tests/btrfs/249
@@ -12,9 +12,6 @@
 #  Create a sprout filesystem (an rw device on top of a seed device)
 #  Dump 'btrfs filesystem usage', check it didn't fail
 #
-# Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
-#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
-#   btrfs-progs: read fsid from the sysfs in device_is_seed
 
 . ./common/preamble
 _begin_fstest auto quick seed volume
@@ -29,6 +26,10 @@ _supported_fs btrfs
 _require_scratch_dev_pool 3
 _require_command "$WIPEFS_PROG" wipefs
 _require_btrfs_forget_or_module_loadable
+_wants_kernel_commit a26d60dedf9a \
+	"btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
+_fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \
+	"btrfs-progs: read fsid from the sysfs in device_is_seed"
 
 _scratch_dev_pool_get 2
 # use the scratch devices as seed devices
-- 
2.38.1

[PATCH v4] fstests: btrfs/249: add _wants_kernel_commit and _fixed_by_git_commit

[Anand Jain]

Add the _wants_kernel_commit tag for kernel and _fixed_by_git_commit tag
for the btrfs-progs for the benefit of testing on the older kernels and
the older btrfs-progs.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
---
v4: Patch title fixed.
v3: Fix title and change log
    Old title: fstests: btrfs/249: add _wants_kernel_commit
v2: Include the necessary btrfs-progs patch.
 tests/btrfs/249 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/btrfs/249 b/tests/btrfs/249
index 7cc4996e387b..06cc444b5d7a 100755
--- a/tests/btrfs/249
+++ b/tests/btrfs/249
@@ -12,9 +12,6 @@
 #  Create a sprout filesystem (an rw device on top of a seed device)
 #  Dump 'btrfs filesystem usage', check it didn't fail
 #
-# Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
-#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
-#   btrfs-progs: read fsid from the sysfs in device_is_seed
 
 . ./common/preamble
 _begin_fstest auto quick seed volume
@@ -29,6 +26,10 @@ _supported_fs btrfs
 _require_scratch_dev_pool 3
 _require_command "$WIPEFS_PROG" wipefs
 _require_btrfs_forget_or_module_loadable
+_wants_kernel_commit a26d60dedf9a \
+	"btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
+_fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \
+	"btrfs-progs: read fsid from the sysfs in device_is_seed"
 
 _scratch_dev_pool_get 2
 # use the scratch devices as seed devices
-- 
2.38.1