* [PATCH] xfs/097: Add suitable metadata options in mkfs when test finobt
@ 2019-08-07 9:21 Yong Sun
2019-08-07 20:51 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Yong Sun @ 2019-08-07 9:21 UTC (permalink / raw)
To: fstests
Hi all,
When test xfs/097 in my test machine, it always skips and print "[not run] finobt not enabled". I add one line change, and this test could runs OK.
Signed-off-by: Yong Sun <yosun@suse.com>
---
tests/xfs/097 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/097 b/tests/xfs/097
index 68eae1d4..1cb7d69c 100755
--- a/tests/xfs/097
+++ b/tests/xfs/097
@@ -46,7 +46,7 @@ TESTDIR="${SCRATCH_MNT}/scratchdir"
TESTFILE="${TESTDIR}/testfile"
echo "+ create scratch fs"
-_scratch_mkfs_xfs > /dev/null
+_scratch_mkfs_xfs -m crc=1,finobt=1 > /dev/null
echo "+ mount fs image"
_scratch_mount
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/097: Add suitable metadata options in mkfs when test finobt
2019-08-07 9:21 [PATCH] xfs/097: Add suitable metadata options in mkfs when test finobt Yong Sun
@ 2019-08-07 20:51 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2019-08-07 20:51 UTC (permalink / raw)
To: Yong Sun, fstests
On 8/7/19 4:21 AM, Yong Sun wrote:
> Hi all,
>
> When test xfs/097 in my test machine, it always skips and print "[not run] finobt not enabled". I add one line change, and this test could runs OK.
This should be safe, because the test already does:
_require_xfs_mkfs_finobt
_require_xfs_finobt
and that first _require ensures that crc=1,finobt=1 will work
even if it's not on by default in mkfs.
>
> Signed-off-by: Yong Sun <yosun@suse.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> tests/xfs/097 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/097 b/tests/xfs/097
> index 68eae1d4..1cb7d69c 100755
> --- a/tests/xfs/097
> +++ b/tests/xfs/097
> @@ -46,7 +46,7 @@ TESTDIR="${SCRATCH_MNT}/scratchdir"
> TESTFILE="${TESTDIR}/testfile"
>
> echo "+ create scratch fs"
> -_scratch_mkfs_xfs > /dev/null
> +_scratch_mkfs_xfs -m crc=1,finobt=1 > /dev/null
>
> echo "+ mount fs image"
> _scratch_mount
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-07 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 9:21 [PATCH] xfs/097: Add suitable metadata options in mkfs when test finobt Yong Sun
2019-08-07 20:51 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).