* [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file
@ 2020-08-05 2:45 Xiao Yang
2020-08-05 2:55 ` Xiao Yang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Xiao Yang @ 2020-08-05 2:45 UTC (permalink / raw)
To: fstests; +Cc: darrick.wong, ira.weiny, guaneryu, Xiao Yang
Change FS_XFLAG_DAX on an existing file and check if S_DAX on the
file can take effect immediately by the following steps:
1) Stop all applications which are using the file.
2) Do drop_caches or umount & mount cycle.
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
Note: It is based on the following patch set:
https://www.spinics.net/lists/fstests/msg14457.html
V1->V2:
Add a combination(without dax option) to do tests.
tests/generic/608 | 121 ++++++++++++++++++++++++++++++++++++++++++
tests/generic/608.out | 2 +
tests/generic/group | 1 +
3 files changed, 124 insertions(+)
create mode 100644 tests/generic/608
create mode 100644 tests/generic/608.out
diff --git a/tests/generic/608 b/tests/generic/608
new file mode 100644
index 00000000..705ae4b3
--- /dev/null
+++ b/tests/generic/608
@@ -0,0 +1,121 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2020 Fujitsu. All Rights Reserved.
+#
+# FS QA Test 608
+# Change FS_XFLAG_DAX on an existing file and check if S_DAX on
+# the file can take effect immediately by the following steps:
+# 1) Stop all applications which are using the file.
+# 2) Do drop_caches or umount & mount cycle.
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+_supported_fs generic
+_supported_os Linux
+_require_scratch_dax_mountopt "dax=always"
+_require_dax_iflag
+_require_xfs_io_command "lsattr" "-v"
+_require_xfs_io_command "statx" "-r"
+
+test_drop_caches()
+{
+ local t_file=$SCRATCH_MNT/testfile
+
+ rm -f $t_file
+ touch $t_file
+ _check_xflag $t_file 0
+ _check_s_dax $t_file 0
+
+ exec 3< $t_file
+
+ $XFS_IO_PROG -c 'chattr +x' $t_file
+ _check_xflag $t_file 1
+ _check_s_dax $t_file 0
+
+ # One application is using test file and check if S_DAX on
+ # the file doesn't take effect immediately by drop_caches
+ echo 2 > /proc/sys/vm/drop_caches
+ _check_s_dax $t_file 0
+
+ exec 3<&-
+
+ # No application is using test file and check if S_DAX on
+ # the file takes effect immediately by drop_caches
+ echo 2 > /proc/sys/vm/drop_caches
+ _check_s_dax $t_file 1
+}
+
+test_cycle_mount()
+{
+ local option=$1
+ local t_dir=$SCRATCH_MNT/testdir
+ local t_file=$t_dir/testfile
+
+ mkdir -p $t_dir
+ $XFS_IO_PROG -c 'chattr +x' $t_dir
+ rm -f $t_file
+ touch $t_file
+ _check_xflag $t_file 1
+ _check_s_dax $t_file 1
+
+ exec 3< $t_file
+
+ $XFS_IO_PROG -c 'chattr -x' $t_file
+ _check_xflag $t_file 0
+ _check_s_dax $t_file 1
+
+ exec 3<&-
+
+ # No application is using test file and check if S_DAX on
+ # the file takes effect immediately by umount & mount
+ _scratch_cycle_mount "$option"
+ _check_s_dax $t_file 0
+}
+
+do_tests()
+{
+ local mount_option=$1
+ local cycle_mount_option=$2
+
+ _scratch_mount "$mount_option"
+
+ test_drop_caches
+
+ test_cycle_mount "$cycle_mount_option"
+
+ _scratch_unmount
+}
+
+_scratch_mkfs >> $seqres.full 2>&1
+
+# mount with dax option
+do_tests "-o dax=inode" "dax=inode"
+
+# mount without dax option
+export MOUNT_OPTIONS=""
+do_tests
+
+# success, all done
+echo "Silence is golden"
+status=0
+exit
diff --git a/tests/generic/608.out b/tests/generic/608.out
new file mode 100644
index 00000000..1e534458
--- /dev/null
+++ b/tests/generic/608.out
@@ -0,0 +1,2 @@
+QA output created by 608
+Silence is golden
diff --git a/tests/generic/group b/tests/generic/group
index 5bd289c3..aa969bcb 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -610,3 +610,4 @@
605 auto attr quick dax
606 auto attr quick dax
607 auto attr quick dax
+608 auto attr quick dax
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file
2020-08-05 2:45 [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file Xiao Yang
@ 2020-08-05 2:55 ` Xiao Yang
2020-08-05 4:36 ` Xiao Yang
2020-08-05 15:45 ` Darrick J. Wong
2020-08-06 19:35 ` Ira Weiny
2 siblings, 1 reply; 6+ messages in thread
From: Xiao Yang @ 2020-08-05 2:55 UTC (permalink / raw)
To: Xiao Yang; +Cc: fstests, darrick.wong, ira.weiny, guaneryu
Hi Darrick, Ira
If you prove the v2 patch, I will add the combination(without dax option)
into all related tests from my v8 patch set.
Thanks,
Xiao Yang
On 2020/8/5 10:45, Xiao Yang wrote:
> Change FS_XFLAG_DAX on an existing file and check if S_DAX on the
> file can take effect immediately by the following steps:
> 1) Stop all applications which are using the file.
> 2) Do drop_caches or umount & mount cycle.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>
> Note: It is based on the following patch set:
> https://www.spinics.net/lists/fstests/msg14457.html
>
> V1->V2:
> Add a combination(without dax option) to do tests.
>
> tests/generic/608 | 121 ++++++++++++++++++++++++++++++++++++++++++
> tests/generic/608.out | 2 +
> tests/generic/group | 1 +
> 3 files changed, 124 insertions(+)
> create mode 100644 tests/generic/608
> create mode 100644 tests/generic/608.out
>
> diff --git a/tests/generic/608 b/tests/generic/608
> new file mode 100644
> index 00000000..705ae4b3
> --- /dev/null
> +++ b/tests/generic/608
> @@ -0,0 +1,121 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2020 Fujitsu. All Rights Reserved.
> +#
> +# FS QA Test 608
> +# Change FS_XFLAG_DAX on an existing file and check if S_DAX on
> +# the file can take effect immediately by the following steps:
> +# 1) Stop all applications which are using the file.
> +# 2) Do drop_caches or umount & mount cycle.
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +_supported_fs generic
> +_supported_os Linux
> +_require_scratch_dax_mountopt "dax=always"
> +_require_dax_iflag
> +_require_xfs_io_command "lsattr" "-v"
> +_require_xfs_io_command "statx" "-r"
> +
> +test_drop_caches()
> +{
> + local t_file=$SCRATCH_MNT/testfile
> +
> + rm -f $t_file
> + touch $t_file
> + _check_xflag $t_file 0
> + _check_s_dax $t_file 0
> +
> + exec 3< $t_file
> +
> + $XFS_IO_PROG -c 'chattr +x' $t_file
> + _check_xflag $t_file 1
> + _check_s_dax $t_file 0
> +
> + # One application is using test file and check if S_DAX on
> + # the file doesn't take effect immediately by drop_caches
> + echo 2 > /proc/sys/vm/drop_caches
> + _check_s_dax $t_file 0
> +
> + exec 3<&-
> +
> + # No application is using test file and check if S_DAX on
> + # the file takes effect immediately by drop_caches
> + echo 2 > /proc/sys/vm/drop_caches
> + _check_s_dax $t_file 1
> +}
> +
> +test_cycle_mount()
> +{
> + local option=$1
> + local t_dir=$SCRATCH_MNT/testdir
> + local t_file=$t_dir/testfile
> +
> + mkdir -p $t_dir
> + $XFS_IO_PROG -c 'chattr +x' $t_dir
> + rm -f $t_file
> + touch $t_file
> + _check_xflag $t_file 1
> + _check_s_dax $t_file 1
> +
> + exec 3< $t_file
> +
> + $XFS_IO_PROG -c 'chattr -x' $t_file
> + _check_xflag $t_file 0
> + _check_s_dax $t_file 1
> +
> + exec 3<&-
> +
> + # No application is using test file and check if S_DAX on
> + # the file takes effect immediately by umount & mount
> + _scratch_cycle_mount "$option"
> + _check_s_dax $t_file 0
> +}
> +
> +do_tests()
> +{
> + local mount_option=$1
> + local cycle_mount_option=$2
> +
> + _scratch_mount "$mount_option"
> +
> + test_drop_caches
> +
> + test_cycle_mount "$cycle_mount_option"
> +
> + _scratch_unmount
> +}
> +
> +_scratch_mkfs >> $seqres.full 2>&1
> +
> +# mount with dax option
> +do_tests "-o dax=inode" "dax=inode"
> +
> +# mount without dax option
> +export MOUNT_OPTIONS=""
> +do_tests
> +
> +# success, all done
> +echo "Silence is golden"
> +status=0
> +exit
> diff --git a/tests/generic/608.out b/tests/generic/608.out
> new file mode 100644
> index 00000000..1e534458
> --- /dev/null
> +++ b/tests/generic/608.out
> @@ -0,0 +1,2 @@
> +QA output created by 608
> +Silence is golden
> diff --git a/tests/generic/group b/tests/generic/group
> index 5bd289c3..aa969bcb 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -610,3 +610,4 @@
> 605 auto attr quick dax
> 606 auto attr quick dax
> 607 auto attr quick dax
> +608 auto attr quick dax
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file
2020-08-05 2:55 ` Xiao Yang
@ 2020-08-05 4:36 ` Xiao Yang
0 siblings, 0 replies; 6+ messages in thread
From: Xiao Yang @ 2020-08-05 4:36 UTC (permalink / raw)
To: Xiao Yang; +Cc: fstests, darrick.wong, ira.weiny, guaneryu
On 2020/8/5 10:55, Xiao Yang wrote:
> Hi Darrick, Ira
>
> If you prove the v2 patch, I will add the combination(without dax option)
> into all related tests from my v8 patch set.
Sorry for a typo(s/prove/approve).
Thanks,
Xiao Yang
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file
2020-08-05 2:45 [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file Xiao Yang
2020-08-05 2:55 ` Xiao Yang
@ 2020-08-05 15:45 ` Darrick J. Wong
2020-08-06 19:35 ` Ira Weiny
2 siblings, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2020-08-05 15:45 UTC (permalink / raw)
To: Xiao Yang; +Cc: fstests, ira.weiny, guaneryu
On Wed, Aug 05, 2020 at 10:45:07AM +0800, Xiao Yang wrote:
> Change FS_XFLAG_DAX on an existing file and check if S_DAX on the
> file can take effect immediately by the following steps:
> 1) Stop all applications which are using the file.
> 2) Do drop_caches or umount & mount cycle.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Looks ok to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> Note: It is based on the following patch set:
> https://www.spinics.net/lists/fstests/msg14457.html
>
> V1->V2:
> Add a combination(without dax option) to do tests.
>
> tests/generic/608 | 121 ++++++++++++++++++++++++++++++++++++++++++
> tests/generic/608.out | 2 +
> tests/generic/group | 1 +
> 3 files changed, 124 insertions(+)
> create mode 100644 tests/generic/608
> create mode 100644 tests/generic/608.out
>
> diff --git a/tests/generic/608 b/tests/generic/608
> new file mode 100644
> index 00000000..705ae4b3
> --- /dev/null
> +++ b/tests/generic/608
> @@ -0,0 +1,121 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2020 Fujitsu. All Rights Reserved.
> +#
> +# FS QA Test 608
> +# Change FS_XFLAG_DAX on an existing file and check if S_DAX on
> +# the file can take effect immediately by the following steps:
> +# 1) Stop all applications which are using the file.
> +# 2) Do drop_caches or umount & mount cycle.
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +_supported_fs generic
> +_supported_os Linux
> +_require_scratch_dax_mountopt "dax=always"
> +_require_dax_iflag
> +_require_xfs_io_command "lsattr" "-v"
> +_require_xfs_io_command "statx" "-r"
> +
> +test_drop_caches()
> +{
> + local t_file=$SCRATCH_MNT/testfile
> +
> + rm -f $t_file
> + touch $t_file
> + _check_xflag $t_file 0
> + _check_s_dax $t_file 0
> +
> + exec 3< $t_file
> +
> + $XFS_IO_PROG -c 'chattr +x' $t_file
> + _check_xflag $t_file 1
> + _check_s_dax $t_file 0
> +
> + # One application is using test file and check if S_DAX on
> + # the file doesn't take effect immediately by drop_caches
> + echo 2 > /proc/sys/vm/drop_caches
> + _check_s_dax $t_file 0
> +
> + exec 3<&-
> +
> + # No application is using test file and check if S_DAX on
> + # the file takes effect immediately by drop_caches
> + echo 2 > /proc/sys/vm/drop_caches
> + _check_s_dax $t_file 1
> +}
> +
> +test_cycle_mount()
> +{
> + local option=$1
> + local t_dir=$SCRATCH_MNT/testdir
> + local t_file=$t_dir/testfile
> +
> + mkdir -p $t_dir
> + $XFS_IO_PROG -c 'chattr +x' $t_dir
> + rm -f $t_file
> + touch $t_file
> + _check_xflag $t_file 1
> + _check_s_dax $t_file 1
> +
> + exec 3< $t_file
> +
> + $XFS_IO_PROG -c 'chattr -x' $t_file
> + _check_xflag $t_file 0
> + _check_s_dax $t_file 1
> +
> + exec 3<&-
> +
> + # No application is using test file and check if S_DAX on
> + # the file takes effect immediately by umount & mount
> + _scratch_cycle_mount "$option"
> + _check_s_dax $t_file 0
> +}
> +
> +do_tests()
> +{
> + local mount_option=$1
> + local cycle_mount_option=$2
> +
> + _scratch_mount "$mount_option"
> +
> + test_drop_caches
> +
> + test_cycle_mount "$cycle_mount_option"
> +
> + _scratch_unmount
> +}
> +
> +_scratch_mkfs >> $seqres.full 2>&1
> +
> +# mount with dax option
> +do_tests "-o dax=inode" "dax=inode"
> +
> +# mount without dax option
> +export MOUNT_OPTIONS=""
> +do_tests
> +
> +# success, all done
> +echo "Silence is golden"
> +status=0
> +exit
> diff --git a/tests/generic/608.out b/tests/generic/608.out
> new file mode 100644
> index 00000000..1e534458
> --- /dev/null
> +++ b/tests/generic/608.out
> @@ -0,0 +1,2 @@
> +QA output created by 608
> +Silence is golden
> diff --git a/tests/generic/group b/tests/generic/group
> index 5bd289c3..aa969bcb 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -610,3 +610,4 @@
> 605 auto attr quick dax
> 606 auto attr quick dax
> 607 auto attr quick dax
> +608 auto attr quick dax
> --
> 2.21.0
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file
2020-08-05 2:45 [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file Xiao Yang
2020-08-05 2:55 ` Xiao Yang
2020-08-05 15:45 ` Darrick J. Wong
@ 2020-08-06 19:35 ` Ira Weiny
2020-08-07 1:44 ` Xiao Yang
2 siblings, 1 reply; 6+ messages in thread
From: Ira Weiny @ 2020-08-06 19:35 UTC (permalink / raw)
To: Xiao Yang; +Cc: fstests, darrick.wong, guaneryu
On Wed, Aug 05, 2020 at 10:45:07AM +0800, Xiao Yang wrote:
> Change FS_XFLAG_DAX on an existing file and check if S_DAX on the
> file can take effect immediately by the following steps:
> 1) Stop all applications which are using the file.
> 2) Do drop_caches or umount & mount cycle.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
>
> Note: It is based on the following patch set:
> https://www.spinics.net/lists/fstests/msg14457.html
>
> V1->V2:
> Add a combination(without dax option) to do tests.
>
> tests/generic/608 | 121 ++++++++++++++++++++++++++++++++++++++++++
> tests/generic/608.out | 2 +
> tests/generic/group | 1 +
> 3 files changed, 124 insertions(+)
> create mode 100644 tests/generic/608
> create mode 100644 tests/generic/608.out
>
> diff --git a/tests/generic/608 b/tests/generic/608
> new file mode 100644
> index 00000000..705ae4b3
> --- /dev/null
> +++ b/tests/generic/608
> @@ -0,0 +1,121 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2020 Fujitsu. All Rights Reserved.
> +#
> +# FS QA Test 608
> +# Change FS_XFLAG_DAX on an existing file and check if S_DAX on
> +# the file can take effect immediately by the following steps:
> +# 1) Stop all applications which are using the file.
> +# 2) Do drop_caches or umount & mount cycle.
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +_supported_fs generic
> +_supported_os Linux
> +_require_scratch_dax_mountopt "dax=always"
> +_require_dax_iflag
> +_require_xfs_io_command "lsattr" "-v"
> +_require_xfs_io_command "statx" "-r"
> +
> +test_drop_caches()
> +{
> + local t_file=$SCRATCH_MNT/testfile
> +
> + rm -f $t_file
> + touch $t_file
> + _check_xflag $t_file 0
> + _check_s_dax $t_file 0
> +
> + exec 3< $t_file
> +
> + $XFS_IO_PROG -c 'chattr +x' $t_file
> + _check_xflag $t_file 1
> + _check_s_dax $t_file 0
> +
> + # One application is using test file and check if S_DAX on
> + # the file doesn't take effect immediately by drop_caches
> + echo 2 > /proc/sys/vm/drop_caches
> + _check_s_dax $t_file 0
> +
> + exec 3<&-
> +
> + # No application is using test file and check if S_DAX on
> + # the file takes effect immediately by drop_caches
> + echo 2 > /proc/sys/vm/drop_caches
> + _check_s_dax $t_file 1
> +}
> +
> +test_cycle_mount()
> +{
> + local option=$1
> + local t_dir=$SCRATCH_MNT/testdir
> + local t_file=$t_dir/testfile
> +
> + mkdir -p $t_dir
> + $XFS_IO_PROG -c 'chattr +x' $t_dir
> + rm -f $t_file
> + touch $t_file
> + _check_xflag $t_file 1
> + _check_s_dax $t_file 1
> +
> + exec 3< $t_file
> +
> + $XFS_IO_PROG -c 'chattr -x' $t_file
> + _check_xflag $t_file 0
> + _check_s_dax $t_file 1
> +
> + exec 3<&-
> +
> + # No application is using test file and check if S_DAX on
> + # the file takes effect immediately by umount & mount
> + _scratch_cycle_mount "$option"
> + _check_s_dax $t_file 0
> +}
> +
> +do_tests()
> +{
> + local mount_option=$1
> + local cycle_mount_option=$2
> +
> + _scratch_mount "$mount_option"
> +
> + test_drop_caches
> +
> + test_cycle_mount "$cycle_mount_option"
> +
> + _scratch_unmount
> +}
> +
> +_scratch_mkfs >> $seqres.full 2>&1
> +
> +# mount with dax option
> +do_tests "-o dax=inode" "dax=inode"
> +
> +# mount without dax option
> +export MOUNT_OPTIONS=""
> +do_tests
> +
> +# success, all done
> +echo "Silence is golden"
> +status=0
> +exit
> diff --git a/tests/generic/608.out b/tests/generic/608.out
> new file mode 100644
> index 00000000..1e534458
> --- /dev/null
> +++ b/tests/generic/608.out
> @@ -0,0 +1,2 @@
> +QA output created by 608
> +Silence is golden
> diff --git a/tests/generic/group b/tests/generic/group
> index 5bd289c3..aa969bcb 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -610,3 +610,4 @@
> 605 auto attr quick dax
> 606 auto attr quick dax
> 607 auto attr quick dax
> +608 auto attr quick dax
> --
> 2.21.0
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file
2020-08-06 19:35 ` Ira Weiny
@ 2020-08-07 1:44 ` Xiao Yang
0 siblings, 0 replies; 6+ messages in thread
From: Xiao Yang @ 2020-08-07 1:44 UTC (permalink / raw)
To: Ira Weiny; +Cc: fstests, darrick.wong, guaneryu
On 2020/8/7 3:35, Ira Weiny wrote:
> On Wed, Aug 05, 2020 at 10:45:07AM +0800, Xiao Yang wrote:
>> Change FS_XFLAG_DAX on an existing file and check if S_DAX on the
>> file can take effect immediately by the following steps:
>> 1) Stop all applications which are using the file.
>> 2) Do drop_caches or umount& mount cycle.
>>
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
> Reviewed-by: Ira Weiny<ira.weiny@intel.com>
Hi Ira,
Thanks for your review. :-)
I have squashed it into my v9 patch set so I will add your Reviewed-by on:
[PATCH v9 8/8] generic: Verify how to change the S_DAX flag on an
existing file
Thanks,
Xiao Yang
>> ---
>>
>> Note: It is based on the following patch set:
>> https://www.spinics.net/lists/fstests/msg14457.html
>>
>> V1->V2:
>> Add a combination(without dax option) to do tests.
>>
>> tests/generic/608 | 121 ++++++++++++++++++++++++++++++++++++++++++
>> tests/generic/608.out | 2 +
>> tests/generic/group | 1 +
>> 3 files changed, 124 insertions(+)
>> create mode 100644 tests/generic/608
>> create mode 100644 tests/generic/608.out
>>
>> diff --git a/tests/generic/608 b/tests/generic/608
>> new file mode 100644
>> index 00000000..705ae4b3
>> --- /dev/null
>> +++ b/tests/generic/608
>> @@ -0,0 +1,121 @@
>> +#! /bin/bash
>> +# SPDX-License-Identifier: GPL-2.0
>> +# Copyright (c) 2020 Fujitsu. All Rights Reserved.
>> +#
>> +# FS QA Test 608
>> +# Change FS_XFLAG_DAX on an existing file and check if S_DAX on
>> +# the file can take effect immediately by the following steps:
>> +# 1) Stop all applications which are using the file.
>> +# 2) Do drop_caches or umount& mount cycle.
>> +
>> +seq=`basename $0`
>> +seqres=$RESULT_DIR/$seq
>> +echo "QA output created by $seq"
>> +
>> +here=`pwd`
>> +tmp=/tmp/$$
>> +status=1 # failure is the default!
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
>> +
>> +_cleanup()
>> +{
>> + cd /
>> + rm -f $tmp.*
>> +}
>> +
>> +# get standard environment, filters and checks
>> +. ./common/rc
>> +. ./common/filter
>> +
>> +# remove previous $seqres.full before test
>> +rm -f $seqres.full
>> +
>> +_supported_fs generic
>> +_supported_os Linux
>> +_require_scratch_dax_mountopt "dax=always"
>> +_require_dax_iflag
>> +_require_xfs_io_command "lsattr" "-v"
>> +_require_xfs_io_command "statx" "-r"
>> +
>> +test_drop_caches()
>> +{
>> + local t_file=$SCRATCH_MNT/testfile
>> +
>> + rm -f $t_file
>> + touch $t_file
>> + _check_xflag $t_file 0
>> + _check_s_dax $t_file 0
>> +
>> + exec 3< $t_file
>> +
>> + $XFS_IO_PROG -c 'chattr +x' $t_file
>> + _check_xflag $t_file 1
>> + _check_s_dax $t_file 0
>> +
>> + # One application is using test file and check if S_DAX on
>> + # the file doesn't take effect immediately by drop_caches
>> + echo 2> /proc/sys/vm/drop_caches
>> + _check_s_dax $t_file 0
>> +
>> + exec 3<&-
>> +
>> + # No application is using test file and check if S_DAX on
>> + # the file takes effect immediately by drop_caches
>> + echo 2> /proc/sys/vm/drop_caches
>> + _check_s_dax $t_file 1
>> +}
>> +
>> +test_cycle_mount()
>> +{
>> + local option=$1
>> + local t_dir=$SCRATCH_MNT/testdir
>> + local t_file=$t_dir/testfile
>> +
>> + mkdir -p $t_dir
>> + $XFS_IO_PROG -c 'chattr +x' $t_dir
>> + rm -f $t_file
>> + touch $t_file
>> + _check_xflag $t_file 1
>> + _check_s_dax $t_file 1
>> +
>> + exec 3< $t_file
>> +
>> + $XFS_IO_PROG -c 'chattr -x' $t_file
>> + _check_xflag $t_file 0
>> + _check_s_dax $t_file 1
>> +
>> + exec 3<&-
>> +
>> + # No application is using test file and check if S_DAX on
>> + # the file takes effect immediately by umount& mount
>> + _scratch_cycle_mount "$option"
>> + _check_s_dax $t_file 0
>> +}
>> +
>> +do_tests()
>> +{
>> + local mount_option=$1
>> + local cycle_mount_option=$2
>> +
>> + _scratch_mount "$mount_option"
>> +
>> + test_drop_caches
>> +
>> + test_cycle_mount "$cycle_mount_option"
>> +
>> + _scratch_unmount
>> +}
>> +
>> +_scratch_mkfs>> $seqres.full 2>&1
>> +
>> +# mount with dax option
>> +do_tests "-o dax=inode" "dax=inode"
>> +
>> +# mount without dax option
>> +export MOUNT_OPTIONS=""
>> +do_tests
>> +
>> +# success, all done
>> +echo "Silence is golden"
>> +status=0
>> +exit
>> diff --git a/tests/generic/608.out b/tests/generic/608.out
>> new file mode 100644
>> index 00000000..1e534458
>> --- /dev/null
>> +++ b/tests/generic/608.out
>> @@ -0,0 +1,2 @@
>> +QA output created by 608
>> +Silence is golden
>> diff --git a/tests/generic/group b/tests/generic/group
>> index 5bd289c3..aa969bcb 100644
>> --- a/tests/generic/group
>> +++ b/tests/generic/group
>> @@ -610,3 +610,4 @@
>> 605 auto attr quick dax
>> 606 auto attr quick dax
>> 607 auto attr quick dax
>> +608 auto attr quick dax
>> --
>> 2.21.0
>>
>>
>>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-07 1:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-05 2:45 [PATCH v2] generic: Verify how to change the S_DAX flag on an existing file Xiao Yang
2020-08-05 2:55 ` Xiao Yang
2020-08-05 4:36 ` Xiao Yang
2020-08-05 15:45 ` Darrick J. Wong
2020-08-06 19:35 ` Ira Weiny
2020-08-07 1:44 ` Xiao Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).