[PATCH] btrfs: Make 233 be part of subvol group

[PATCH] btrfs: Make 233 be part of subvol group

[Nikolay Borisov]

All but this test use 'subvol' to designate they relate to btrfs
subvolume functionality. For the sake of consistency make btrfs/233
also be part of 'subvol' rather than 'subvolume'. This brings no
functional changes.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 tests/btrfs/233 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/btrfs/233 b/tests/btrfs/233
index f3e3762c6951..6a4144433073 100755
--- a/tests/btrfs/233
+++ b/tests/btrfs/233
@@ -9,7 +9,7 @@
 # performed.
 #
 . ./common/preamble
-_begin_fstest auto quick subvolume
+_begin_fstest auto quick subvol
 
 # Override the default cleanup function.
 _cleanup()
-- 
2.17.1

Re: [PATCH] btrfs: Make 233 be part of subvol group

[Filipe Manana]

On Mon, Sep 13, 2021 at 2:35 PM Nikolay Borisov <nborisov@suse.com> wrote:
>
> All but this test use 'subvol' to designate they relate to btrfs
> subvolume functionality. For the sake of consistency make btrfs/233
> also be part of 'subvol' rather than 'subvolume'. This brings no
> functional changes.

There's already a pending patch for this, which also fixes the same
inconsistency for btrfs/245:

https://patchwork.kernel.org/project/fstests/patch/163062676513.1579659.12516104685003091290.stgit@magnolia/

Thanks.

>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>  tests/btrfs/233 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/233 b/tests/btrfs/233
> index f3e3762c6951..6a4144433073 100755
> --- a/tests/btrfs/233
> +++ b/tests/btrfs/233
> @@ -9,7 +9,7 @@
>  # performed.
>  #
>  . ./common/preamble
> -_begin_fstest auto quick subvolume
> +_begin_fstest auto quick subvol
>
>  # Override the default cleanup function.
>  _cleanup()
> --
> 2.17.1
>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”

Re: [PATCH] btrfs: Make 233 be part of subvol group

[Nikolay Borisov]

On 13.09.21 г. 16:40, Filipe Manana wrote:
> On Mon, Sep 13, 2021 at 2:35 PM Nikolay Borisov <nborisov@suse.com> wrote:
>>
>> All but this test use 'subvol' to designate they relate to btrfs
>> subvolume functionality. For the sake of consistency make btrfs/233
>> also be part of 'subvol' rather than 'subvolume'. This brings no
>> functional changes.
> 
> There's already a pending patch for this, which also fixes the same
> inconsistency for btrfs/245:
> 
> https://patchwork.kernel.org/project/fstests/patch/163062676513.1579659.12516104685003091290.stgit@magnolia/

Thanks, I have missed it. Since Darick's patch is fuller hopefully it
will be merged. So this one can be ignored.

> 
> Thanks.
> 
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>> ---
>>  tests/btrfs/233 | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/233 b/tests/btrfs/233
>> index f3e3762c6951..6a4144433073 100755
>> --- a/tests/btrfs/233
>> +++ b/tests/btrfs/233
>> @@ -9,7 +9,7 @@
>>  # performed.
>>  #
>>  . ./common/preamble
>> -_begin_fstest auto quick subvolume
>> +_begin_fstest auto quick subvol
>>
>>  # Override the default cleanup function.
>>  _cleanup()
>> --
>> 2.17.1
>>
> 
>