* [PATCH] fstests: btrfs/099: use the qgroupid for qgroup limit
@ 2021-11-22 20:50 Josef Bacik
2021-11-22 23:32 ` Qu Wenruo
0 siblings, 1 reply; 2+ messages in thread
From: Josef Bacik @ 2021-11-22 20:50 UTC (permalink / raw)
To: linux-btrfs, kernel-team, fstests
A change to btrfs-progs uncovered a problem with btrfs/099, we weren't
specifying the qgroupid with the subvol id. This technically worked
before but only by accident, and all other tests properly specify the
qgroupid for qgroup limit commands. Fix this test to specify the
qgroupid, which will work with older versions of btrfs-progs and newer
ones as well.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
tests/btrfs/099 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/btrfs/099 b/tests/btrfs/099
index 375cc2b9..f3a2002a 100755
--- a/tests/btrfs/099
+++ b/tests/btrfs/099
@@ -29,7 +29,7 @@ _scratch_mount
_require_fs_space $SCRATCH_MNT $(($FILESIZE * 2 / 1024))
_run_btrfs_util_prog quota enable $SCRATCH_MNT
-_run_btrfs_util_prog qgroup limit $FILESIZE 5 $SCRATCH_MNT
+_run_btrfs_util_prog qgroup limit $FILESIZE 0/5 $SCRATCH_MNT
# loop 5 times without sync to ensure reserved space leak will happen
for i in `seq 1 5`; do
--
2.26.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fstests: btrfs/099: use the qgroupid for qgroup limit
2021-11-22 20:50 [PATCH] fstests: btrfs/099: use the qgroupid for qgroup limit Josef Bacik
@ 2021-11-22 23:32 ` Qu Wenruo
0 siblings, 0 replies; 2+ messages in thread
From: Qu Wenruo @ 2021-11-22 23:32 UTC (permalink / raw)
To: Josef Bacik, linux-btrfs, kernel-team, fstests
On 2021/11/23 04:50, Josef Bacik wrote:
> A change to btrfs-progs uncovered a problem with btrfs/099, we weren't
> specifying the qgroupid with the subvol id. This technically worked
> before but only by accident, and all other tests properly specify the
> qgroupid for qgroup limit commands. Fix this test to specify the
> qgroupid, which will work with older versions of btrfs-progs and newer
> ones as well.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> tests/btrfs/099 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/099 b/tests/btrfs/099
> index 375cc2b9..f3a2002a 100755
> --- a/tests/btrfs/099
> +++ b/tests/btrfs/099
> @@ -29,7 +29,7 @@ _scratch_mount
> _require_fs_space $SCRATCH_MNT $(($FILESIZE * 2 / 1024))
>
> _run_btrfs_util_prog quota enable $SCRATCH_MNT
> -_run_btrfs_util_prog qgroup limit $FILESIZE 5 $SCRATCH_MNT
> +_run_btrfs_util_prog qgroup limit $FILESIZE 0/5 $SCRATCH_MNT
>
> # loop 5 times without sync to ensure reserved space leak will happen
> for i in `seq 1 5`; do
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-22 23:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 20:50 [PATCH] fstests: btrfs/099: use the qgroupid for qgroup limit Josef Bacik
2021-11-22 23:32 ` Qu Wenruo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).