* [PATCH] xfs/148: sort and filter attribute list output @ 2019-11-28 7:10 Yang Xu 2019-11-29 9:48 ` Yang Xu 2019-12-02 23:21 ` Darrick J. Wong 0 siblings, 2 replies; 6+ messages in thread From: Yang Xu @ 2019-11-28 7:10 UTC (permalink / raw) To: fstests; +Cc: Yang Xu, Darrick J. Wong When I backport fixed patches from Darrick tighten-verifiers tree, this case also fails. As below: ----------------------------------------------------------- "diff test/xfs/148.out result/xfs/148.out.bad 7,8d6 < Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile < Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile 9a8 > Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile 10a10,11 > Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > Attribute "selinux" has a 37 byte value for TEST_DIR/mount-148/testfile 49,50c50,51 < Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: < heh > attr_get: No data available > Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile" ------------------------------------------------------------- We should sort attribute list output and filter selinux. Also "a_are_bad/for_you" doesn't exist, we should correct it in output. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> --- tests/xfs/148 | 2 +- tests/xfs/148.out | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/xfs/148 b/tests/xfs/148 index 42cfdab0..06862faa 100755 --- a/tests/xfs/148 +++ b/tests/xfs/148 @@ -76,7 +76,7 @@ test_names+=("too_many" "are_bad/for_you") access_stuff() { ls $testdir - $ATTR_PROG -l $testfile + $ATTR_PROG -l $testfile | grep "a_" | sort for name in "${test_names[@]}"; do ls "$testdir/f_$name" diff --git a/tests/xfs/148.out b/tests/xfs/148.out index c301ecb6..ab3fc25b 100644 --- a/tests/xfs/148.out +++ b/tests/xfs/148.out @@ -4,10 +4,10 @@ f_another f_are_bad_for_you f_something f_too_many_beans +Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile +Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile -Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile -Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile TEST_DIR/mount-148/testdir/f_something Attribute "a_something" had a 3 byte value for TEST_DIR/mount-148/testfile: heh @@ -46,5 +46,5 @@ ls: cannot access 'TEST_DIR/mount-148/testdir/f_too_many': No such file or direc attr_get: No data available Could not get "a_too_many" for TEST_DIR/mount-148/testfile ls: cannot access 'TEST_DIR/mount-148/testdir/f_are_bad/for_you': No such file or directory -Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: -heh +attr_get: No data available +Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile -- 2.18.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs/148: sort and filter attribute list output 2019-11-28 7:10 [PATCH] xfs/148: sort and filter attribute list output Yang Xu @ 2019-11-29 9:48 ` Yang Xu 2019-12-02 23:21 ` Darrick J. Wong 1 sibling, 0 replies; 6+ messages in thread From: Yang Xu @ 2019-11-29 9:48 UTC (permalink / raw) To: fstests; +Cc: Darrick J. Wong on 2019/11/28 15:10, Yang Xu wrote: > When I backport fixed patches from Darrick tighten-verifiers tree, this case > also fails. As below: > ----------------------------------------------------------- > "diff test/xfs/148.out result/xfs/148.out.bad > 7,8d6 > < Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > < Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile > 9a8 >> Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile > 10a10,11 >> Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile >> Attribute "selinux" has a 37 byte value for TEST_DIR/mount-148/testfile > 49,50c50,51 > < Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: > < heh >> attr_get: No data available >> Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile" > ------------------------------------------------------------- > We should sort attribute list output and filter selinux. Also "a_are_bad/for_you" > doesn't exist, we should correct it in output. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> > --- > tests/xfs/148 | 2 +- > tests/xfs/148.out | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tests/xfs/148 b/tests/xfs/148 > index 42cfdab0..06862faa 100755 > --- a/tests/xfs/148 > +++ b/tests/xfs/148 > @@ -76,7 +76,7 @@ test_names+=("too_many" "are_bad/for_you") > > access_stuff() { > ls $testdir > - $ATTR_PROG -l $testfile > + $ATTR_PROG -l $testfile | grep "a_" | sort > > for name in "${test_names[@]}"; do > ls "$testdir/f_$name" on 3.10.0-1101.el7.x86_64 kernel, #ls -l TEST_DIR/mount-148/testfile #ls: cannot access TEST_DIR/mount-148/testfile: No such file or directory on 4.18.0-147.el8.x86_64 # ls -l TEST_DIR/mount-148/testfile #ls: cannot access 'TEST_DIR/mount-148/testfile': No such file or directory [root@localhost ltp]# I think we should filter "'" by sed and change 148.out. I will send v2 patch. > diff --git a/tests/xfs/148.out b/tests/xfs/148.out > index c301ecb6..ab3fc25b 100644 > --- a/tests/xfs/148.out > +++ b/tests/xfs/148.out > @@ -4,10 +4,10 @@ f_another > f_are_bad_for_you > f_something > f_too_many_beans > +Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile > +Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile > Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile > -Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile > -Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile > TEST_DIR/mount-148/testdir/f_something > Attribute "a_something" had a 3 byte value for TEST_DIR/mount-148/testfile: > heh > @@ -46,5 +46,5 @@ ls: cannot access 'TEST_DIR/mount-148/testdir/f_too_many': No such file or direc > attr_get: No data available > Could not get "a_too_many" for TEST_DIR/mount-148/testfile > ls: cannot access 'TEST_DIR/mount-148/testdir/f_are_bad/for_you': No such file or directory > -Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: > -heh > +attr_get: No data available > +Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs/148: sort and filter attribute list output 2019-11-28 7:10 [PATCH] xfs/148: sort and filter attribute list output Yang Xu 2019-11-29 9:48 ` Yang Xu @ 2019-12-02 23:21 ` Darrick J. Wong 2019-12-03 1:45 ` Yang Xu 1 sibling, 1 reply; 6+ messages in thread From: Darrick J. Wong @ 2019-12-02 23:21 UTC (permalink / raw) To: Yang Xu; +Cc: fstests On Thu, Nov 28, 2019 at 03:10:45PM +0800, Yang Xu wrote: > When I backport fixed patches from Darrick tighten-verifiers tree, this case NAK, why are you backporting out of my development tree and not upstream? What are you even backporting, seeing as the patches for this are in 5.5 and Linus hasn't even pulled that yet?? Also, why are you sending a patch to fstests that is (a) barely a week old, (b) doesn't actually list me as the author, and (c) I myself haven't even sent to fstests yet? > also fails. As below: > ----------------------------------------------------------- > "diff test/xfs/148.out result/xfs/148.out.bad > 7,8d6 > < Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > < Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile > 9a8 > > Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile > 10a10,11 > > Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > > Attribute "selinux" has a 37 byte value for TEST_DIR/mount-148/testfile > 49,50c50,51 > < Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: > < heh > > attr_get: No data available > > Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile" > ------------------------------------------------------------- > We should sort attribute list output and filter selinux. Also "a_are_bad/for_you" > doesn't exist, we should correct it in output. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> > --- > tests/xfs/148 | 2 +- > tests/xfs/148.out | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tests/xfs/148 b/tests/xfs/148 > index 42cfdab0..06862faa 100755 > --- a/tests/xfs/148 > +++ b/tests/xfs/148 > @@ -76,7 +76,7 @@ test_names+=("too_many" "are_bad/for_you") > > access_stuff() { > ls $testdir > - $ATTR_PROG -l $testfile > + $ATTR_PROG -l $testfile | grep "a_" | sort > > for name in "${test_names[@]}"; do > ls "$testdir/f_$name" > diff --git a/tests/xfs/148.out b/tests/xfs/148.out > index c301ecb6..ab3fc25b 100644 > --- a/tests/xfs/148.out > +++ b/tests/xfs/148.out > @@ -4,10 +4,10 @@ f_another > f_are_bad_for_you > f_something > f_too_many_beans > +Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile > +Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile > Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile > -Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile > -Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile > TEST_DIR/mount-148/testdir/f_something > Attribute "a_something" had a 3 byte value for TEST_DIR/mount-148/testfile: > heh > @@ -46,5 +46,5 @@ ls: cannot access 'TEST_DIR/mount-148/testdir/f_too_many': No such file or direc > attr_get: No data available > Could not get "a_too_many" for TEST_DIR/mount-148/testfile > ls: cannot access 'TEST_DIR/mount-148/testdir/f_are_bad/for_you': No such file or directory > -Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: > -heh > +attr_get: No data available > +Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile Huh? Why??? NAK NAK NAK --D > -- > 2.18.0 > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs/148: sort and filter attribute list output 2019-12-02 23:21 ` Darrick J. Wong @ 2019-12-03 1:45 ` Yang Xu 2019-12-03 2:38 ` Darrick J. Wong 2019-12-03 14:13 ` Qu Wenruo 0 siblings, 2 replies; 6+ messages in thread From: Yang Xu @ 2019-12-03 1:45 UTC (permalink / raw) To: Darrick J. Wong; +Cc: fstests on 2019/12/03 7:21, Darrick J. Wong wrote: > On Thu, Nov 28, 2019 at 03:10:45PM +0800, Yang Xu wrote: >> When I backport fixed patches from Darrick tighten-verifiers tree, this case > > NAK, why are you backporting out of my development tree and not upstream? My description is wrong. I use upstream kernel 5.4-rc8 and 4 attr patches as your tighten-verifiers tree do. > What are you even backporting, seeing as the patches for this are in 5.5 > and Linus hasn't even pulled that yet?? > I see Linus pulled the patches 3 hour ago, > Also, why are you sending a patch to fstests that is (a) barely a week > old, (b) doesn't actually list me as the author, and (c) I myself > haven't even sent to fstests yet? > I have listed you as author, I think I should add "Darrick J. Wong pointed selinux and sort problem" info. I find ls and "a_are_bad/for_you" problem. Also, in personal mail("Re: question about xfstests test case xfs/148(new)"), I said "I think you may busy with other important things. I will send this simple patch with correct "a_are_bad/for_you" info and add your signed-off-by tag."). Anyway, I am sorry, I should have received your reply before sending the patch. >> also fails. As below: >> ----------------------------------------------------------- >> "diff test/xfs/148.out result/xfs/148.out.bad >> 7,8d6 >> < Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile >> < Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile >> 9a8 >>> Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile >> 10a10,11 >>> Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile >>> Attribute "selinux" has a 37 byte value for TEST_DIR/mount-148/testfile >> 49,50c50,51 >> < Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: >> < heh >>> attr_get: No data available >>> Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile" >> ------------------------------------------------------------- >> We should sort attribute list output and filter selinux. Also "a_are_bad/for_you" >> doesn't exist, we should correct it in output. >> >> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> ... >> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> >> --- >> tests/xfs/148 | 2 +- >> tests/xfs/148.out | 8 ++++---- >> 2 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/tests/xfs/148 b/tests/xfs/148 >> index 42cfdab0..06862faa 100755 >> --- a/tests/xfs/148 >> +++ b/tests/xfs/148 >> @@ -76,7 +76,7 @@ test_names+=("too_many" "are_bad/for_you") >> >> access_stuff() { >> ls $testdir >> - $ATTR_PROG -l $testfile >> + $ATTR_PROG -l $testfile | grep "a_" | sort >> >> for name in "${test_names[@]}"; do >> ls "$testdir/f_$name" >> diff --git a/tests/xfs/148.out b/tests/xfs/148.out >> index c301ecb6..ab3fc25b 100644 >> --- a/tests/xfs/148.out >> +++ b/tests/xfs/148.out >> @@ -4,10 +4,10 @@ f_another >> f_are_bad_for_you >> f_something >> f_too_many_beans >> +Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile >> +Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile >> Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile >> Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile >> -Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile >> -Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile >> TEST_DIR/mount-148/testdir/f_something >> Attribute "a_something" had a 3 byte value for TEST_DIR/mount-148/testfile: >> heh >> @@ -46,5 +46,5 @@ ls: cannot access 'TEST_DIR/mount-148/testdir/f_too_many': No such file or direc >> attr_get: No data available >> Could not get "a_too_many" for TEST_DIR/mount-148/testfile >> ls: cannot access 'TEST_DIR/mount-148/testdir/f_are_bad/for_you': No such file or directory >> -Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: >> -heh >> +attr_get: No data available >> +Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile > > Huh? Why??? > > NAK NAK NAK a_are_bad_for_you has been corrupted by "/". So it should be nothing such as a_too_many_beans by beans. am I wrong?( I use 5.4-rc8 and 4 patches xfs: check attribute leaf block structure xfs: namecheck attribute names before listing them xfs: namecheck directory entry names before listing them xfs: replace -EIO with -EFSCORRUPTED for corrupt metadata ,this four patches from https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?h=tighten-verifiers )> > > --D > >> -- >> 2.18.0 >> >> >> > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs/148: sort and filter attribute list output 2019-12-03 1:45 ` Yang Xu @ 2019-12-03 2:38 ` Darrick J. Wong 2019-12-03 14:13 ` Qu Wenruo 1 sibling, 0 replies; 6+ messages in thread From: Darrick J. Wong @ 2019-12-03 2:38 UTC (permalink / raw) To: Yang Xu; +Cc: fstests On Tue, Dec 03, 2019 at 09:45:58AM +0800, Yang Xu wrote: > > > on 2019/12/03 7:21, Darrick J. Wong wrote: > > On Thu, Nov 28, 2019 at 03:10:45PM +0800, Yang Xu wrote: > > > When I backport fixed patches from Darrick tighten-verifiers tree, this case > > > > NAK, why are you backporting out of my development tree and not upstream? > My description is wrong. I use upstream kernel 5.4-rc8 and 4 attr patches as > your tighten-verifiers tree do. > > What are you even backporting, seeing as the patches for this are in 5.5 > > and Linus hasn't even pulled that yet?? > > I see Linus pulled the patches 3 hour ago, > > Also, why are you sending a patch to fstests that is (a) barely a week > > old, (b) doesn't actually list me as the author, and (c) I myself > > haven't even sent to fstests yet? > > > I have listed you as author, I think I should add "Darrick J. Wong > pointed selinux and sort problem" info. I find ls and "a_are_bad/for_you" > problem. > Also, in personal mail("Re: question about xfstests test case > xfs/148(new)"), I said "I think you may busy with other important things. I > will send this simple patch with correct "a_are_bad/for_you" info and add > your signed-off-by tag."). Anyway, I am sorry, I should have received your > reply before sending the patch. <nod> Apology accepted. I'll send this (and everything else queueing in my fstest tree) tomorrow like usual. > > > also fails. As below: > > > ----------------------------------------------------------- > > > "diff test/xfs/148.out result/xfs/148.out.bad > > > 7,8d6 > > > < Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > > > < Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile > > > 9a8 > > > > Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile > > > 10a10,11 > > > > Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > > > > Attribute "selinux" has a 37 byte value for TEST_DIR/mount-148/testfile > > > 49,50c50,51 > > > < Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: > > > < heh > > > > attr_get: No data available > > > > Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile" > > > ------------------------------------------------------------- > > > We should sort attribute list output and filter selinux. Also "a_are_bad/for_you" > > > doesn't exist, we should correct it in output. > > > > > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > ... > > > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> > > > --- > > > tests/xfs/148 | 2 +- > > > tests/xfs/148.out | 8 ++++---- > > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/tests/xfs/148 b/tests/xfs/148 > > > index 42cfdab0..06862faa 100755 > > > --- a/tests/xfs/148 > > > +++ b/tests/xfs/148 > > > @@ -76,7 +76,7 @@ test_names+=("too_many" "are_bad/for_you") > > > access_stuff() { > > > ls $testdir > > > - $ATTR_PROG -l $testfile > > > + $ATTR_PROG -l $testfile | grep "a_" | sort > > > for name in "${test_names[@]}"; do > > > ls "$testdir/f_$name" > > > diff --git a/tests/xfs/148.out b/tests/xfs/148.out > > > index c301ecb6..ab3fc25b 100644 > > > --- a/tests/xfs/148.out > > > +++ b/tests/xfs/148.out > > > @@ -4,10 +4,10 @@ f_another > > > f_are_bad_for_you > > > f_something > > > f_too_many_beans > > > +Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile > > > +Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile > > > Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > > > Attribute "a_too_many_beans" has a 3 byte value for TEST_DIR/mount-148/testfile > > > -Attribute "a_are_bad_for_you" has a 3 byte value for TEST_DIR/mount-148/testfile > > > -Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile > > > TEST_DIR/mount-148/testdir/f_something > > > Attribute "a_something" had a 3 byte value for TEST_DIR/mount-148/testfile: > > > heh > > > @@ -46,5 +46,5 @@ ls: cannot access 'TEST_DIR/mount-148/testdir/f_too_many': No such file or direc > > > attr_get: No data available > > > Could not get "a_too_many" for TEST_DIR/mount-148/testfile > > > ls: cannot access 'TEST_DIR/mount-148/testdir/f_are_bad/for_you': No such file or directory > > > -Attribute "a_are_bad/for_you" had a 3 byte value for TEST_DIR/mount-148/testfile: > > > -heh > > > +attr_get: No data available > > > +Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile > > > > Huh? Why??? > > > > NAK NAK NAK > a_are_bad_for_you has been corrupted by "/". So it should be nothing such as It's been changed, yes, but '/' is a valid character in an attribute name. Note that checksums are deliberately disabled on the loopdev filesystem so that the only checks we perform are the name checks themselves. > a_too_many_beans by beans. am I wrong?( I use 5.4-rc8 and 4 patches > xfs: check attribute leaf block structure > xfs: namecheck attribute names before listing them > xfs: namecheck directory entry names before listing them > xfs: replace -EIO with -EFSCORRUPTED for corrupt metadata > ,this four patches from https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?h=tighten-verifiers This is my development git repo ^^^^^^^^^^ which sometimes contains older versions of patches that do not end up going upstream. And this is the official xfs repo: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git/ Anyway, Linus pulled the 5.5 patches now, so you *really* ought to be backporting from that. --D > )> > > > > --D > > > > > -- > > > 2.18.0 > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs/148: sort and filter attribute list output 2019-12-03 1:45 ` Yang Xu 2019-12-03 2:38 ` Darrick J. Wong @ 2019-12-03 14:13 ` Qu Wenruo 1 sibling, 0 replies; 6+ messages in thread From: Qu Wenruo @ 2019-12-03 14:13 UTC (permalink / raw) To: Yang Xu, Darrick J. Wong; +Cc: fstests [-- Attachment #1.1: Type: text/plain, Size: 6194 bytes --] On 2019/12/3 上午9:45, Yang Xu wrote: > > > on 2019/12/03 7:21, Darrick J. Wong wrote: >> On Thu, Nov 28, 2019 at 03:10:45PM +0800, Yang Xu wrote: >>> When I backport fixed patches from Darrick tighten-verifiers tree, >>> this case >> >> NAK, why are you backporting out of my development tree and not upstream? > My description is wrong. I use upstream kernel 5.4-rc8 and 4 attr > patches as your tighten-verifiers tree do. >> What are you even backporting, seeing as the patches for this are in 5.5 >> and Linus hasn't even pulled that yet?? >> I see Linus pulled the patches 3 hour ago, >> Also, why are you sending a patch to fstests that is (a) barely a week >> old, (b) doesn't actually list me as the author, and (c) I myself >> haven't even sent to fstests yet? >> > I have listed you as author, Just a tip, as it looks like Fujitsu CN guys are suffering from M$ Exchange mail server. It looks like either you didn't apply the patch correctly or the mail server (M$ Exchange if not changed) is modifying the "From: " line. A properly formatted patch from another author looks like: From f82e569b33c3c1cfd4f8f405085ff8d439a0a915 Mon Sep 17 00:00:00 2001 From: David Sterba <dsterba@suse.com> Date: Fri, 25 Oct 2019 14:05:38 +0200 Subject: [PATCH] Btrfs progs v5.3.1 Signed-off-by: David Sterba <dsterba@suse.com> --- Note the "From: " line is the real author. A lot of mail servers don't accept "From: " other than the sender. And M$ Exchange is even worse, it will change "From: " tag to what M$ thinks is best. E.g Patch sent through O365 with "From: Qu Wenruo <wqu@suse.com>" will be modified to "From: Wenruo Qu <wqu@suse.com>", screwing up certain patch accounting. You'd better contact your IT department to solve the problem (if possible). Thanks, Qu > I think I should add "Darrick J. Wong > pointed selinux and sort problem" info. I find ls and > "a_are_bad/for_you" problem. > Also, in personal mail("Re: question about xfstests test case > xfs/148(new)"), I said "I think you may busy with other important > things. I will send this simple patch with correct "a_are_bad/for_you" > info and add your signed-off-by tag."). Anyway, I am sorry, I should > have received your reply before sending the patch. >>> also fails. As below: >>> ----------------------------------------------------------- >>> "diff test/xfs/148.out result/xfs/148.out.bad >>> 7,8d6 >>> < Attribute "a_something" has a 3 byte value for >>> TEST_DIR/mount-148/testfile >>> < Attribute "a_too_many_beans" has a 3 byte value for >>> TEST_DIR/mount-148/testfile >>> 9a8 >>>> Attribute "a_too_many_beans" has a 3 byte value for >>>> TEST_DIR/mount-148/testfile >>> 10a10,11 >>>> Attribute "a_something" has a 3 byte value for >>>> TEST_DIR/mount-148/testfile >>>> Attribute "selinux" has a 37 byte value for TEST_DIR/mount-148/testfile >>> 49,50c50,51 >>> < Attribute "a_are_bad/for_you" had a 3 byte value for >>> TEST_DIR/mount-148/testfile: >>> < heh >>>> attr_get: No data available >>>> Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile" >>> ------------------------------------------------------------- >>> We should sort attribute list output and filter selinux. Also >>> "a_are_bad/for_you" >>> doesn't exist, we should correct it in output. >>> >>> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > ... >>> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> >>> --- >>> tests/xfs/148 | 2 +- >>> tests/xfs/148.out | 8 ++++---- >>> 2 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/tests/xfs/148 b/tests/xfs/148 >>> index 42cfdab0..06862faa 100755 >>> --- a/tests/xfs/148 >>> +++ b/tests/xfs/148 >>> @@ -76,7 +76,7 @@ test_names+=("too_many" "are_bad/for_you") >>> access_stuff() { >>> ls $testdir >>> - $ATTR_PROG -l $testfile >>> + $ATTR_PROG -l $testfile | grep "a_" | sort >>> for name in "${test_names[@]}"; do >>> ls "$testdir/f_$name" >>> diff --git a/tests/xfs/148.out b/tests/xfs/148.out >>> index c301ecb6..ab3fc25b 100644 >>> --- a/tests/xfs/148.out >>> +++ b/tests/xfs/148.out >>> @@ -4,10 +4,10 @@ f_another >>> f_are_bad_for_you >>> f_something >>> f_too_many_beans >>> +Attribute "a_another" has a 3 byte value for >>> TEST_DIR/mount-148/testfile >>> +Attribute "a_are_bad_for_you" has a 3 byte value for >>> TEST_DIR/mount-148/testfile >>> Attribute "a_something" has a 3 byte value for >>> TEST_DIR/mount-148/testfile >>> Attribute "a_too_many_beans" has a 3 byte value for >>> TEST_DIR/mount-148/testfile >>> -Attribute "a_are_bad_for_you" has a 3 byte value for >>> TEST_DIR/mount-148/testfile >>> -Attribute "a_another" has a 3 byte value for >>> TEST_DIR/mount-148/testfile >>> TEST_DIR/mount-148/testdir/f_something >>> Attribute "a_something" had a 3 byte value for >>> TEST_DIR/mount-148/testfile: >>> heh >>> @@ -46,5 +46,5 @@ ls: cannot access >>> 'TEST_DIR/mount-148/testdir/f_too_many': No such file or direc >>> attr_get: No data available >>> Could not get "a_too_many" for TEST_DIR/mount-148/testfile >>> ls: cannot access 'TEST_DIR/mount-148/testdir/f_are_bad/for_you': >>> No such file or directory >>> -Attribute "a_are_bad/for_you" had a 3 byte value for >>> TEST_DIR/mount-148/testfile: >>> -heh >>> +attr_get: No data available >>> +Could not get "a_are_bad/for_you" for TEST_DIR/mount-148/testfile >> >> Huh? Why??? >> >> NAK NAK NAK > a_are_bad_for_you has been corrupted by "/". So it should be nothing > such as a_too_many_beans by beans. am I wrong?( I use 5.4-rc8 and 4 > patches > xfs: check attribute leaf block structure > xfs: namecheck attribute names before listing them > xfs: namecheck directory entry names before listing them > xfs: replace -EIO with -EFSCORRUPTED for corrupt metadata > ,this four patches from > https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?h=tighten-verifiers > > )> >> >> --D >> >>> -- >>> 2.18.0 >>> >>> >>> >> >> > > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-03 14:14 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-28 7:10 [PATCH] xfs/148: sort and filter attribute list output Yang Xu 2019-11-29 9:48 ` Yang Xu 2019-12-02 23:21 ` Darrick J. Wong 2019-12-03 1:45 ` Yang Xu 2019-12-03 2:38 ` Darrick J. Wong 2019-12-03 14:13 ` Qu Wenruo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).