[PATCH] fstests: add missing remove of the $seqres.full file for some tests

[PATCH] fstests: add missing remove of the $seqres.full file for some tests

[fdmanana]

From: Filipe Manana <fdmanana@suse.com>

Some test cases are missing the 'rm -f $seqres.full' line but are appending
to that file, so everytime they run that file gets bigger and bigger (some
of them are using about a dozen megabytes on one of my test boxes).

So just add the 'rm -f $seqres.full' line to them, together with the comment
that the 'new' script generates for new test cases.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 tests/btrfs/033  | 3 +++
 tests/btrfs/036  | 3 +++
 tests/btrfs/114  | 3 +++
 tests/btrfs/115  | 3 +++
 tests/btrfs/205  | 3 +++
 tests/shared/298 | 3 +++
 6 files changed, 18 insertions(+)

diff --git a/tests/btrfs/033 b/tests/btrfs/033
index 0b9fbe27..d1f8a4db 100755
--- a/tests/btrfs/033
+++ b/tests/btrfs/033
@@ -25,6 +25,9 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
 . ./common/rc
 . ./common/filter
 
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
 # real QA test starts here
 _supported_fs btrfs
 _require_scratch
diff --git a/tests/btrfs/036 b/tests/btrfs/036
index cd7a81e5..36b652fd 100755
--- a/tests/btrfs/036
+++ b/tests/btrfs/036
@@ -49,6 +49,9 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
 . ./common/rc
 . ./common/filter
 
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
 # real QA test starts here
 _supported_fs btrfs
 _require_scratch
diff --git a/tests/btrfs/114 b/tests/btrfs/114
index a4b8bafa..2d9546a1 100755
--- a/tests/btrfs/114
+++ b/tests/btrfs/114
@@ -26,6 +26,9 @@ _cleanup()
 . ./common/rc
 . ./common/filter
 
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
 # real QA test starts here
 _supported_fs btrfs
 _require_scratch
diff --git a/tests/btrfs/115 b/tests/btrfs/115
index eac0e33d..02ae4e1d 100755
--- a/tests/btrfs/115
+++ b/tests/btrfs/115
@@ -26,6 +26,9 @@ _cleanup()
 . ./common/rc
 . ./common/filter
 
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
 # real QA test starts here
 _supported_fs btrfs
 _require_scratch
diff --git a/tests/btrfs/205 b/tests/btrfs/205
index b335ac3d..b53e0e52 100755
--- a/tests/btrfs/205
+++ b/tests/btrfs/205
@@ -31,6 +31,9 @@ _cleanup()
 . ./common/filter
 . ./common/reflink
 
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
 # real QA test starts here
 _supported_fs btrfs
 _require_scratch_reflink
diff --git a/tests/shared/298 b/tests/shared/298
index 416a89d3..5cb30fc9 100755
--- a/tests/shared/298
+++ b/tests/shared/298
@@ -15,6 +15,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 . ./common/rc
 
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
 _supported_fs ext4 xfs btrfs
 _require_test
 _require_loop
-- 
2.28.0

Re: [PATCH] fstests: add missing remove of the $seqres.full file for some tests

[Josef Bacik]

On 10/29/20 8:09 AM, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Some test cases are missing the 'rm -f $seqres.full' line but are appending
> to that file, so everytime they run that file gets bigger and bigger (some
> of them are using about a dozen megabytes on one of my test boxes).
> 
> So just add the 'rm -f $seqres.full' line to them, together with the comment
> that the 'new' script generates for new test cases.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef