[PATCH] btrfs/205: Ignore output of chattr command

[PATCH] btrfs/205: Ignore output of chattr command

[Nikolay Borisov]

With newer kernels, containing upstream commit f37c563bab42 ("btrfs:
add missing check for nocow and compression inode flags") chattr would
produce an error :

  /usr/bin/chattr: Invalid argument while setting flags on /media/scratch/foo1

That's due to the aforementioned commit making the checks stricter. This
is not critical for the purpose of the test so it can be safely
ignored.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 tests/btrfs/205 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/btrfs/205 b/tests/btrfs/205
index 66355678f7d2..ab4261488ebe 100755
--- a/tests/btrfs/205
+++ b/tests/btrfs/205
@@ -48,7 +48,7 @@ run_tests()
     # extent. It has a file size of 128K.
     echo "Creating file foo1"
     touch $SCRATCH_MNT/foo1
-    $CHATTR_PROG +c $SCRATCH_MNT/foo1
+    $CHATTR_PROG +c $SCRATCH_MNT/foo1 > /dev/null 2>&1
     $XFS_IO_PROG -c "pwrite -S 0xab 0 4K" \
 		 -c "fsync" \
 		 -c "pwrite -S 0xab 4K 124K" \
-- 
2.17.1

Re: [PATCH] btrfs/205: Ignore output of chattr command

[Filipe Manana]

On Thu, Aug 20, 2020 at 10:32 AM Nikolay Borisov <nborisov@suse.com> wrote:
>
> With newer kernels, containing upstream commit f37c563bab42 ("btrfs:
> add missing check for nocow and compression inode flags") chattr would
> produce an error :
>
>   /usr/bin/chattr: Invalid argument while setting flags on /media/scratch/foo1
>
> That's due to the aforementioned commit making the checks stricter. This
> is not critical for the purpose of the test so it can be safely
> ignored.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Looks good, thanks.

> ---
>  tests/btrfs/205 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/205 b/tests/btrfs/205
> index 66355678f7d2..ab4261488ebe 100755
> --- a/tests/btrfs/205
> +++ b/tests/btrfs/205
> @@ -48,7 +48,7 @@ run_tests()
>      # extent. It has a file size of 128K.
>      echo "Creating file foo1"
>      touch $SCRATCH_MNT/foo1
> -    $CHATTR_PROG +c $SCRATCH_MNT/foo1
> +    $CHATTR_PROG +c $SCRATCH_MNT/foo1 > /dev/null 2>&1
>      $XFS_IO_PROG -c "pwrite -S 0xab 0 4K" \
>                  -c "fsync" \
>                  -c "pwrite -S 0xab 4K 124K" \
> --
> 2.17.1
>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”