* [PATCHSET 0/1] fstests: tag recovery loop tests @ 2021-07-28 0:10 Darrick J. Wong 2021-07-28 0:10 ` [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop Darrick J. Wong 0 siblings, 1 reply; 7+ messages in thread From: Darrick J. Wong @ 2021-07-28 0:10 UTC (permalink / raw) To: djwong, guaneryu; +Cc: linux-xfs, fstests, guan Hi all, The single test in this series tags all the tests that perform looping filesystem crash recovery tests with the same 'recoveryloop' tag so that maintainers can run them over and over again. If you're going to start using this mess, you probably ought to just pull from my git trees, which are linked below. This is an extraordinary way to destroy everything. Enjoy! Comments and questions are, as always, welcome. --D fstests git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=recovery-loop-tagging --- tests/btrfs/190 | 2 +- tests/generic/019 | 2 +- tests/generic/388 | 2 +- tests/generic/455 | 2 +- tests/generic/457 | 2 +- tests/generic/475 | 2 +- tests/generic/482 | 2 +- tests/generic/725 | 2 +- tests/xfs/057 | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop 2021-07-28 0:10 [PATCHSET 0/1] fstests: tag recovery loop tests Darrick J. Wong @ 2021-07-28 0:10 ` Darrick J. Wong 2021-07-28 1:18 ` Dave Chinner ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Darrick J. Wong @ 2021-07-28 0:10 UTC (permalink / raw) To: djwong, guaneryu; +Cc: linux-xfs, fstests, guan From: Darrick J. Wong <djwong@kernel.org> Given all the recent problems that we've been finding with log recovery, I think it would be useful to create a 'recoveryloop' group so that developers have a convenient way to run every single test that rolls around in a fs shutdown loop looking for subtle errors in recovery. Signed-off-by: Darrick J. Wong <djwong@kernel.org> --- tests/btrfs/190 | 2 +- tests/generic/019 | 2 +- tests/generic/388 | 2 +- tests/generic/455 | 2 +- tests/generic/457 | 2 +- tests/generic/475 | 2 +- tests/generic/482 | 2 +- tests/generic/725 | 2 +- tests/xfs/057 | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/btrfs/190 b/tests/btrfs/190 index 3aa718e2..974438c1 100755 --- a/tests/btrfs/190 +++ b/tests/btrfs/190 @@ -8,7 +8,7 @@ # balance needs to be resumed on mount. # . ./common/preamble -_begin_fstest auto quick replay balance qgroup +_begin_fstest auto quick replay balance qgroup recoveryloop # Import common functions. . ./common/filter diff --git a/tests/generic/019 b/tests/generic/019 index b8d025d6..db56dac1 100755 --- a/tests/generic/019 +++ b/tests/generic/019 @@ -8,7 +8,7 @@ # check filesystem consistency at the end. # . ./common/preamble -_begin_fstest aio dangerous enospc rw stress +_begin_fstest aio dangerous enospc rw stress recoveryloop fio_config=$tmp.fio diff --git a/tests/generic/388 b/tests/generic/388 index e41712af..9cd737e8 100755 --- a/tests/generic/388 +++ b/tests/generic/388 @@ -15,7 +15,7 @@ # spurious corruption reports and/or mount failures. # . ./common/preamble -_begin_fstest shutdown auto log metadata +_begin_fstest shutdown auto log metadata recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/455 b/tests/generic/455 index 62788798..13d326e7 100755 --- a/tests/generic/455 +++ b/tests/generic/455 @@ -7,7 +7,7 @@ # Run fsx with log writes to verify power fail safeness. # . ./common/preamble -_begin_fstest auto log replay +_begin_fstest auto log replay recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/457 b/tests/generic/457 index d9e38268..f4fdd81d 100755 --- a/tests/generic/457 +++ b/tests/generic/457 @@ -7,7 +7,7 @@ # Run fsx with log writes on cloned files to verify power fail safeness. # . ./common/preamble -_begin_fstest auto log replay clone +_begin_fstest auto log replay clone recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/475 b/tests/generic/475 index 62894491..c426402e 100755 --- a/tests/generic/475 +++ b/tests/generic/475 @@ -12,7 +12,7 @@ # testing efforts. # . ./common/preamble -_begin_fstest shutdown auto log metadata eio +_begin_fstest shutdown auto log metadata eio recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/482 b/tests/generic/482 index f26e6fc4..0fadf795 100755 --- a/tests/generic/482 +++ b/tests/generic/482 @@ -9,7 +9,7 @@ # Will do log replay and check the filesystem. # . ./common/preamble -_begin_fstest auto metadata replay thin +_begin_fstest auto metadata replay thin recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/725 b/tests/generic/725 index f43bcb37..8bd724e3 100755 --- a/tests/generic/725 +++ b/tests/generic/725 @@ -12,7 +12,7 @@ # in writeback on the host that cause VM guests to fail to recover. # . ./common/preamble -_begin_fstest shutdown auto log metadata eio +_begin_fstest shutdown auto log metadata eio recoveryloop _cleanup() { diff --git a/tests/xfs/057 b/tests/xfs/057 index d4cfa8dc..9fb3f406 100755 --- a/tests/xfs/057 +++ b/tests/xfs/057 @@ -21,7 +21,7 @@ # Note that this test requires a DEBUG mode kernel. # . ./common/preamble -_begin_fstest auto log +_begin_fstest auto log recoveryloop # Override the default cleanup function. _cleanup() ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop 2021-07-28 0:10 ` [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop Darrick J. Wong @ 2021-07-28 1:18 ` Dave Chinner 2021-07-28 9:40 ` Filipe Manana 2021-07-29 16:53 ` [PATCH v2 " Darrick J. Wong 2 siblings, 0 replies; 7+ messages in thread From: Dave Chinner @ 2021-07-28 1:18 UTC (permalink / raw) To: Darrick J. Wong; +Cc: guaneryu, linux-xfs, fstests, guan On Tue, Jul 27, 2021 at 05:10:42PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Given all the recent problems that we've been finding with log recovery, > I think it would be useful to create a 'recoveryloop' group so that > developers have a convenient way to run every single test that rolls > around in a fs shutdown loop looking for subtle errors in recovery. > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> Yup, that would have been useful over the past couple of weeks for me. Reviewed-by: Dave Chinner <dchinner@redhat.com> -- Dave Chinner david@fromorbit.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop 2021-07-28 0:10 ` [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop Darrick J. Wong 2021-07-28 1:18 ` Dave Chinner @ 2021-07-28 9:40 ` Filipe Manana 2021-07-28 16:45 ` Darrick J. Wong 2021-07-29 16:53 ` [PATCH v2 " Darrick J. Wong 2 siblings, 1 reply; 7+ messages in thread From: Filipe Manana @ 2021-07-28 9:40 UTC (permalink / raw) To: Darrick J. Wong; +Cc: Eryu Guan, xfs, fstests, Eryu Guan On Wed, Jul 28, 2021 at 1:10 AM Darrick J. Wong <djwong@kernel.org> wrote: > > From: Darrick J. Wong <djwong@kernel.org> > > Given all the recent problems that we've been finding with log recovery, > I think it would be useful to create a 'recoveryloop' group so that > developers have a convenient way to run every single test that rolls > around in a fs shutdown loop looking for subtle errors in recovery. > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > tests/btrfs/190 | 2 +- > tests/generic/019 | 2 +- > tests/generic/388 | 2 +- > tests/generic/455 | 2 +- > tests/generic/457 | 2 +- > tests/generic/475 | 2 +- > tests/generic/482 | 2 +- > tests/generic/725 | 2 +- > tests/xfs/057 | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > > > diff --git a/tests/btrfs/190 b/tests/btrfs/190 > index 3aa718e2..974438c1 100755 > --- a/tests/btrfs/190 > +++ b/tests/btrfs/190 > @@ -8,7 +8,7 @@ > # balance needs to be resumed on mount. > # > . ./common/preamble > -_begin_fstest auto quick replay balance qgroup > +_begin_fstest auto quick replay balance qgroup recoveryloop For btrfs, there are more tests like this: btrfs/172, btrfs/192 and btrfs/206. > > # Import common functions. > . ./common/filter > diff --git a/tests/generic/019 b/tests/generic/019 > index b8d025d6..db56dac1 100755 > --- a/tests/generic/019 > +++ b/tests/generic/019 > @@ -8,7 +8,7 @@ > # check filesystem consistency at the end. > # > . ./common/preamble > -_begin_fstest aio dangerous enospc rw stress > +_begin_fstest aio dangerous enospc rw stress recoveryloop > > fio_config=$tmp.fio > > diff --git a/tests/generic/388 b/tests/generic/388 > index e41712af..9cd737e8 100755 > --- a/tests/generic/388 > +++ b/tests/generic/388 > @@ -15,7 +15,7 @@ > # spurious corruption reports and/or mount failures. > # > . ./common/preamble > -_begin_fstest shutdown auto log metadata > +_begin_fstest shutdown auto log metadata recoveryloop > > # Override the default cleanup function. > _cleanup() > diff --git a/tests/generic/455 b/tests/generic/455 > index 62788798..13d326e7 100755 > --- a/tests/generic/455 > +++ b/tests/generic/455 > @@ -7,7 +7,7 @@ > # Run fsx with log writes to verify power fail safeness. > # > . ./common/preamble > -_begin_fstest auto log replay > +_begin_fstest auto log replay recoveryloop > > # Override the default cleanup function. > _cleanup() > diff --git a/tests/generic/457 b/tests/generic/457 > index d9e38268..f4fdd81d 100755 > --- a/tests/generic/457 > +++ b/tests/generic/457 > @@ -7,7 +7,7 @@ > # Run fsx with log writes on cloned files to verify power fail safeness. > # > . ./common/preamble > -_begin_fstest auto log replay clone > +_begin_fstest auto log replay clone recoveryloop > > # Override the default cleanup function. > _cleanup() > diff --git a/tests/generic/475 b/tests/generic/475 > index 62894491..c426402e 100755 > --- a/tests/generic/475 > +++ b/tests/generic/475 > @@ -12,7 +12,7 @@ > # testing efforts. > # > . ./common/preamble > -_begin_fstest shutdown auto log metadata eio > +_begin_fstest shutdown auto log metadata eio recoveryloop > > # Override the default cleanup function. > _cleanup() > diff --git a/tests/generic/482 b/tests/generic/482 > index f26e6fc4..0fadf795 100755 > --- a/tests/generic/482 > +++ b/tests/generic/482 > @@ -9,7 +9,7 @@ > # Will do log replay and check the filesystem. > # > . ./common/preamble > -_begin_fstest auto metadata replay thin > +_begin_fstest auto metadata replay thin recoveryloop > > # Override the default cleanup function. > _cleanup() > diff --git a/tests/generic/725 b/tests/generic/725 > index f43bcb37..8bd724e3 100755 > --- a/tests/generic/725 > +++ b/tests/generic/725 > @@ -12,7 +12,7 @@ > # in writeback on the host that cause VM guests to fail to recover. > # > . ./common/preamble > -_begin_fstest shutdown auto log metadata eio > +_begin_fstest shutdown auto log metadata eio recoveryloop > > _cleanup() > { > diff --git a/tests/xfs/057 b/tests/xfs/057 > index d4cfa8dc..9fb3f406 100755 > --- a/tests/xfs/057 > +++ b/tests/xfs/057 > @@ -21,7 +21,7 @@ > # Note that this test requires a DEBUG mode kernel. > # > . ./common/preamble > -_begin_fstest auto log > +_begin_fstest auto log recoveryloop > > # Override the default cleanup function. > _cleanup() > -- Filipe David Manana, “Whether you think you can, or you think you can't — you're right.” ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop 2021-07-28 9:40 ` Filipe Manana @ 2021-07-28 16:45 ` Darrick J. Wong 2021-07-29 10:18 ` Filipe Manana 0 siblings, 1 reply; 7+ messages in thread From: Darrick J. Wong @ 2021-07-28 16:45 UTC (permalink / raw) To: Filipe Manana; +Cc: Eryu Guan, xfs, fstests, Eryu Guan On Wed, Jul 28, 2021 at 10:40:29AM +0100, Filipe Manana wrote: > On Wed, Jul 28, 2021 at 1:10 AM Darrick J. Wong <djwong@kernel.org> wrote: > > > > From: Darrick J. Wong <djwong@kernel.org> > > > > Given all the recent problems that we've been finding with log recovery, > > I think it would be useful to create a 'recoveryloop' group so that > > developers have a convenient way to run every single test that rolls > > around in a fs shutdown loop looking for subtle errors in recovery. > > > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > > --- > > tests/btrfs/190 | 2 +- > > tests/generic/019 | 2 +- > > tests/generic/388 | 2 +- > > tests/generic/455 | 2 +- > > tests/generic/457 | 2 +- > > tests/generic/475 | 2 +- > > tests/generic/482 | 2 +- > > tests/generic/725 | 2 +- > > tests/xfs/057 | 2 +- > > 9 files changed, 9 insertions(+), 9 deletions(-) > > > > > > diff --git a/tests/btrfs/190 b/tests/btrfs/190 > > index 3aa718e2..974438c1 100755 > > --- a/tests/btrfs/190 > > +++ b/tests/btrfs/190 > > @@ -8,7 +8,7 @@ > > # balance needs to be resumed on mount. > > # > > . ./common/preamble > > -_begin_fstest auto quick replay balance qgroup > > +_begin_fstest auto quick replay balance qgroup recoveryloop > > For btrfs, there are more tests like this: btrfs/172, btrfs/192 and btrfs/206. I saw those when I was collecting tests for the new group. I couldn't tell if they were looping recovery tests, though if you'd like me to add them to the group I certain will? --D > > > > # Import common functions. > > . ./common/filter > > diff --git a/tests/generic/019 b/tests/generic/019 > > index b8d025d6..db56dac1 100755 > > --- a/tests/generic/019 > > +++ b/tests/generic/019 > > @@ -8,7 +8,7 @@ > > # check filesystem consistency at the end. > > # > > . ./common/preamble > > -_begin_fstest aio dangerous enospc rw stress > > +_begin_fstest aio dangerous enospc rw stress recoveryloop > > > > fio_config=$tmp.fio > > > > diff --git a/tests/generic/388 b/tests/generic/388 > > index e41712af..9cd737e8 100755 > > --- a/tests/generic/388 > > +++ b/tests/generic/388 > > @@ -15,7 +15,7 @@ > > # spurious corruption reports and/or mount failures. > > # > > . ./common/preamble > > -_begin_fstest shutdown auto log metadata > > +_begin_fstest shutdown auto log metadata recoveryloop > > > > # Override the default cleanup function. > > _cleanup() > > diff --git a/tests/generic/455 b/tests/generic/455 > > index 62788798..13d326e7 100755 > > --- a/tests/generic/455 > > +++ b/tests/generic/455 > > @@ -7,7 +7,7 @@ > > # Run fsx with log writes to verify power fail safeness. > > # > > . ./common/preamble > > -_begin_fstest auto log replay > > +_begin_fstest auto log replay recoveryloop > > > > # Override the default cleanup function. > > _cleanup() > > diff --git a/tests/generic/457 b/tests/generic/457 > > index d9e38268..f4fdd81d 100755 > > --- a/tests/generic/457 > > +++ b/tests/generic/457 > > @@ -7,7 +7,7 @@ > > # Run fsx with log writes on cloned files to verify power fail safeness. > > # > > . ./common/preamble > > -_begin_fstest auto log replay clone > > +_begin_fstest auto log replay clone recoveryloop > > > > # Override the default cleanup function. > > _cleanup() > > diff --git a/tests/generic/475 b/tests/generic/475 > > index 62894491..c426402e 100755 > > --- a/tests/generic/475 > > +++ b/tests/generic/475 > > @@ -12,7 +12,7 @@ > > # testing efforts. > > # > > . ./common/preamble > > -_begin_fstest shutdown auto log metadata eio > > +_begin_fstest shutdown auto log metadata eio recoveryloop > > > > # Override the default cleanup function. > > _cleanup() > > diff --git a/tests/generic/482 b/tests/generic/482 > > index f26e6fc4..0fadf795 100755 > > --- a/tests/generic/482 > > +++ b/tests/generic/482 > > @@ -9,7 +9,7 @@ > > # Will do log replay and check the filesystem. > > # > > . ./common/preamble > > -_begin_fstest auto metadata replay thin > > +_begin_fstest auto metadata replay thin recoveryloop > > > > # Override the default cleanup function. > > _cleanup() > > diff --git a/tests/generic/725 b/tests/generic/725 > > index f43bcb37..8bd724e3 100755 > > --- a/tests/generic/725 > > +++ b/tests/generic/725 > > @@ -12,7 +12,7 @@ > > # in writeback on the host that cause VM guests to fail to recover. > > # > > . ./common/preamble > > -_begin_fstest shutdown auto log metadata eio > > +_begin_fstest shutdown auto log metadata eio recoveryloop > > > > _cleanup() > > { > > diff --git a/tests/xfs/057 b/tests/xfs/057 > > index d4cfa8dc..9fb3f406 100755 > > --- a/tests/xfs/057 > > +++ b/tests/xfs/057 > > @@ -21,7 +21,7 @@ > > # Note that this test requires a DEBUG mode kernel. > > # > > . ./common/preamble > > -_begin_fstest auto log > > +_begin_fstest auto log recoveryloop > > > > # Override the default cleanup function. > > _cleanup() > > > > > -- > Filipe David Manana, > > “Whether you think you can, or you think you can't — you're right.” ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop 2021-07-28 16:45 ` Darrick J. Wong @ 2021-07-29 10:18 ` Filipe Manana 0 siblings, 0 replies; 7+ messages in thread From: Filipe Manana @ 2021-07-29 10:18 UTC (permalink / raw) To: Darrick J. Wong; +Cc: Eryu Guan, xfs, fstests, Eryu Guan On Wed, Jul 28, 2021 at 5:45 PM Darrick J. Wong <djwong@kernel.org> wrote: > > On Wed, Jul 28, 2021 at 10:40:29AM +0100, Filipe Manana wrote: > > On Wed, Jul 28, 2021 at 1:10 AM Darrick J. Wong <djwong@kernel.org> wrote: > > > > > > From: Darrick J. Wong <djwong@kernel.org> > > > > > > Given all the recent problems that we've been finding with log recovery, > > > I think it would be useful to create a 'recoveryloop' group so that > > > developers have a convenient way to run every single test that rolls > > > around in a fs shutdown loop looking for subtle errors in recovery. > > > > > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > > > --- > > > tests/btrfs/190 | 2 +- > > > tests/generic/019 | 2 +- > > > tests/generic/388 | 2 +- > > > tests/generic/455 | 2 +- > > > tests/generic/457 | 2 +- > > > tests/generic/475 | 2 +- > > > tests/generic/482 | 2 +- > > > tests/generic/725 | 2 +- > > > tests/xfs/057 | 2 +- > > > 9 files changed, 9 insertions(+), 9 deletions(-) > > > > > > > > > diff --git a/tests/btrfs/190 b/tests/btrfs/190 > > > index 3aa718e2..974438c1 100755 > > > --- a/tests/btrfs/190 > > > +++ b/tests/btrfs/190 > > > @@ -8,7 +8,7 @@ > > > # balance needs to be resumed on mount. > > > # > > > . ./common/preamble > > > -_begin_fstest auto quick replay balance qgroup > > > +_begin_fstest auto quick replay balance qgroup recoveryloop > > > > For btrfs, there are more tests like this: btrfs/172, btrfs/192 and btrfs/206. > > I saw those when I was collecting tests for the new group. I couldn't > tell if they were looping recovery tests, though if you'd like me to add > them to the group I certain will? If you have to send another version, please include them. Otherwise I won't bother you as probably Eryu can do it at commit time. thanks > > --D > > > > > > > # Import common functions. > > > . ./common/filter > > > diff --git a/tests/generic/019 b/tests/generic/019 > > > index b8d025d6..db56dac1 100755 > > > --- a/tests/generic/019 > > > +++ b/tests/generic/019 > > > @@ -8,7 +8,7 @@ > > > # check filesystem consistency at the end. > > > # > > > . ./common/preamble > > > -_begin_fstest aio dangerous enospc rw stress > > > +_begin_fstest aio dangerous enospc rw stress recoveryloop > > > > > > fio_config=$tmp.fio > > > > > > diff --git a/tests/generic/388 b/tests/generic/388 > > > index e41712af..9cd737e8 100755 > > > --- a/tests/generic/388 > > > +++ b/tests/generic/388 > > > @@ -15,7 +15,7 @@ > > > # spurious corruption reports and/or mount failures. > > > # > > > . ./common/preamble > > > -_begin_fstest shutdown auto log metadata > > > +_begin_fstest shutdown auto log metadata recoveryloop > > > > > > # Override the default cleanup function. > > > _cleanup() > > > diff --git a/tests/generic/455 b/tests/generic/455 > > > index 62788798..13d326e7 100755 > > > --- a/tests/generic/455 > > > +++ b/tests/generic/455 > > > @@ -7,7 +7,7 @@ > > > # Run fsx with log writes to verify power fail safeness. > > > # > > > . ./common/preamble > > > -_begin_fstest auto log replay > > > +_begin_fstest auto log replay recoveryloop > > > > > > # Override the default cleanup function. > > > _cleanup() > > > diff --git a/tests/generic/457 b/tests/generic/457 > > > index d9e38268..f4fdd81d 100755 > > > --- a/tests/generic/457 > > > +++ b/tests/generic/457 > > > @@ -7,7 +7,7 @@ > > > # Run fsx with log writes on cloned files to verify power fail safeness. > > > # > > > . ./common/preamble > > > -_begin_fstest auto log replay clone > > > +_begin_fstest auto log replay clone recoveryloop > > > > > > # Override the default cleanup function. > > > _cleanup() > > > diff --git a/tests/generic/475 b/tests/generic/475 > > > index 62894491..c426402e 100755 > > > --- a/tests/generic/475 > > > +++ b/tests/generic/475 > > > @@ -12,7 +12,7 @@ > > > # testing efforts. > > > # > > > . ./common/preamble > > > -_begin_fstest shutdown auto log metadata eio > > > +_begin_fstest shutdown auto log metadata eio recoveryloop > > > > > > # Override the default cleanup function. > > > _cleanup() > > > diff --git a/tests/generic/482 b/tests/generic/482 > > > index f26e6fc4..0fadf795 100755 > > > --- a/tests/generic/482 > > > +++ b/tests/generic/482 > > > @@ -9,7 +9,7 @@ > > > # Will do log replay and check the filesystem. > > > # > > > . ./common/preamble > > > -_begin_fstest auto metadata replay thin > > > +_begin_fstest auto metadata replay thin recoveryloop > > > > > > # Override the default cleanup function. > > > _cleanup() > > > diff --git a/tests/generic/725 b/tests/generic/725 > > > index f43bcb37..8bd724e3 100755 > > > --- a/tests/generic/725 > > > +++ b/tests/generic/725 > > > @@ -12,7 +12,7 @@ > > > # in writeback on the host that cause VM guests to fail to recover. > > > # > > > . ./common/preamble > > > -_begin_fstest shutdown auto log metadata eio > > > +_begin_fstest shutdown auto log metadata eio recoveryloop > > > > > > _cleanup() > > > { > > > diff --git a/tests/xfs/057 b/tests/xfs/057 > > > index d4cfa8dc..9fb3f406 100755 > > > --- a/tests/xfs/057 > > > +++ b/tests/xfs/057 > > > @@ -21,7 +21,7 @@ > > > # Note that this test requires a DEBUG mode kernel. > > > # > > > . ./common/preamble > > > -_begin_fstest auto log > > > +_begin_fstest auto log recoveryloop > > > > > > # Override the default cleanup function. > > > _cleanup() > > > > > > > > > -- > > Filipe David Manana, > > > > “Whether you think you can, or you think you can't — you're right.” -- Filipe David Manana, “Whether you think you can, or you think you can't — you're right.” ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/1] misc: tag all tests that examine crash recovery in a loop 2021-07-28 0:10 ` [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop Darrick J. Wong 2021-07-28 1:18 ` Dave Chinner 2021-07-28 9:40 ` Filipe Manana @ 2021-07-29 16:53 ` Darrick J. Wong 2 siblings, 0 replies; 7+ messages in thread From: Darrick J. Wong @ 2021-07-29 16:53 UTC (permalink / raw) To: guaneryu; +Cc: linux-xfs, fstests, guan, fdmanana, dchinner From: Darrick J. Wong <djwong@kernel.org> Given all the recent problems that we've been finding with log recovery, I think it would be useful to create a 'recoveryloop' group so that developers have a convenient way to run every single test that rolls around in a fs shutdown loop looking for subtle errors in recovery. Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Dave Chinner <dchinner@redhat.com> --- v2: add more tests per fdmanana suggestion --- tests/btrfs/172 | 2 +- tests/btrfs/190 | 2 +- tests/btrfs/192 | 2 +- tests/btrfs/206 | 2 +- tests/generic/019 | 2 +- tests/generic/388 | 2 +- tests/generic/455 | 2 +- tests/generic/457 | 2 +- tests/generic/475 | 2 +- tests/generic/482 | 2 +- tests/generic/725 | 2 +- tests/xfs/057 | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/btrfs/172 b/tests/btrfs/172 index 4db54642..f5acc698 100755 --- a/tests/btrfs/172 +++ b/tests/btrfs/172 @@ -11,7 +11,7 @@ # btrfs: replace all uses of btrfs_ordered_update_i_size # . ./common/preamble -_begin_fstest auto quick log replay +_begin_fstest auto quick log replay recoveryloop # Import common functions. . ./common/filter diff --git a/tests/btrfs/190 b/tests/btrfs/190 index 3aa718e2..974438c1 100755 --- a/tests/btrfs/190 +++ b/tests/btrfs/190 @@ -8,7 +8,7 @@ # balance needs to be resumed on mount. # . ./common/preamble -_begin_fstest auto quick replay balance qgroup +_begin_fstest auto quick replay balance qgroup recoveryloop # Import common functions. . ./common/filter diff --git a/tests/btrfs/192 b/tests/btrfs/192 index dd197b6b..bcf14ebb 100755 --- a/tests/btrfs/192 +++ b/tests/btrfs/192 @@ -8,7 +8,7 @@ # and removal # . ./common/preamble -_begin_fstest auto replay snapshot stress +_begin_fstest auto replay snapshot stress recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/btrfs/206 b/tests/btrfs/206 index c45b89e6..efb07b4b 100755 --- a/tests/btrfs/206 +++ b/tests/btrfs/206 @@ -12,7 +12,7 @@ # btrfs: replace all uses of btrfs_ordered_update_i_size # . ./common/preamble -_begin_fstest auto quick log replay +_begin_fstest auto quick log replay recoveryloop # Import common functions. . ./common/filter diff --git a/tests/generic/019 b/tests/generic/019 index b8d025d6..db56dac1 100755 --- a/tests/generic/019 +++ b/tests/generic/019 @@ -8,7 +8,7 @@ # check filesystem consistency at the end. # . ./common/preamble -_begin_fstest aio dangerous enospc rw stress +_begin_fstest aio dangerous enospc rw stress recoveryloop fio_config=$tmp.fio diff --git a/tests/generic/388 b/tests/generic/388 index e41712af..9cd737e8 100755 --- a/tests/generic/388 +++ b/tests/generic/388 @@ -15,7 +15,7 @@ # spurious corruption reports and/or mount failures. # . ./common/preamble -_begin_fstest shutdown auto log metadata +_begin_fstest shutdown auto log metadata recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/455 b/tests/generic/455 index 62788798..13d326e7 100755 --- a/tests/generic/455 +++ b/tests/generic/455 @@ -7,7 +7,7 @@ # Run fsx with log writes to verify power fail safeness. # . ./common/preamble -_begin_fstest auto log replay +_begin_fstest auto log replay recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/457 b/tests/generic/457 index d9e38268..f4fdd81d 100755 --- a/tests/generic/457 +++ b/tests/generic/457 @@ -7,7 +7,7 @@ # Run fsx with log writes on cloned files to verify power fail safeness. # . ./common/preamble -_begin_fstest auto log replay clone +_begin_fstest auto log replay clone recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/475 b/tests/generic/475 index 62894491..c426402e 100755 --- a/tests/generic/475 +++ b/tests/generic/475 @@ -12,7 +12,7 @@ # testing efforts. # . ./common/preamble -_begin_fstest shutdown auto log metadata eio +_begin_fstest shutdown auto log metadata eio recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/482 b/tests/generic/482 index f26e6fc4..0fadf795 100755 --- a/tests/generic/482 +++ b/tests/generic/482 @@ -9,7 +9,7 @@ # Will do log replay and check the filesystem. # . ./common/preamble -_begin_fstest auto metadata replay thin +_begin_fstest auto metadata replay thin recoveryloop # Override the default cleanup function. _cleanup() diff --git a/tests/generic/725 b/tests/generic/725 index f43bcb37..8bd724e3 100755 --- a/tests/generic/725 +++ b/tests/generic/725 @@ -12,7 +12,7 @@ # in writeback on the host that cause VM guests to fail to recover. # . ./common/preamble -_begin_fstest shutdown auto log metadata eio +_begin_fstest shutdown auto log metadata eio recoveryloop _cleanup() { diff --git a/tests/xfs/057 b/tests/xfs/057 index d4cfa8dc..9fb3f406 100755 --- a/tests/xfs/057 +++ b/tests/xfs/057 @@ -21,7 +21,7 @@ # Note that this test requires a DEBUG mode kernel. # . ./common/preamble -_begin_fstest auto log +_begin_fstest auto log recoveryloop # Override the default cleanup function. _cleanup() ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-29 16:53 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-07-28 0:10 [PATCHSET 0/1] fstests: tag recovery loop tests Darrick J. Wong 2021-07-28 0:10 ` [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop Darrick J. Wong 2021-07-28 1:18 ` Dave Chinner 2021-07-28 9:40 ` Filipe Manana 2021-07-28 16:45 ` Darrick J. Wong 2021-07-29 10:18 ` Filipe Manana 2021-07-29 16:53 ` [PATCH v2 " Darrick J. Wong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).