From: Eryu Guan <guan@eryu.me>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 5/9] common/dmthin: make this work with external log devices
Date: Sun, 18 Apr 2021 20:25:48 +0800 [thread overview]
Message-ID: <YHwlTMySYgKuaw6Y@desktop> (raw)
In-Reply-To: <161836230182.2754991.16864806174255630147.stgit@magnolia>
On Tue, Apr 13, 2021 at 06:05:01PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Provide a mkfs helper to format the dm thin device when external devices
> are in use, and fix the dmthin mount helper to support them. This fixes
> regressions in generic/347 and generic/500 when external logs are in
> use.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> common/dmthin | 9 ++++++++-
> tests/generic/223 | 3 +++
> tests/generic/347 | 2 +-
> tests/generic/500 | 2 +-
> 4 files changed, 13 insertions(+), 3 deletions(-)
>
>
> diff --git a/common/dmthin b/common/dmthin
> index c58c3948..3b1c7d45 100644
> --- a/common/dmthin
> +++ b/common/dmthin
> @@ -218,10 +218,17 @@ _dmthin_set_fail()
>
> _dmthin_mount_options()
> {
> - echo `_common_dev_mount_options $*` $DMTHIN_VOL_DEV $SCRATCH_MNT
> + _scratch_options mount
> + echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS $DMTHIN_VOL_DEV $SCRATCH_MNT
> }
>
> _dmthin_mount()
> {
> _mount -t $FSTYP `_dmthin_mount_options $*`
> }
> +
> +_dmthin_mkfs()
> +{
> + _scratch_options mkfs
> + _mkfs_dev $SCRATCH_OPTIONS $@ $DMTHIN_VOL_DEV
> +}
> diff --git a/tests/generic/223 b/tests/generic/223
> index 1f85efe5..a5ace82f 100755
> --- a/tests/generic/223
> +++ b/tests/generic/223
> @@ -43,6 +43,9 @@ for SUNIT_K in 8 16 32 64 128; do
> _scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE >> $seqres.full 2>&1
> _scratch_mount
>
> + # Make sure everything is on the data device
> + $XFS_IO_PROG -c 'chattr -t' $SCRATCH_MNT
What does this do for non-xfs filesystems? Do we need a FSTYP check and
do chattr only on XFS?
Thanks,
Eryu
> +
> for SIZE_MULT in 1 2 8 64 256; do
> let SIZE=$SIZE_MULT*$SUNIT_BYTES
>
> diff --git a/tests/generic/347 b/tests/generic/347
> index cbc5150a..e970ac10 100755
> --- a/tests/generic/347
> +++ b/tests/generic/347
> @@ -31,7 +31,7 @@ _setup_thin()
> {
> _dmthin_init $BACKING_SIZE $VIRTUAL_SIZE
> _dmthin_set_queue
> - _mkfs_dev $DMTHIN_VOL_DEV
> + _dmthin_mkfs
> _dmthin_mount
> }
>
> diff --git a/tests/generic/500 b/tests/generic/500
> index 085ddbf3..5ab2f78c 100755
> --- a/tests/generic/500
> +++ b/tests/generic/500
> @@ -68,7 +68,7 @@ CLUSTER_SIZE=$((64 * 1024 / 512)) # 64K
>
> _dmthin_init $BACKING_SIZE $VIRTUAL_SIZE $CLUSTER_SIZE 0
> _dmthin_set_fail
> -_mkfs_dev $DMTHIN_VOL_DEV
> +_dmthin_mkfs
> _dmthin_mount
>
> # There're two bugs at here, one is dm-thin bug, the other is filesystem
next prev parent reply other threads:[~2021-04-18 12:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 1:04 [PATCHSET 0/9] fstests: random fixes Darrick J. Wong
2021-04-14 1:04 ` [PATCH 1/9] xfs/506: fix regression on freshly quotachecked filesystem Darrick J. Wong
2021-04-14 6:12 ` Christoph Hellwig
2021-04-14 1:04 ` [PATCH 2/9] generic/563: selectively remove the io cgroup controller Darrick J. Wong
2021-04-14 6:13 ` Christoph Hellwig
2021-04-14 1:04 ` [PATCH 3/9] xfs/521,530: refactor scratch fs check Darrick J. Wong
2021-04-14 6:15 ` Christoph Hellwig
2021-04-14 1:04 ` [PATCH 4/9] common/dump: filter out xfs_restore messages about fallocate failures Darrick J. Wong
2021-04-14 6:16 ` Christoph Hellwig
2021-04-14 1:05 ` [PATCH 5/9] common/dmthin: make this work with external log devices Darrick J. Wong
2021-04-14 6:17 ` Christoph Hellwig
2021-04-18 12:25 ` Eryu Guan [this message]
2021-04-18 14:44 ` Theodore Ts'o
2021-04-19 2:04 ` Dave Chinner
2021-04-19 16:14 ` Darrick J. Wong
2021-04-14 1:05 ` [PATCH 6/9] misc: replace more open-coded _scratch_xfs_db calls Darrick J. Wong
2021-04-14 6:18 ` Christoph Hellwig
2021-04-14 1:05 ` [PATCH 7/9] generic/620: fix order of require_scratch calls Darrick J. Wong
2021-04-14 6:20 ` Christoph Hellwig
2021-04-14 1:05 ` [PATCH 8/9] generic/{094,225}: skip test when the xfs rt extent size is larger than 1 fsb Darrick J. Wong
2021-04-14 6:20 ` Christoph Hellwig
2021-04-14 1:05 ` [PATCH 9/9] xfs/305: make sure that fsstress is still running when we quotaoff Darrick J. Wong
2021-04-14 6:21 ` Christoph Hellwig
2021-04-14 14:38 ` Darrick J. Wong
2021-04-20 6:21 ` Christoph Hellwig
2021-04-18 12:29 ` [PATCHSET 0/9] fstests: random fixes Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHwlTMySYgKuaw6Y@desktop \
--to=guan@eryu.me \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).