FSTests Archive on lore.kernel.org
 help / color / Atom feed
* README: fsgqa needs a home directory too
@ 2020-01-31 21:22 Christian Kujau
  2020-02-17 12:53 ` Eryu Guan
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Kujau @ 2020-01-31 21:22 UTC (permalink / raw)
  To: fstests

generic/128 whould fail with:

     QA output created by 128
    +su: warning: cannot change directory to /home/fsgqa: No such file or directory

Adjust README to create a home directory too. And (totally unrelated), 
fix the 404 for the udf_test tool.

Signed-off-by: Christian Kujau <lists@nerdbynature.de>

--- README.orig	2020-01-12 08:43:34.000000000 -0800
+++ README	2020-01-31 13:18:12.494026480 -0800
@@ -19,7 +19,7 @@
 	(Note that for RHEL and CentOS, you may need the EPEL repo.)
 - run make
 - run make install
-- create fsgqa test user ("sudo useradd fsgqa")
+- create fsgqa test user ("sudo useradd -m fsgqa")
 - create fsgqa group ("sudo groupadd fsgqa")
 - create 123456-fsgqa test user ("sudo useradd 123456-fsgqa")
 
@@ -33,7 +33,7 @@
     - install administrative tools specific to the filesystem you wish to test
     - If you wish to run the udf components of the suite install
       mkudffs. Also download and build the Philips UDF Verification Software
-      from http://www.extra.research.philips.com/udf/, then copy the udf_test
+      from https://www.lscdweb.com/registered/udf_verifier.html, then copy the udf_test
       binary to xfstests/src/. If you wish to disable UDF verification test
       set the environment variable DISABLE_UDF_TEST to 1.
 

-- 
BOFH excuse #220:

Someone thought The Big Red Button was a light switch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: README: fsgqa needs a home directory too
  2020-01-31 21:22 README: fsgqa needs a home directory too Christian Kujau
@ 2020-02-17 12:53 ` Eryu Guan
  2020-02-19  0:33   ` Christian Kujau
  0 siblings, 1 reply; 3+ messages in thread
From: Eryu Guan @ 2020-02-17 12:53 UTC (permalink / raw)
  To: Christian Kujau; +Cc: fstests

On Fri, Jan 31, 2020 at 01:22:49PM -0800, Christian Kujau wrote:
> generic/128 whould fail with:
> 
>      QA output created by 128
>     +su: warning: cannot change directory to /home/fsgqa: No such file or directory
> 
> Adjust README to create a home directory too. And (totally unrelated), 
> fix the 404 for the udf_test tool.
> 
> Signed-off-by: Christian Kujau <lists@nerdbynature.de>

Ok, your patch is missing the "---" below Signed-off-by line

---

above dashes make the patch appliable.

Thanks,
Eryu

> 
> --- README.orig	2020-01-12 08:43:34.000000000 -0800
> +++ README	2020-01-31 13:18:12.494026480 -0800
> @@ -19,7 +19,7 @@
>  	(Note that for RHEL and CentOS, you may need the EPEL repo.)
>  - run make
>  - run make install
> -- create fsgqa test user ("sudo useradd fsgqa")
> +- create fsgqa test user ("sudo useradd -m fsgqa")
>  - create fsgqa group ("sudo groupadd fsgqa")
>  - create 123456-fsgqa test user ("sudo useradd 123456-fsgqa")
>  
> @@ -33,7 +33,7 @@
>      - install administrative tools specific to the filesystem you wish to test
>      - If you wish to run the udf components of the suite install
>        mkudffs. Also download and build the Philips UDF Verification Software
> -      from http://www.extra.research.philips.com/udf/, then copy the udf_test
> +      from https://www.lscdweb.com/registered/udf_verifier.html, then copy the udf_test
>        binary to xfstests/src/. If you wish to disable UDF verification test
>        set the environment variable DISABLE_UDF_TEST to 1.
>  
> 
> -- 
> BOFH excuse #220:
> 
> Someone thought The Big Red Button was a light switch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: README: fsgqa needs a home directory too
  2020-02-17 12:53 ` Eryu Guan
@ 2020-02-19  0:33   ` Christian Kujau
  0 siblings, 0 replies; 3+ messages in thread
From: Christian Kujau @ 2020-02-19  0:33 UTC (permalink / raw)
  To: Eryu Guan; +Cc: fstests

On Mon, 17 Feb 2020, Eryu Guan wrote:
> > Signed-off-by: Christian Kujau <lists@nerdbynature.de>
> 
> Ok, your patch is missing the "---" below Signed-off-by line
> 
> ---
> 
> above dashes make the patch appliable.

Sorry for that, next time I'll try to use scripts/checkpatch.pl from the 
Kernel project before submitting patches.

Thanks for applying this.

Christian.
-- 
BOFH excuse #70:

nesting roaches shorted out the ether cable

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31 21:22 README: fsgqa needs a home directory too Christian Kujau
2020-02-17 12:53 ` Eryu Guan
2020-02-19  0:33   ` Christian Kujau

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git