fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] common/rc: Remove special handing of 'dup' argument for btrfs
@ 2019-09-27 10:52 Nikolay Borisov
  2019-09-27 10:52 ` [PATCH 2/2] btrfs: Add test for btrfs balance convert functionality Nikolay Borisov
  2019-09-27 13:10 ` [PATCH 1/2] common/rc: Remove special handing of 'dup' argument for btrfs David Sterba
  0 siblings, 2 replies; 7+ messages in thread
From: Nikolay Borisov @ 2019-09-27 10:52 UTC (permalink / raw)
  To: fstests; +Cc: linux-btrfs, Nikolay Borisov

_scratch_pool_mkfs special cases the command executed when 'dup' option
is used when creating a filesystem. This is wrong since 'dup' works
for all profiles and number of devices. This bug manifested while
exercising btrfs' balance argument combinations test.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 common/rc | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/common/rc b/common/rc
index 9f2c252e5aa5..1b150cbad2f6 100644
--- a/common/rc
+++ b/common/rc
@@ -885,13 +885,7 @@ _scratch_pool_mkfs()
 {
     case $FSTYP in
     btrfs)
-        # if dup profile is in mkfs options call _scratch_mkfs instead
-        # because dup profile only works with single device
-        if [[ "$*" =~ dup ]]; then
-            _scratch_mkfs $*
-        else
-            $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV_POOL > /dev/null
-        fi
+        $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV_POOL > /dev/null
         ;;
     *)
         echo "_scratch_pool_mkfs is not implemented for $FSTYP" 1>&2
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-09-27 13:18 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 10:52 [PATCH 1/2] common/rc: Remove special handing of 'dup' argument for btrfs Nikolay Borisov
2019-09-27 10:52 ` [PATCH 2/2] btrfs: Add test for btrfs balance convert functionality Nikolay Borisov
2019-09-27 11:21   ` Qu Wenruo
2019-09-27 11:50     ` Nikolay Borisov
2019-09-27 12:22       ` Qu Wenruo
2019-09-27 13:18         ` Nikolay Borisov
2019-09-27 13:10 ` [PATCH 1/2] common/rc: Remove special handing of 'dup' argument for btrfs David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).