* [PATCH v2] btrfs: add test for large direct I/O w/ RAID
@ 2020-03-06 1:03 Omar Sandoval
2020-03-06 8:32 ` Nikolay Borisov
0 siblings, 1 reply; 2+ messages in thread
From: Omar Sandoval @ 2020-03-06 1:03 UTC (permalink / raw)
To: fstests, linux-btrfs; +Cc: kernel-team, Josef Bacik
From: Omar Sandoval <osandov@fb.com>
Apparently we don't have any tests which exercise the code path in Btrfs
that has to split up direct I/Os for RAID stripes. Add one to catch the
bug fixed by "btrfs: fix RAID direct I/O reads with alternate csums".
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Omar Sandoval <osandov@fb.com>
---
Changes from v1 -> v2:
- Also test direct I/O writes.
- Add Josef's reviewed-by
tests/btrfs/207 | 62 +++++++++++++++++++++++++++++++++++++++++++++
tests/btrfs/207.out | 2 ++
tests/btrfs/group | 3 ++-
3 files changed, 66 insertions(+), 1 deletion(-)
create mode 100755 tests/btrfs/207
create mode 100644 tests/btrfs/207.out
diff --git a/tests/btrfs/207 b/tests/btrfs/207
new file mode 100755
index 00000000..d4467401
--- /dev/null
+++ b/tests/btrfs/207
@@ -0,0 +1,62 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2020 Facebook. All Rights Reserved.
+#
+# FS QA Test 207
+#
+# Test large DIO reads and writes with various profiles. Regression test for
+# patch "btrfs: fix RAID direct I/O reads with alternate csums".
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+_supported_fs btrfs
+_supported_os Linux
+# we check scratch dev after each loop
+_require_scratch_nocheck
+_require_scratch_dev_pool 4
+_btrfs_get_profile_configs
+
+for mkfs_opts in "${_btrfs_profile_configs[@]}"; do
+ echo "Test $mkfs_opts" >>$seqres.full
+ _scratch_pool_mkfs $mkfs_opts >>$seqres.full 2>&1
+ _scratch_mount >>$seqres.full 2>&1
+
+ dd if=/dev/urandom of="$SCRATCH_MNT/$seq" \
+ bs=1M count=64 conv=fsync status=none
+ dd if="$SCRATCH_MNT/$seq" of="$SCRATCH_MNT/$seq.dioread" \
+ bs=1M iflag=direct status=none
+ dd if="$SCRATCH_MNT/$seq" of="$SCRATCH_MNT/$seq.diowrite" \
+ bs=1M oflag=direct status=none
+ diff -q "$SCRATCH_MNT/$seq" "$SCRATCH_MNT/$seq.dioread" |
+ tee -a $seqres.full
+ diff -q "$SCRATCH_MNT/$seq" "$SCRATCH_MNT/$seq.diowrite" |
+ tee -a $seqres.full
+
+ _scratch_unmount
+ _check_scratch_fs
+done
+
+echo "Silence is golden"
+
+status=0
+exit
diff --git a/tests/btrfs/207.out b/tests/btrfs/207.out
new file mode 100644
index 00000000..cb8e0e2b
--- /dev/null
+++ b/tests/btrfs/207.out
@@ -0,0 +1,2 @@
+QA output created by 207
+Silence is golden
diff --git a/tests/btrfs/group b/tests/btrfs/group
index e3ad347b..c87a042e 100644
--- a/tests/btrfs/group
+++ b/tests/btrfs/group
@@ -208,4 +208,5 @@
203 auto quick send clone
204 auto quick punch
205 auto quick clone compress
-204 auto quick log replay
+206 auto quick log replay
+207 auto quick rw raid
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] btrfs: add test for large direct I/O w/ RAID
2020-03-06 1:03 [PATCH v2] btrfs: add test for large direct I/O w/ RAID Omar Sandoval
@ 2020-03-06 8:32 ` Nikolay Borisov
0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Borisov @ 2020-03-06 8:32 UTC (permalink / raw)
To: Omar Sandoval, fstests, linux-btrfs; +Cc: kernel-team, Josef Bacik
On 6.03.20 г. 3:03 ч., Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Apparently we don't have any tests which exercise the code path in Btrfs
> that has to split up direct I/Os for RAID stripes. Add one to catch the
> bug fixed by "btrfs: fix RAID direct I/O reads with alternate csums".
>
> Reviewed-by: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-06 8:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 1:03 [PATCH v2] btrfs: add test for large direct I/O w/ RAID Omar Sandoval
2020-03-06 8:32 ` Nikolay Borisov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).