git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olga Telezhnaya <olyatelezhnaya@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH v2 2/2] ref-filter: get rid of goto
Date: Wed, 21 Feb 2018 07:02:36 +0000	[thread overview]
Message-ID: <01020161b72bce58-d3167109-3dd1-40fe-8ad9-727629cd918e-000000@eu-west-1.amazonses.com> (raw)
In-Reply-To: <01020161b72bcdff-eb1350fb-12a2-4aaa-abb0-248bf481b2ab-000000@eu-west-1.amazonses.com>

Get rid of goto command in ref-filter for better readability.

Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com>
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored by: Jeff King <peff@peff.net>
---
 ref-filter.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ref-filter.c b/ref-filter.c
index 83ffd84affe52..35359818a1ebb 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1494,11 +1494,11 @@ static void populate_value(struct ref_array_item *ref)
 	for (i = 0; i < used_atom_cnt; i++) {
 		struct atom_value *v = &ref->value[i];
 		if (v->s == NULL)
-			goto need_obj;
+			break;
 	}
-	return;
+	if (i >= used_atom_cnt)
+		return;
 
- need_obj:
 	get_object(ref, &ref->objectname, 0, &obj);
 
 	/*

--
https://github.com/git/git/pull/460

  reply	other threads:[~2018-02-21  7:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21  6:59 [PATCH 1/2] ref-filter: get rid of duplicate code Olga Telezhnaya
2018-02-21  6:59 ` [PATCH 2/2] ref-filter: get rid of goto Olga Telezhnaya
2018-02-21 17:41   ` Junio C Hamano
2018-02-22  5:35     ` Оля Тележная
2018-02-21  7:02 ` [PATCH v2 1/2] ref-filter: get rid of duplicate code Olga Telezhnaya
2018-02-21  7:02   ` Olga Telezhnaya [this message]
2018-02-21 17:33 ` [PATCH " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01020161b72bce58-d3167109-3dd1-40fe-8ad9-727629cd918e-000000@eu-west-1.amazonses.com \
    --to=olyatelezhnaya@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).