* [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px
@ 2009-10-12 6:33 Vietor Liu
2009-10-12 7:35 ` Johannes Schindelin
0 siblings, 1 reply; 6+ messages in thread
From: Vietor Liu @ 2009-10-12 6:33 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: git
When the screen height equal 600 px(e.g. Asus EeePC 1024x600), The
_main window_ should be hide the _Push button_ and _Status bar_.
Signed-off-by: Vietor Liu <vietor@vxwo.org>
---
git-gui.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index 09b2720..037a1f2 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -3083,7 +3083,7 @@ frame .vpane.lower.diff.body
set ui_diff .vpane.lower.diff.body.t
text $ui_diff -background white -foreground black \
-borderwidth 0 \
- -width 80 -height 15 -wrap none \
+ -width 80 -height 5 -wrap none \
-font font_diff \
-xscrollcommand {.vpane.lower.diff.body.sbx set} \
-yscrollcommand {.vpane.lower.diff.body.sby set} \
--
1.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px
2009-10-12 6:33 [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px Vietor Liu
@ 2009-10-12 7:35 ` Johannes Schindelin
2009-10-12 8:23 ` Vietor Liu
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Schindelin @ 2009-10-12 7:35 UTC (permalink / raw)
To: Vietor Liu; +Cc: Shawn O. Pearce, git
Hi,
On Mon, 12 Oct 2009, Vietor Liu wrote:
> When the screen height equal 600 px(e.g. Asus EeePC 1024x600), The
> _main window_ should be hide the _Push button_ and _Status bar_.
Your commit message disagrees with the patch:
> set ui_diff .vpane.lower.diff.body.t
> text $ui_diff -background white -foreground black \
> -borderwidth 0 \
> - -width 80 -height 15 -wrap none \
> + -width 80 -height 5 -wrap none \
> -font font_diff \
So what you _actually_ do is reduce the space for the diff, no?
Ciao,
Dscho
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px
2009-10-12 7:35 ` Johannes Schindelin
@ 2009-10-12 8:23 ` Vietor Liu
2009-10-12 14:34 ` Shawn O. Pearce
0 siblings, 1 reply; 6+ messages in thread
From: Vietor Liu @ 2009-10-12 8:23 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Shawn O. Pearce, git
On Mon, 2009-10-12 at 09:35 +0200, Johannes Schindelin wrote:
>
> So what you _actually_ do is reduce the space for the diff, no?
>
Yes.
The _main window_ support auto resize. I was tested some way, only
modify _diff body_ space could work. The _diff body_ is part of _main
window_.
Whether modify the commit message?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px
2009-10-12 8:23 ` Vietor Liu
@ 2009-10-12 14:34 ` Shawn O. Pearce
0 siblings, 0 replies; 6+ messages in thread
From: Shawn O. Pearce @ 2009-10-12 14:34 UTC (permalink / raw)
To: Vietor Liu; +Cc: Johannes Schindelin, git
Vietor Liu <vietor@vxwo.org> wrote:
> On Mon, 2009-10-12 at 09:35 +0200, Johannes Schindelin wrote:
> >
> > So what you _actually_ do is reduce the space for the diff, no?
Dscho, I think what's happening is he is shrinking the minimum height
of the diff pane. By allowing it to be shorter he is trading diff
pane space in order to make room for the fixed height commit message
area below it.
> Yes.
> The _main window_ support auto resize. I was tested some way, only
> modify _diff body_ space could work. The _diff body_ is part of _main
> window_.
>
> Whether modify the commit message?
Yes, please modify the commit message. The message does not clearly
state what is occurring here, which is why Dsco had an issue.
Really you are trying to adjust the minimum height of the diff
pane, which is resizable, so that it can use less vertical height,
allowing the overall window to be shorter and still display the
entire commit pane.
Also, I find your use of underscores around widget names to be
very difficult to read. I don't see a reason for it in the commit
message.
--
Shawn.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px
@ 2009-10-12 3:18 Vietor Liu
0 siblings, 0 replies; 6+ messages in thread
From: Vietor Liu @ 2009-10-12 3:18 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: git
When the screen height equal 600 px(e.g. Asus EeePC 1024x600), The
_main window_ should be hide the _Push button_ and _Status bar_.
Signed-off-by: Vietor Liu <vietor@vxwo.org>
---
git-gui.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index 09b2720..037a1f2 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -3083,7 +3083,7 @@ frame .vpane.lower.diff.body
set ui_diff .vpane.lower.diff.body.t
text $ui_diff -background white -foreground black \
-borderwidth 0 \
- -width 80 -height 15 -wrap none \
+ -width 80 -height 5 -wrap none \
-font font_diff \
-xscrollcommand {.vpane.lower.diff.body.sbx set} \
-yscrollcommand {.vpane.lower.diff.body.sby set} \
--
1.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px
@ 2009-10-10 0:59 Vietor Liu
0 siblings, 0 replies; 6+ messages in thread
From: Vietor Liu @ 2009-10-10 0:59 UTC (permalink / raw)
To: spearce; +Cc: git
When the screen height equal 600 px(e.g. Asus EeePC 1024x600), The
_main window_ should be hide the _Push button_ and _Status bar_.
Signed-off-by: Vietor Liu <vietor.liu@gmail.com>
---
git-gui.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index 09b2720..037a1f2 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -3083,7 +3083,7 @@ frame .vpane.lower.diff.body
set ui_diff .vpane.lower.diff.body.t
text $ui_diff -background white -foreground black \
-borderwidth 0 \
- -width 80 -height 15 -wrap none \
+ -width 80 -height 5 -wrap none \
-font font_diff \
-xscrollcommand {.vpane.lower.diff.body.sbx set} \
-yscrollcommand {.vpane.lower.diff.body.sby set} \
--
1.6.5.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-10-12 14:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-12 6:33 [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px Vietor Liu
2009-10-12 7:35 ` Johannes Schindelin
2009-10-12 8:23 ` Vietor Liu
2009-10-12 14:34 ` Shawn O. Pearce
-- strict thread matches above, loose matches on Subject: below --
2009-10-12 3:18 Vietor Liu
2009-10-10 0:59 Vietor Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).