* [PATCH] pathspec: removed unnecessary function prototypes
@ 2016-09-13 16:52 Brandon Williams
2016-09-13 18:15 ` Jeff King
0 siblings, 1 reply; 5+ messages in thread
From: Brandon Williams @ 2016-09-13 16:52 UTC (permalink / raw)
To: git; +Cc: Brandon Williams
removed function prototypes from pathspec.h which don't have a
corresponding implementation.
Signed-off-by: Brandon Williams <bmwill@google.com>
---
pathspec.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/pathspec.h b/pathspec.h
index 4a80f6f..59809e4 100644
--- a/pathspec.h
+++ b/pathspec.h
@@ -96,7 +96,5 @@ static inline int ps_strcmp(const struct pathspec_item *item,
extern char *find_pathspecs_matching_against_index(const struct pathspec *pathspec);
extern void add_pathspec_matches_against_index(const struct pathspec *pathspec, char *seen);
-extern const char *check_path_for_gitlink(const char *path);
-extern void die_if_path_beyond_symlink(const char *path, const char *prefix);
#endif /* PATHSPEC_H */
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pathspec: removed unnecessary function prototypes
2016-09-13 16:52 [PATCH] pathspec: removed unnecessary function prototypes Brandon Williams
@ 2016-09-13 18:15 ` Jeff King
2016-09-13 23:08 ` Junio C Hamano
2016-09-14 19:23 ` Jeff King
0 siblings, 2 replies; 5+ messages in thread
From: Jeff King @ 2016-09-13 18:15 UTC (permalink / raw)
To: Brandon Williams; +Cc: git
On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote:
> removed function prototypes from pathspec.h which don't have a
> corresponding implementation.
I'm always curious of the "why" in cases like this. Did we forget to add
them? Did they get renamed? Did they go away?
Looks like the latter; 5a76aff (add: convert to use parse_pathspec,
2013-07-14) just forgot to remove them.
-Peff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pathspec: removed unnecessary function prototypes
2016-09-13 18:15 ` Jeff King
@ 2016-09-13 23:08 ` Junio C Hamano
2016-09-14 19:23 ` Jeff King
1 sibling, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2016-09-13 23:08 UTC (permalink / raw)
To: Jeff King; +Cc: Brandon Williams, git
Jeff King <peff@peff.net> writes:
> On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote:
>
>> removed function prototypes from pathspec.h which don't have a
>> corresponding implementation.
>
> I'm always curious of the "why" in cases like this. Did we forget to add
> them? Did they get renamed? Did they go away?
>
> Looks like the latter; 5a76aff (add: convert to use parse_pathspec,
> 2013-07-14) just forgot to remove them.
Thanks for digging.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pathspec: removed unnecessary function prototypes
2016-09-13 18:15 ` Jeff King
2016-09-13 23:08 ` Junio C Hamano
@ 2016-09-14 19:23 ` Jeff King
2016-09-14 19:30 ` Brandon Williams
1 sibling, 1 reply; 5+ messages in thread
From: Jeff King @ 2016-09-14 19:23 UTC (permalink / raw)
To: Brandon Williams; +Cc: git
On Tue, Sep 13, 2016 at 11:15:52AM -0700, Jeff King wrote:
> On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote:
>
> > removed function prototypes from pathspec.h which don't have a
> > corresponding implementation.
>
> I'm always curious of the "why" in cases like this. Did we forget to add
> them? Did they get renamed? Did they go away?
>
> Looks like the latter; 5a76aff (add: convert to use parse_pathspec,
> 2013-07-14) just forgot to remove them.
I should have done a better job of not just providing the answer, but
showing how. The easiest tool here is "git log -S":
git log -1 -p -Scheck_path_for_gitlink
(and then you can see that the whole function went away there).
-Peff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pathspec: removed unnecessary function prototypes
2016-09-14 19:23 ` Jeff King
@ 2016-09-14 19:30 ` Brandon Williams
0 siblings, 0 replies; 5+ messages in thread
From: Brandon Williams @ 2016-09-14 19:30 UTC (permalink / raw)
To: Jeff King; +Cc: git
On Wed, Sep 14, 2016 at 12:23 PM, Jeff King <peff@peff.net> wrote:
> On Tue, Sep 13, 2016 at 11:15:52AM -0700, Jeff King wrote:
> I should have done a better job of not just providing the answer, but
> showing how. The easiest tool here is "git log -S":
>
> git log -1 -p -Scheck_path_for_gitlink
>
> (and then you can see that the whole function went away there).
>
> -Peff
Perfect thanks! There's still a lot of little features like this that
I'm unaware
of so I really appreciate the pointer.
-Brandon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-14 19:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 16:52 [PATCH] pathspec: removed unnecessary function prototypes Brandon Williams
2016-09-13 18:15 ` Jeff King
2016-09-13 23:08 ` Junio C Hamano
2016-09-14 19:23 ` Jeff King
2016-09-14 19:30 ` Brandon Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).