git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: lists@haller-berlin.de (Stefan Haller)
To: szeder@ira.uka.de (SZEDER Gábor),
	Matthieu.Moy@grenoble-inp.fr (Matthieu Moy)
Cc: git@vger.kernel.org
Subject: Re: Zsh completion regression
Date: Sat, 14 Jan 2012 22:36:38 +0100	[thread overview]
Message-ID: <1kdvsvw.10asu1tpmtz3qM%lists@haller-berlin.de> (raw)
In-Reply-To: <20120114132343.GW30469@goldbirke>

SZEDER Gábor <szeder@ira.uka.de> wrote:

> However.
> 
> While playing around with zsh, I noticed that git completion works
> without even sourcing git's bash completion script.  As it turned out,
> zsh ships its own git completion script[1], and from my cursory tests
> it seems to be quite capable: it supports commands, aliases, options,
> refs, ref1..ref2, config variables, ...  and I also saw a __git_ps1()
> equivalent for zsh.
> 
> So, is there any reason why you are still using git's bash completion
> under zsh (which has some quirks and lacks some features) instead of
> zsh's own?  Perhaps it would make sense to point zsh users to zsh's
> git completion and drop zsh compatibility from git's bash completion.
> We did similar with vim config files: git included a vim syntax
> highlight config file for commit messages under contrib/vim/, but
> eventually we dropped it after vim started shipping more capable
> git-specific config files (for git config files, rebase instruction
> sheets, etc.).

Last time I compared the two, the bash completion script was a lot more
complete and powerful. The zsh script had a few annoying limitations for
things that I use every day, and that worked with the bash script, so I
switched to that. Unfortunately I forgot the details, it's a while ago.


-- 
Stefan Haller
Berlin, Germany
http://www.haller-berlin.de/

      parent reply	other threads:[~2012-01-14 21:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-12 11:52 Zsh completion regression Stefan Haller
2012-01-12 14:56 ` Matthieu Moy
2012-01-14 13:23   ` SZEDER Gábor
2012-01-14 14:32     ` Matthieu Moy
2012-01-14 15:20       ` SZEDER Gábor
2012-01-14 18:55         ` [PATCH] bash-completion: don't add quoted space for ZSH (fix regression) Matthieu Moy
2012-01-15  2:29           ` Junio C Hamano
2012-01-16 11:49             ` Matthieu Moy
2012-01-16 22:47               ` Junio C Hamano
2012-01-17 12:21                 ` Matthieu Moy
2012-01-17 18:46                   ` Junio C Hamano
2012-01-17 19:18           ` Felipe Contreras
2012-01-17 20:03             ` Felipe Contreras
2012-01-17 20:11               ` Junio C Hamano
2012-01-17 23:04                 ` Felipe Contreras
2012-01-17 23:42                   ` Junio C Hamano
2012-01-18  8:16                     ` Matthieu Moy
2012-01-25  1:39                       ` Felipe Contreras
2012-01-25  4:06                         ` Junio C Hamano
2012-01-14 21:36         ` Zsh completion regression Stefan Haller
2012-01-14 21:36     ` Stefan Haller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1kdvsvw.10asu1tpmtz3qM%lists@haller-berlin.de \
    --to=lists@haller-berlin.de \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).