From: Nick Hengeveld <nickh@reactrix.com>
To: Junio C Hamano <junkio@cox.net>
Cc: "Martin Langhoff (CatalystIT)" <martin@catalyst.net.nz>,
Daniel Barkalow <barkalow@iabervon.org>,
git@vger.kernel.org
Subject: Re: Strangely broken git repo
Date: Tue, 11 Oct 2005 20:26:46 -0700 [thread overview]
Message-ID: <20051012032646.GA14819@reactrix.com> (raw)
In-Reply-To: <7v4q7p927d.fsf@assigned-by-dhcp.cox.net>
On Mon, Oct 10, 2005 at 02:00:06AM -0700, Junio C Hamano wrote:
> The fetch_alternates() function was supposed to be call-once and
> we have a static variable got_alternates that becomes 1 when it
> runs for the first time. However, there are other 'return 0's
> introduced that does not set got_alternates to 1.
Oops, thanks for catching that - I'll fix it.
> I am wondering if the semantics has changed that now we chain
> the alternates? Initially, if we are cloning/fetching from
> repository A, which borrows from repository B (i.e. alternates
> we retrieve from A would name B), and if B in turn borrows from
> C, then we assumed that A's alternates would also name C, and
> that was the reason why fetch_alternates() was call-once
> function. I do not mind if we change it to chain the alternates
> file, but if that is the case we should move the got_alternates
> variable into "struct alt_base", and pass the struct, not just
> alt->base, to fetch_alternates(), like this (untested, of
> course):
I'd thought about chaining the alternates, but wasn't sure whether it's
safe to consider all alternates in the chain equivalent. I would want to
implement fetching the chain such that it could happen parallel to other
request and not block the pull. I think it would also be useful to track
the network performance of each alternate and prefer faster sources as
new requests are started.
--
For a successful technology, reality must take precedence over public
relations, for nature cannot be fooled.
next prev parent reply other threads:[~2005-10-12 3:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46a038f90510062014l7f5740e0l77fc53b50f822e8f@mail.gmail.com>
[not found] ` <46a038f90510082014i6b296f2bvbac56e25344cbdf2@mail.gmail.com>
2005-10-10 4:26 ` Strangely broken git repo Martin Langhoff (CatalystIT)
2005-10-10 9:00 ` Junio C Hamano
2005-10-10 14:54 ` Linus Torvalds
2005-10-10 15:21 ` Linus Torvalds
2005-10-10 18:19 ` Morten Welinder
2005-10-10 18:23 ` Linus Torvalds
2005-10-10 18:30 ` Johannes Schindelin
2005-10-11 4:29 ` Quote reference names while fetching with curl Junio C Hamano
2005-10-11 5:07 ` [PATCH] git-fetch --tags: deal with tags with spaces in them Junio C Hamano
2005-10-11 6:04 ` Junio C Hamano
2005-10-12 5:29 ` Junio C Hamano
2005-10-12 8:26 ` Petr Baudis
2005-10-12 15:36 ` H. Peter Anvin
2005-10-12 15:47 ` H. Peter Anvin
2005-10-12 18:57 ` Junio C Hamano
2005-10-12 18:10 ` Junio C Hamano
2005-10-12 22:01 ` [PATCH] git-check-ref-format: reject funny ref names Junio C Hamano
2005-10-12 22:01 ` [PATCH] Refuse to create funny refs in clone-pack, git-fetch and receive-pack Junio C Hamano
2005-10-11 19:55 ` [PATCH] git-fetch --tags: deal with tags with spaces in them Matthias Urlichs
2005-10-12 3:26 ` Nick Hengeveld [this message]
2005-10-12 4:22 ` Strangely broken git repo Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051012032646.GA14819@reactrix.com \
--to=nickh@reactrix.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=martin@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).