From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Cc: "Martin Langhoff (CatalystIT)" <martin@catalyst.net.nz>
Subject: Re: [PATCH] git-fetch --tags: deal with tags with spaces in them.
Date: Tue, 11 Oct 2005 22:29:45 -0700 [thread overview]
Message-ID: <7vk6gjl2uu.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vzmpgy4g4.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Mon, 10 Oct 2005 23:04:43 -0700")
Junio C Hamano <junkio@cox.net> writes:
> We cannot still do arbitrary reference names, but at least now
> we allow spaces in them. But I am not sure if this is a good
> change.
>
> Do we in general want to support references with [^-a-zA-Z0-9.]
> in them? Most notably spaces?
>
> Opinions?
Here is mine.
I do not personally think it is too much of a restriction if we
said we only allow tags using letters from [-a-zA-Z0-9.] (yes I
am trying to be controversial by not allowing even latin-1
names). Even without going that far, if we just said we do not
allow shell metacharacters in tagnames (i.e. assuming UTF-8
encoded pathnames, non-ascii part of unicode character space is
allowed), I suspect things will get much simpler to handle.
The troublesome tags Martin's repository had were autocreated
with cvsimport. That is something we could easily fix (I think
we already do certain tagname munging).
next prev parent reply other threads:[~2005-10-12 5:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46a038f90510062014l7f5740e0l77fc53b50f822e8f@mail.gmail.com>
[not found] ` <46a038f90510082014i6b296f2bvbac56e25344cbdf2@mail.gmail.com>
2005-10-10 4:26 ` Strangely broken git repo Martin Langhoff (CatalystIT)
2005-10-10 9:00 ` Junio C Hamano
2005-10-10 14:54 ` Linus Torvalds
2005-10-10 15:21 ` Linus Torvalds
2005-10-10 18:19 ` Morten Welinder
2005-10-10 18:23 ` Linus Torvalds
2005-10-10 18:30 ` Johannes Schindelin
2005-10-11 4:29 ` Quote reference names while fetching with curl Junio C Hamano
2005-10-11 5:07 ` [PATCH] git-fetch --tags: deal with tags with spaces in them Junio C Hamano
2005-10-11 6:04 ` Junio C Hamano
2005-10-12 5:29 ` Junio C Hamano [this message]
2005-10-12 8:26 ` Petr Baudis
2005-10-12 15:36 ` H. Peter Anvin
2005-10-12 15:47 ` H. Peter Anvin
2005-10-12 18:57 ` Junio C Hamano
2005-10-12 18:10 ` Junio C Hamano
2005-10-12 22:01 ` [PATCH] git-check-ref-format: reject funny ref names Junio C Hamano
2005-10-12 22:01 ` [PATCH] Refuse to create funny refs in clone-pack, git-fetch and receive-pack Junio C Hamano
2005-10-11 19:55 ` [PATCH] git-fetch --tags: deal with tags with spaces in them Matthias Urlichs
2005-10-12 3:26 ` Strangely broken git repo Nick Hengeveld
2005-10-12 4:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk6gjl2uu.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=martin@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).