Re: git --exec-path conversion

Re: git --exec-path conversion

[Marco Costalba]

Junio C Hamano wrote:

>Marco Costalba <mcostalba@yahoo.it> writes:
>
>>if I understood correctly, git programs will be installed
>>somewhere in $PATH for at least next two months.
>
>
>I suspect things will stay in /usr/bin longer than that, but
>futureproofing is good in any case.
>
>Assuming you are writing things in C or C++:
>
> - run "git --exec-path" at the very beginning of main(),
> - read the output, prepend it to $PATH using setenv(3).
>
>and I think you are done. 

Yes. Thanks.




		
__________________________________ 
Yahoo! FareChase: Search multiple travel sites in one click.
http://farechase.yahoo.com

Re: git --exec-path conversion

[Johannes Schindelin]

Hi,

On Sat, 19 Nov 2005, Marco Costalba wrote:

> Incredible how many errors in only two lines of code :-)

If you want to know how to introduce 3 bugs in just 512 bytes of 
production code (i.e. not a development version), see

	http://www.xbox-linux.org/wiki/The_Hidden_Boot_Code_of_the_Xbox

Ciao,
Dscho

Re: git --exec-path conversion

[Junio C Hamano]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Little nit: Test for "git-", because "git" and "gitk" will stay in the 
> PATH.

Heh, he is writing QGit; why should he run gitk ;-)?

Re: git --exec-path conversion

[Junio C Hamano]

Marco Costalba <mcostalba@yahoo.it> writes:

> if I understood correctly, git programs will be installed
> somewhere in $PATH for at least next two months.

I suspect things will stay in /usr/bin longer than that, but
futureproofing is good in any case.

Assuming you are writing things in C or C++:

 - run "git --exec-path" at the very beginning of main(),
 - read the output, prepend it to $PATH using setenv(3).

and I think you are done.  After this, your QGit::run("ls") and
QGit::run("git frotz") would not be affected (you still have
/usr/bin in your $PATH), and QGIT::run("git-frotz") would find
git-frotz installed somewhere outside /usr/bin.

Re: git --exec-path conversion

[Marco Costalba]

Johannes Schindelin wrote:

>Hi,
>
>On Sat, 19 Nov 2005, Marco Costalba wrote:
>
>>    if (cmd.left(3) == "git") 
>>         cmd = cmd.prepend(exec-path);
>
>
>Little nit: Test for "git-", because "git" and "gitk" will stay in the 
>PATH.
>
You are rights. Thanks.

Also 'exec-path' is not a valid C++ identifier, it should be

    if (cmd.left(4) == "git-") 
         cmd = cmd.prepend(exec_path);


Incredible how many errors in only two lines of code :-)

Marco



		
__________________________________ 
Yahoo! FareChase: Search multiple travel sites in one click.
http://farechase.yahoo.com

Re: git --exec-path conversion

[Johannes Schindelin]

Hi,

On Sat, 19 Nov 2005, Marco Costalba wrote:

>     if (cmd.left(3) == "git") 
>          cmd = cmd.prepend(exec-path);

Little nit: Test for "git-", because "git" and "gitk" will stay in the 
PATH.

Ciao,
Dscho

git --exec-path conversion

[Marco Costalba]

Hi,

   if I understood correctly, git programs will be installed somewhere in $PATH for at least next
two months.

But I would like to update to what will be the future, i.e. prepending what 'git --exec-path' says
to any git command.

I don't call git programs directly but I use a function QGit::run(cmd) that does this plus other
things.

The problem is that I call QGit::run() also for other commands not related to git (ls, cat,
etc..).

How can I make the transition?

Now I have two ways, the brute force way and the easy (peraphs tricky) way.

The brute force is to create a new function QGit::runGitCmd() that deals only with git commands
_and_ replace all the occurences of run() with the latter.

The easy way is to prepend the exec-path *inside* run(), and to use to disambiguate bewteen git
and shell commands the testing of first three chars of the command to launch, something like:

    if (cmd.left(3) == "git") 
         cmd = cmd.prepend(exec-path);


I would like to go with the second one, I'm a bit lazy ;-) , but I would like to ask if this is a
good policy, i.e. if also inside git programs/scripts (like in git.c I guess) is used or is
foreseen to keep using something like this.


Thanks
Marco


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com