From: Jeff King <peff@peff.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] git-commit.sh: convert run_status to a C builtin
Date: Fri, 8 Sep 2006 03:34:52 -0400 [thread overview]
Message-ID: <20060908073452.GA25343@coredump.intra.peff.net> (raw)
In-Reply-To: <7v64fynbpg.fsf@assigned-by-dhcp.cox.net>
On Thu, Sep 07, 2006 at 10:56:11PM -0700, Junio C Hamano wrote:
> I just wanted to point it out because I felt the names to
> programmers are slightly different matter.
Fair enough. Do you want to change git-runstatus? It should ideally not
be used by end users at all (and hopefully can eventually go away if
git-status and git-commit become builtins).
> > wt_status? ucu_status (updated, changed, untracked)?
> Yeah, something along those lines.
I think wt_status is the most reasonable of those.
> In a distant past I saw some terminals get confused near the
> edge if you do that, but these days everybody is on some sort of
> Xterm so it may not matter. But that would probably be nice to
> fix.
OK, it will take a little wrangling with the color_printf interface, but
it should be doable.
> > OK. Besides the things you mentioned, what improvements would you like
> > to see?
> Besides the things I mentioned? I dunno offhand -- otherwise I
> would have mentioned them ;-).
Heh. OK, I assumed your previous comment hinted at hidden depths of
dissatisfaction, but clearly not. :) Patches forthcoming...
-Peff
next prev parent reply other threads:[~2006-09-08 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <64c62cc942e872b29d7225999e74a07be586674a.1157610743.git.peff@peff.net>
2006-09-07 6:36 ` [PATCH 3/3] git-commit.sh: convert run_status to a C builtin Jeff King
2006-09-07 9:10 ` Jeff King
2006-09-08 0:20 ` Junio C Hamano
2006-09-08 5:42 ` Jeff King
2006-09-08 5:56 ` Junio C Hamano
2006-09-08 7:34 ` Jeff King [this message]
2006-09-08 8:03 ` [PATCH] Move color option parsing out of diff.c and into color.[ch] Jeff King
2006-09-08 8:49 ` Junio C Hamano
2006-09-08 9:12 ` Jeff King
2006-09-08 21:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060908073452.GA25343@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).