From: Jeff King <peff@peff.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Move color option parsing out of diff.c and into color.[ch]
Date: Fri, 8 Sep 2006 05:12:06 -0400 [thread overview]
Message-ID: <20060908091206.GA5758@coredump.intra.peff.net> (raw)
In-Reply-To: <7vk64eivzj.fsf@assigned-by-dhcp.cox.net>
On Fri, Sep 08, 2006 at 01:49:20AM -0700, Junio C Hamano wrote:
> > + if (trail)
> > + r += printf("%s", trail);
> > + if (*color)
> > + r += printf("%s", COLOR_RESET);
> > + return r;
> > +}
> Hmm,... don't you mean RESET first and then trail (which is often "\n")?
ARGH. Yes, sorry about that. I wrote it correctly once, and then
refactored it to be wrong. :)
> Please spell NULL not 0 (please do not argue that writing a NULL
Sorry, I should clearly go read the linux CodingStyle doc before
subjecting you to any more of my patches.
I'm assuming you can mark both of those up yourself rather than having
me resend?
-Peff
next prev parent reply other threads:[~2006-09-08 9:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <64c62cc942e872b29d7225999e74a07be586674a.1157610743.git.peff@peff.net>
2006-09-07 6:36 ` [PATCH 3/3] git-commit.sh: convert run_status to a C builtin Jeff King
2006-09-07 9:10 ` Jeff King
2006-09-08 0:20 ` Junio C Hamano
2006-09-08 5:42 ` Jeff King
2006-09-08 5:56 ` Junio C Hamano
2006-09-08 7:34 ` Jeff King
2006-09-08 8:03 ` [PATCH] Move color option parsing out of diff.c and into color.[ch] Jeff King
2006-09-08 8:49 ` Junio C Hamano
2006-09-08 9:12 ` Jeff King [this message]
2006-09-08 21:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060908091206.GA5758@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).