git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: git@vger.kernel.org
Subject: [PATCH 4/5] Fix sed string regex escaping in module_name.
Date: Tue, 6 Nov 2007 21:20:02 +0100	[thread overview]
Message-ID: <20071106202002.GE6361@ins.uni-bonn.de> (raw)
In-Reply-To: <20071106201518.GA6361@ins.uni-bonn.de>

When escaping a string to be used as a sed regex, it is important
to only escape active characters.  Escaping other characters is
undefined according to POSIX, and may lead to problems with some
sed's extensions.
---
With this one, I'm not sure whether it is necessary, simply because I
don't know what kinds of characters can be part of a submodule path.
It anyway should be safe though.

 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-submodule.sh b/git-submodule.sh
index 4aaaaab..5af28ec 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -73,7 +73,7 @@ resolve_relative_url ()
 module_name()
 {
 	# Do we have "submodule.<something>.path = $1" defined in .gitmodules file?
-	re=$(printf '%s' "$1" | sed -e 's/\([^a-zA-Z0-9_]\)/\\\1/g')
+	re=$(printf '%s' "$1" | sed -e 's/[].[^$\\*]/\\&/g')
 	name=$( GIT_CONFIG=.gitmodules \
 		git config --get-regexp '^submodule\..*\.path$' |
 		sed -n -e 's|^submodule\.\(.*\)\.path '"$re"'$|\1|p' )
-- 
1.5.3.5.561.g140d

  parent reply	other threads:[~2007-11-06 20:20 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-06 20:15 [PATCH 0/5] some shell portability fixes Ralf Wildenhues
2007-11-06 20:17 ` [PATCH 1/5] Avoid a few unportable, needlessly nested "...`..." Ralf Wildenhues
2007-11-06 20:17 ` [PATCH 2/5] Fix sed script to work with AIX sed Ralf Wildenhues
2007-11-06 20:18 ` [PATCH 3/5] Replace $((...)) with expr invocations Ralf Wildenhues
2007-11-06 20:26   ` Ralf Wildenhues
2007-11-06 21:06     ` Junio C Hamano
2007-11-06 23:17       ` [PATCH] Add Documentation/CodingStyle Johannes Schindelin
2007-11-07  0:04         ` Andreas Ericsson
2007-11-07  0:40         ` Junio C Hamano
2007-11-07  8:52           ` Andreas Ericsson
2007-11-07 14:59             ` [PATCH v2] " Johannes Schindelin
2007-11-07 21:43               ` Robin Rosenberg
2007-11-07 22:35                 ` [PATCH v3] Add Documentation/CodingGuidelines Johannes Schindelin
2007-11-07 23:14                   ` Junio C Hamano
2007-11-08  0:33                     ` [PATCH v4] " Johannes Schindelin
2007-11-08  0:38                       ` Junio C Hamano
2007-11-07 14:54           ` [PATCH] Add Documentation/CodingStyle Johannes Schindelin
2007-11-07  7:53         ` Wincent Colaiuta
2007-11-07  8:53           ` Andreas Ericsson
2007-11-07 19:40         ` Jon Loeliger
2007-11-07 20:13           ` Johannes Schindelin
2007-11-08 11:29         ` Mike Ralphson
2007-11-06 20:20 ` Ralf Wildenhues [this message]
2007-11-06 20:20 ` [PATCH 5/5] Avoid "test -o" and "test -a" which are not POSIX, only XSI Ralf Wildenhues
2007-11-06 20:46 ` [PATCH 0/5] some shell portability fixes Junio C Hamano
2007-11-06 21:02   ` Mike Hommey
2007-11-06 23:25     ` Johannes Schindelin
2007-11-07 14:17       ` Mike Ralphson
2007-11-07 14:47         ` Johannes Schindelin
2007-11-07 15:30           ` Mike Ralphson
2007-11-07 15:37             ` Johannes Schindelin
2007-11-06 21:09   ` Ralf Wildenhues
2007-11-07 15:58   ` Nguyen Thai Ngoc Duy
2007-11-07 16:05     ` Nguyen Thai Ngoc Duy
2007-11-07 20:42       ` Junio C Hamano
2007-11-08  6:14         ` Ralf Wildenhues
2007-11-12 11:20         ` Nguyen Thai Ngoc Duy
2007-11-10 22:30   ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071106202002.GE6361@ins.uni-bonn.de \
    --to=ralf.wildenhues@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).