Re: [PATCH 0/5] some shell portability fixes

From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/5] some shell portability fixes
Date: Thu, 8 Nov 2007 07:14:56 +0100	[thread overview]
Message-ID: <20071108061456.GA28509@ins.uni-bonn.de> (raw)
In-Reply-To: <7v3avhbxdq.fsf@gitster.siamese.dyndns.org>

* Junio C Hamano wrote on Wed, Nov 07, 2007 at 09:42:41PM CET:
> "Nguyen Thai Ngoc Duy" <pclouds@gmail.com> writes:
> >
> > Argh, should have made it clear, busybox sed is good enough.
> 
> Thanks.  And you can also happy grok Ralf's rewritten construct,
> right?
> 
> That is, existing
> 
>         $ sed -e 's/foo/\n/' file
> 
> will be rewritten by the patch [2/5] to
> 
>         $ sed -e 's/foo/\
>         /' file

The original was something like
  sed 's/[|]/\n/g'

Using instead
  tr '|' '\n'

should work for the original construct, and AFAIK only /usr/ucb/tr on
Solaris fails to understand \n correctly.  Would that be better for you?
Or even
  tr '|' '\012'

which fails only on EBCDIC, which I don't think git targets.

I'll resend the patches tonight.

Cheers,
Ralf