From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Gabriel Saldaña" <gsaldana@gmail.com>,
"Martin Langhoff" <martin.langhoff@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: msgmft segfaulting on tiger
Date: Wed, 27 Feb 2008 19:32:12 -0500 [thread overview]
Message-ID: <20080228003212.GP8410@spearce.org> (raw)
In-Reply-To: <7vablmqc7q.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >> $ msgfmt --tcl; echo $?
> >> msgfmt: unrecognized option `--tcl'
> >> Try `msgfmt --help' for more information.
> >> 1
> >
> > Darn. I think that's the same exit code as for any other invocation
> > without filename.
>
> How about...
>
> $ msgfmt --tcl -l C -d . /dev/null; echo $?
I can't test this, my msgfmt --tcl works properly. Can someone
who has a msgfmt lacking tcl support confirm this will work?
--8<--
[PATCH] git-gui: Gracefully fall back to po2msg.sh if msgfmt --tcl fails
Mac OS X Tiger may have a msgfmt available but it doesn't understand
how to implement --tcl. Falling back to po2msg.sh on such systems
is a reasonable behavior.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
Makefile | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 01e0a46..1bd11eb 100644
--- a/Makefile
+++ b/Makefile
@@ -224,6 +224,11 @@ else
ifeq ($(shell $(MSGFMT) >/dev/null 2>&1 || echo $$?),127)
MSGFMT := $(TCL_PATH) po/po2msg.sh
endif
+ ifeq (msgfmt,$(MSGFMT))
+ ifeq ($(shell $(MSGFMT) --tcl -l C -d . /dev/null || echo $?),1)
+ MSGFMT := $(TCL_PATH) po/po2msg.sh
+ endif
+ endif
endif
msgsdir = $(gg_libdir)/msgs
--
1.5.4.3.295.g6b554
--
Shawn.
next prev parent reply other threads:[~2008-02-28 0:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 23:53 msgmft segfaulting on tiger Martin Langhoff
2008-02-21 23:59 ` Martin Langhoff
2008-02-22 6:58 ` Shawn O. Pearce
2008-02-22 17:57 ` Martin Langhoff
2008-02-27 18:18 ` Gabriel Saldaña
2008-02-27 18:26 ` Johannes Schindelin
2008-02-27 18:42 ` Gabriel Saldaña
2008-02-27 22:04 ` Johannes Schindelin
2008-02-27 22:14 ` Junio C Hamano
2008-02-28 0:32 ` Shawn O. Pearce [this message]
2008-03-04 7:02 ` msgmft segfaulting on ubuntu gutsy (clean) Gabriel Saldaña
2008-03-04 7:07 ` Shawn O. Pearce
2008-02-28 18:40 ` msgmft segfaulting on tiger Gabriel Saldaña
2008-03-05 7:19 ` Shawn O. Pearce
2008-03-06 8:40 ` Junio C Hamano
2008-03-12 5:29 ` [PATCH] Simplify MSGFMT setting in Makefile Junio C Hamano
2008-03-12 5:51 ` Shawn O. Pearce
2008-03-12 10:19 ` Charles Bailey
2008-03-14 4:44 ` Paul Mackerras
2008-03-14 4:50 ` Junio C Hamano
2008-03-14 13:07 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228003212.GP8410@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gsaldana@gmail.com \
--cc=martin.langhoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).