git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Bailey <charles@hashpling.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
	Paul Mackerras <paulus@samba.org>,
	git@vger.kernel.org
Subject: Re: [PATCH] Simplify MSGFMT setting in Makefile
Date: Wed, 12 Mar 2008 10:19:12 +0000	[thread overview]
Message-ID: <20080312101912.GB5530@hashpling.org> (raw)
In-Reply-To: <7vr6eg7bn3.fsf_-_@gitster.siamese.dyndns.org>

On Tue, Mar 11, 2008 at 10:29:52PM -0700, Junio C Hamano wrote:
> To prepare msg files for Tcl scripts, the command that is set to MSGFMT
> make variable needs to be able to grok "--tcl -l <lang> -d <here>" options
> correctly.  This patch simplifies the tests done in git-gui's Makefile to
> directly test this condition.  If the test run does not exit properly with
> zero status (either because you do not have "msgfmt" itself, or your
> "msgfmt" is too old to grok --tcl option --- the reason does not matter),
> have it fall back to po/po2msg.sh
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Tested-by: Charles Bailey <charles@hashpling.org>

This looks good to me on Mac OS X 10.5.2, would anyone like me to
prepare a patch for gitk as without it we still need to manually
specifiy NO_MSGFMT to the top level git make in any case?

Charles.

  parent reply	other threads:[~2008-03-12 10:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 23:53 msgmft segfaulting on tiger Martin Langhoff
2008-02-21 23:59 ` Martin Langhoff
2008-02-22  6:58   ` Shawn O. Pearce
2008-02-22 17:57     ` Martin Langhoff
2008-02-27 18:18       ` Gabriel Saldaña
2008-02-27 18:26         ` Johannes Schindelin
2008-02-27 18:42           ` Gabriel Saldaña
2008-02-27 22:04             ` Johannes Schindelin
2008-02-27 22:14               ` Junio C Hamano
2008-02-28  0:32                 ` Shawn O. Pearce
2008-03-04  7:02                   ` msgmft segfaulting on ubuntu gutsy (clean) Gabriel Saldaña
2008-03-04  7:07                     ` Shawn O. Pearce
2008-02-28 18:40                 ` msgmft segfaulting on tiger Gabriel Saldaña
2008-03-05  7:19                   ` Shawn O. Pearce
2008-03-06  8:40                     ` Junio C Hamano
2008-03-12  5:29                       ` [PATCH] Simplify MSGFMT setting in Makefile Junio C Hamano
2008-03-12  5:51                         ` Shawn O. Pearce
2008-03-12 10:19                         ` Charles Bailey [this message]
2008-03-14  4:44                         ` Paul Mackerras
2008-03-14  4:50                           ` Junio C Hamano
2008-03-14 13:07                           ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080312101912.GB5530@hashpling.org \
    --to=charles@hashpling.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=paulus@samba.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).