From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Daniel Barkalow <barkalow@iabervon.org>,
Teemu Likonen <tlikonen@iki.fi>,
git@vger.kernel.org
Subject: Re: Friendly refspecs
Date: Tue, 22 Apr 2008 06:56:58 -0400 [thread overview]
Message-ID: <20080422105658.GA11238@sigill.intra.peff.net> (raw)
In-Reply-To: <7vod89pnxx.fsf@gitster.siamese.dyndns.org>
On Wed, Apr 16, 2008 at 01:03:22PM -0700, Junio C Hamano wrote:
> > I was only working on making "HEAD" expand to HEAD:<current branch>. I
> > think that the matching type is only most likely what you want, not
> > certainly enough to just do it. I'd say that push should suggest it, but
> > not actually do it automatically, or possibly require -f to do it without
> > the full name.
>
> Hmm. `-f` means "I know there are the ones that do not fast forward but I
> want them updated", which is quite a different thing. I'd say either we
> should just do it, or we don't, and keep `-f` orthogonal to the ref
> dwimming.
Hmm. I was kind of hoping other people would chime in with opinions on
the dwimmery, but clearly they didn't.
I agree that "-f" is a terrible idea here. Not only is it overloading
what "-f" does, but it's totally unnecessary. If we want to send a
message to the user to retry with different parameters, we can already
say: "try again with refs/heads/$foo".
The "refs/heads/" dwimmery makes sense to me, because:
1. it changes a behavior which is currently an error condition, so
we're not hurting anyone's existing workflow
2. In my usage, pushing a branch to a tag (or vice versa) is the
exception, so I don't mind favoring pushing like types to like
types.
But I recognize that (2) is based on my own workflow, so if people
disagree, I guess it isn't so for everyone.
We should probably at least improve the message. Something like this is
perhaps a bit better, or it could even customize the suggestion based
on the source ref's type (i.e., implement the dwimmery, but don't
surprise anyone by doing it automatically).
-Peff
---
diff --git a/remote.c b/remote.c
index 06ad156..2151829 100644
--- a/remote.c
+++ b/remote.c
@@ -867,9 +867,12 @@ static int match_explicit(struct ref *src, struct ref *dst,
if (!memcmp(dst_value, "refs/", 5))
matched_dst = make_linked_ref(dst_value, dst_tail);
else
- error("dst refspec %s does not match any "
- "existing ref on the remote and does "
- "not start with refs/.", dst_value);
+ error("The destination refspec does not match any "
+ "existing ref on the remote,\n"
+ "and it does not specify a full refname; "
+ "did you mean one of:\n"
+ " refs/heads/%s\n"
+ " refs/tags/%s\n", dst_value, dst_value);
break;
default:
matched_dst = NULL;
next prev parent reply other threads:[~2008-04-22 10:57 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-09 10:14 git annoyances Ingo Molnar
2008-04-09 10:41 ` Björn Steinbrink
2008-04-09 14:57 ` Jeff King
2008-04-09 15:15 ` [PATCH] git-remote: show all remotes with "git remote show" Jeff King
2008-04-09 16:54 ` Johannes Schindelin
2008-04-10 10:56 ` Junio C Hamano
2008-04-09 20:07 ` Ingo Molnar
2008-04-10 19:59 ` Ingo Molnar
2008-04-09 17:08 ` git annoyances Avery Pennarun
2008-04-10 8:41 ` Karl Hasselström
2008-04-10 15:05 ` Avery Pennarun
2008-04-11 7:00 ` Karl Hasselström
2008-04-09 20:08 ` Friendly refspecs (Was: Re: git annoyances) Teemu Likonen
2008-04-09 20:32 ` Avery Pennarun
2008-04-09 20:34 ` Jeff King
2008-04-09 22:25 ` Teemu Likonen
2008-04-09 22:51 ` Jeff King
2008-04-10 0:03 ` Jeff King
2008-04-10 0:11 ` Jeff King
2008-04-10 7:51 ` Friendly refspecs Junio C Hamano
2008-04-10 8:03 ` Jeff King
[not found] ` <bd6139dc0804091616k53f4e0c1sf75aa9585c5a54c5@mail.gmail.com>
2008-04-10 0:33 ` Friendly refspecs (Was: Re: git annoyances) Jeff King
2008-04-10 7:58 ` Sverre Rabbelier
2008-04-13 9:31 ` Friendly refspecs Teemu Likonen
2008-04-13 9:34 ` [PATCH] Add examples section to 'git fetch' manual Teemu Likonen
2008-04-13 18:56 ` Junio C Hamano
2008-04-13 19:48 ` Matt Graham
2008-04-13 20:05 ` Teemu Likonen
2008-04-14 1:02 ` Junio C Hamano
2008-04-16 3:48 ` Friendly refspecs Jeff King
2008-04-16 4:25 ` Jeff King
2008-04-16 4:41 ` Junio C Hamano
2008-04-16 4:47 ` Jeff King
2008-04-16 15:42 ` Daniel Barkalow
2008-04-16 20:03 ` Junio C Hamano
2008-04-22 10:56 ` Jeff King [this message]
2008-04-22 16:52 ` Junio C Hamano
2008-04-22 17:19 ` Daniel Barkalow
2008-04-22 20:12 ` Jeff King
2008-04-22 20:05 ` Jeff King
2008-04-22 20:45 ` Junio C Hamano
2008-04-22 21:52 ` Jeff King
2008-04-23 4:24 ` Teemu Likonen
2008-04-23 5:52 ` Junio C Hamano
2008-04-23 6:24 ` Andreas Ericsson
2008-04-23 9:16 ` Jeff King
2008-04-23 9:21 ` Jeff King
2008-04-23 11:15 ` Teemu Likonen
2008-04-09 21:21 ` Junio C Hamano
2008-04-10 7:38 ` Teemu Likonen
2008-04-12 18:59 ` git annoyances Santiago Gala
2008-04-09 19:21 ` Daniel Barkalow
2008-04-09 20:41 ` Ingo Molnar
2008-04-10 14:08 ` Daniel Barkalow
2008-04-09 21:04 ` Junio C Hamano
2008-04-09 21:39 ` Jon Loeliger
2008-04-09 23:45 ` Nicolas Pitre
2008-04-09 21:45 ` Jeff King
2008-04-09 23:56 ` André Goddard Rosa
2008-04-10 19:45 ` Govind Salinas
2008-04-10 6:08 ` Jean-Christian de Rivaz
2008-04-10 8:19 ` Sverre Rabbelier
2008-04-10 11:47 ` git-bisect annoyances Ingo Molnar
2008-04-11 5:41 ` Christian Couder
2008-04-11 11:41 ` Ingo Molnar
2008-04-12 6:56 ` Christian Couder
2008-04-11 5:56 ` Junio C Hamano
2008-04-10 23:25 ` [PATCH] When a remote is added but not fetched, tell the user Gabriel
2008-04-11 15:21 ` Johannes Schindelin
2008-04-11 18:35 ` Gabriel
2008-04-11 18:39 ` [PATCH] Default to fetching a remote after adding it Gabriel
2008-04-11 19:17 ` Stephen Sinclair
2008-04-12 14:33 ` Johannes Schindelin
2008-04-12 15:13 ` Gabriel
2008-04-12 15:24 ` Johannes Schindelin
2008-04-11 19:08 ` [PATCH] When a remote is added but not fetched, tell the user Teemu Likonen
2008-04-11 21:39 ` Junio C Hamano
2008-04-11 22:35 ` Sverre Rabbelier
2008-04-11 23:15 ` Junio C Hamano
2008-04-11 23:20 ` Sverre Rabbelier
2008-04-15 3:15 ` Miles Bader
2008-04-11 19:29 ` [PATCH] Default to fetching a remote after adding it Gabriel
2008-04-11 19:36 ` Wincent Colaiuta
2008-04-11 19:46 ` Gabriel
2008-04-11 10:15 ` git annoyances Luciano Rocha
2008-04-11 10:27 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422105658.GA11238@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tlikonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).