git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [EGIT PATCH] Change GitResourceDecorator to use isAccessible
@ 2008-08-29  0:08 Shawn O. Pearce
  2008-08-29  9:01 ` Robin Rosenberg
  0 siblings, 1 reply; 2+ messages in thread
From: Shawn O. Pearce @ 2008-08-29  0:08 UTC (permalink / raw)
  To: Robin Rosenberg; +Cc: git

f3a6ac20 says it switched to use isAccessible() here but it
changed to exists().  We can only use setSessionProperty if
the resource is accessible so we must use the correct test
here in order to fix the issue reported by Robert.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---

 I just pushed this out to master since you clearly meant
 for this to be the case.  :-|

 .../internal/decorators/GitResourceDecorator.java  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
index 7c10ec6..1055fcc 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
@@ -199,7 +199,7 @@ synchronized (resources) {
 	} // End ResCL
 
 	void clearDecorationState(IResource r) throws CoreException {
-		if (r.exists()) {
+		if (r.isAccessible()) {
 			r.setSessionProperty(GITFOLDERDIRTYSTATEPROPERTY, null);
 			fireLabelProviderChanged(new LabelProviderChangedEvent(this, r));
 		}
-- 
1.6.0.174.gd789c

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [EGIT PATCH] Change GitResourceDecorator to use isAccessible
  2008-08-29  0:08 [EGIT PATCH] Change GitResourceDecorator to use isAccessible Shawn O. Pearce
@ 2008-08-29  9:01 ` Robin Rosenberg
  0 siblings, 0 replies; 2+ messages in thread
From: Robin Rosenberg @ 2008-08-29  9:01 UTC (permalink / raw)
  To: Shawn O. Pearce; +Cc: git

fredagen den 29 augusti 2008 02.08.26 skrev Shawn O. Pearce:
> f3a6ac20 says it switched to use isAccessible() here but it
> changed to exists().  We can only use setSessionProperty if
> the resource is accessible so we must use the correct test
> here in order to fix the issue reported by Robert.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
> 
>  I just pushed this out to master since you clearly meant
>  for this to be the case.  :-|

Thanks. I had a fix, but noticed the attribution was wrong so I fixed
the patch again and forgot the fix.

-- robin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-29  9:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-29  0:08 [EGIT PATCH] Change GitResourceDecorator to use isAccessible Shawn O. Pearce
2008-08-29  9:01 ` Robin Rosenberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).