Re: [PATCH] tg-remote: don't add push specs but warn about existing ones.

From: martin f krafft <madduck@debian.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	git@vger.kernel.org, "Marc Weber" <marco-oweber@gmx.de>,
	528442@bugs.debian.org
Subject: Re: [PATCH] tg-remote: don't add push specs but warn about existing ones.
Date: Wed, 13 May 2009 13:42:07 +0200	[thread overview]
Message-ID: <20090513114207.GB11669@piper.oerlikon.madduck.net> (raw)
In-Reply-To: <1242209046-9416-1-git-send-email-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 2193 bytes --]

also sprach Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [2009.05.13.1204 +0200]:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Marc Weber <marco-oweber@gmx.de>
> Cc: martin f. krafft <madduck@debian.org>

Signed-off-by: martin f. krafft <madduck@debian.org>

> diff --git a/tg-remote.sh b/tg-remote.sh
> index 3a40081..86dcd9a 100644
> --- a/tg-remote.sh
> +++ b/tg-remote.sh
> @@ -28,8 +28,13 @@ git config "remote.$name.url" >/dev/null || die "unknown remote '$name'"
>  ## Configure the remote
>  
>  git config --replace-all "remote.$name.fetch" "+refs/top-bases/*:refs/remotes/$name/top-bases/*" "\\+refs/top-bases/\\*:refs/remotes/$name/top-bases/\\*"
> -git config --replace-all "remote.$name.push" "+refs/top-bases/*:refs/top-bases/*" "\\+refs/top-bases/\\*:refs/top-bases/\\*"
> -git config --replace-all "remote.$name.push" "+refs/heads/*:refs/heads/*" "\\+refs/heads/\\*:refs/heads/\\*"
> +
> +if git config --get-all "remote.$name.push" "\\+refs/top-bases/\\*:refs/top-bases/\\*" >/dev/null && test "xtrue" != "x$(git config --bool --get topgit.dontwarnonoldpushspecs)"; then
> +	info "Probably you want to remove the push specs introduced by an old version of topgit:"
> +	info '       git config --unset-all "remote.'$name'.push" "\\+refs/top-bases/\\*:refs/top-bases/\\*"'
> +	info '       git config --unset-all "remote.'$name'.push" "\\+refs/heads/\\*:refs/heads/\\*"'
> +	info '(or use git config --bool --add topgit.dontwarnonoldpushspecs true to get rid of this warning)'
> +fi
>  
>  info "Remote $name can now follow TopGit topic branches."
>  if [ -z "$populate" ]; then

Thanks,

-- 
 .''`.   martin f. krafft <madduck@d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems

"the mind of the thoroughly well-informed man is a dreadful thing.
 it is like a bric-à-brac shop, all monsters and dust,
 with everything priced above its proper value."
                                                        -- oscar wilde

[-- Attachment #2: Digital signature (see http://martin-krafft.net/gpg/) --]
[-- Type: application/pgp-signature, Size: 197 bytes --]