git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bert Wesarg <bert.wesarg@googlemail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Marc Weber <marco-oweber@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] topgit tg push feature
Date: Thu, 7 May 2009 11:50:27 +0200	[thread overview]
Message-ID: <36ca99e90905070250l656f8879g87eb27c09db2cd42@mail.gmail.com> (raw)
In-Reply-To: <20090507084355.GA11680@pengutronix.de>

2009/5/7 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> Hi Marc, hi Bert,
>> > +       # if so desired omit non tgish deps
>> > +       [ -z "$tgish_deps_only" ] || [ -n "$_dep_is_tgish" ] || return 0
> I've always problems to understand these constructs.  Are these any
> better than
>
>        if test ...; then
>                return 0
>        fi
>
> ?  And I think it's more readable to use
>
>        tgish_deps_only=false
>
>        ...
>                --tgish-only)
>                        tgish_deps_only=true;;
>
>        ...
>
>        if $tgish_deps_only; then
>
>                ...
>
>        fi
>
> .  (OK, I have to admit, that these constructs are used everywhere in
> topgit, but I'm not happy with these either.)
I also like the true/false style, its also useable with the current 'scheme':

       $tgish_deps_only && ...

  reply	other threads:[~2009-05-07  9:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-25 16:13 [PATCH] topgit tg push feature Marc Weber
2009-04-25 16:34 ` Marc Weber
2009-05-05  9:34   ` Marc Weber
2009-05-07  4:59     ` Marc Weber
2009-05-07  5:45       ` Bert Wesarg
2009-05-07  8:43         ` Uwe Kleine-König
2009-05-07  9:50           ` Bert Wesarg [this message]
2009-05-09 10:36             ` martin f krafft
2009-05-09 19:09               ` Marc Weber
2009-05-11  3:28                 ` Marc Weber
2009-05-11  7:25                   ` martin f krafft
2009-05-11  7:47                   ` martin f krafft
2009-05-11 19:55                   ` Uwe Kleine-König
2009-05-11 21:06                     ` Marc Weber
2009-05-11 21:39                       ` martin f krafft
2009-05-12  5:13                       ` Uwe Kleine-König
2009-05-12  6:22                         ` Bert Wesarg
2009-05-12  7:54                         ` Marc Weber
2009-05-12  8:55                           ` Bert Wesarg
2009-05-12  9:02                             ` Uwe Kleine-König
2009-05-13 10:04                               ` [PATCH] tg-remote: don't add push specs but warn about existing ones Uwe Kleine-König
2009-05-13 11:42                                 ` martin f krafft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36ca99e90905070250l656f8879g87eb27c09db2cd42@mail.gmail.com \
    --to=bert.wesarg@googlemail.com \
    --cc=git@vger.kernel.org \
    --cc=marco-oweber@gmx.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).