git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nanako Shiraishi <nanako3@lavabit.com>
To: Alex Vandiver <alex@chmrr.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] After renaming a section, print any trailing variable definitions
Date: Sat, 25 Jul 2009 07:11:05 +0900	[thread overview]
Message-ID: <20090725071105.6117@nanako3.lavabit.com> (raw)
In-Reply-To: <1248470504-16326-3-git-send-email-alex@chmrr.net>

Quoting Alex Vandiver <alex@chmrr.net>

> diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
> index 43ea283..8c43dcd 100755
> --- a/t/t1300-repo-config.sh
> +++ b/t/t1300-repo-config.sh
> @@ -460,6 +460,28 @@ EOF
>  test_expect_success "rename succeeded" "test_cmp expect .git/config"
>  
>  cat >> .git/config << EOF
> +[branch "vier"] z = 1
> +EOF

Isn't this a syntax error?

Documentation/config.txt says this.

    Subsection names are case sensitive and can contain any characters
    except newline (doublequote `"` and backslash have to be escaped as
    `\"` and `\\`, respectively).  Section headers cannot span multiple
    lines.  Variables may belong directly to a section or to a given
    subsection.  You can have `[section]` if you have `[section
    "subsection"]`, but you don't need to.

    There is also a case insensitive alternative `[section.subsection]`
    syntax.  In this syntax, subsection names follow the same restrictions
    as for section names.

    All the other lines are recognized as setting variables, in the form
    'name = value'.  If there is no equal sign on the line, the entire
    line ...

I read "All the other lines" to mean that the section headers and variable definitions are supposed to be on different lines.

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

  reply	other threads:[~2009-07-24 22:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 21:21 [PATCH 0/2] Section renaming can lose content Alex Vandiver
2009-07-24 21:21 ` [PATCH 1/2] Make section_name_match start on '[', and return the length on success Alex Vandiver
2009-07-24 21:21   ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Alex Vandiver
2009-07-24 22:11     ` Nanako Shiraishi [this message]
2009-07-24 22:26       ` Alex Vandiver
2009-07-26 16:18         ` [PATCH] Make git config fail on variables with no section, as documented Alex Vandiver
2009-07-26 16:49           ` Johannes Schindelin
2009-07-26 19:32             ` Alex Vandiver
2009-07-26 19:48               ` Johannes Schindelin
2009-07-26 20:24                 ` Alex Vandiver
2009-07-24 23:39       ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Junio C Hamano
2009-07-25  0:28         ` (unknown), Nanako Shiraishi
2009-07-25 14:10         ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Johannes Schindelin
2009-07-25 14:09   ` [PATCH 1/2] Make section_name_match start on '[', and return the length on success Johannes Schindelin
2009-07-25 17:18     ` Alex Vandiver
2009-07-25 17:39       ` Junio C Hamano
2009-07-25 17:41       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090725071105.6117@nanako3.lavabit.com \
    --to=nanako3@lavabit.com \
    --cc=alex@chmrr.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).