From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Alex Vandiver <alex@chmrr.net>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] Make git config fail on variables with no section, as documented
Date: Sun, 26 Jul 2009 21:48:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0907262146530.8306@pacific.mpi-cbg.de> (raw)
In-Reply-To: <1248636518-sup-7499@utwig>
Hi,
On Sun, 26 Jul 2009, Alex Vandiver wrote:
> At Sun Jul 26 12:49:28 -0400 2009, Johannes Schindelin wrote:
> > Is there any downside in allowing this?
>
> Not explicitly. However, there are no legal current uses of it, and
> allowing it might encourage extensions to use the top-level config
> namespace.
So?
> It also has the odd property that it _must_ be at the top of a
> configuration file -- unlike all other configuration options, you can
> never return to the section to add more variable definitions later.
Yes, that is a special property that you might actually want in some
contexts.
That, together with the fact that "git config -f <file>" was meant
_explicitely_ to allow 3rd party porcelains having their own config files
without having to implement their own "git config" lets me suspect that
we'd rather want the current behavior.
Ciao,
Dscho
next prev parent reply other threads:[~2009-07-26 19:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 21:21 [PATCH 0/2] Section renaming can lose content Alex Vandiver
2009-07-24 21:21 ` [PATCH 1/2] Make section_name_match start on '[', and return the length on success Alex Vandiver
2009-07-24 21:21 ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Alex Vandiver
2009-07-24 22:11 ` Nanako Shiraishi
2009-07-24 22:26 ` Alex Vandiver
2009-07-26 16:18 ` [PATCH] Make git config fail on variables with no section, as documented Alex Vandiver
2009-07-26 16:49 ` Johannes Schindelin
2009-07-26 19:32 ` Alex Vandiver
2009-07-26 19:48 ` Johannes Schindelin [this message]
2009-07-26 20:24 ` Alex Vandiver
2009-07-24 23:39 ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Junio C Hamano
2009-07-25 0:28 ` (unknown), Nanako Shiraishi
2009-07-25 14:10 ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Johannes Schindelin
2009-07-25 14:09 ` [PATCH 1/2] Make section_name_match start on '[', and return the length on success Johannes Schindelin
2009-07-25 17:18 ` Alex Vandiver
2009-07-25 17:39 ` Junio C Hamano
2009-07-25 17:41 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0907262146530.8306@pacific.mpi-cbg.de \
--to=johannes.schindelin@gmx.de \
--cc=alex@chmrr.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).