Re: [PATCH] Document git push -q

[Jeff King <peff@peff.net>]

On Mon, Oct 19, 2009 at 01:52:40AM +0200, Miklos Vajna wrote:

> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> index ba6a8a2..beb3422 100644
> --- a/Documentation/git-push.txt
> +++ b/Documentation/git-push.txt
> @@ -138,6 +138,12 @@ useful if you write an alias or script around 'git-push'.
>  --verbose::
>  	Run verbosely.
>  
> +-q::
> +--quiet::
> +	Some transports produce output even without `--verbose` turned
> +	on. This provides a way to tell them to be more quiet (whereas
> +	simply redirecting might lose error messages).
> +

Thanks, though two complaints:

  1. This is not just about "some transports". Some of the quieted code
     is in transport_push, so hopefully it applies to all transports
     once they follow that code path (though we also pass the quiet flag
     on to pack-objects, so that part is about "some transports".

  2. Maybe it would be more helpful to the user to describe what is
     shown and what is not. I think we want to claim to suppress all
     non-error output (since that was the intent of the recent patches).
     If that is not true for some transport, then we need to fix passing
     --quiet to that transport.

...Ah, I see your confusion. You read the log for afdeeb00, but there
were some follow-on patches that impacted others part of push. :)

So maybe this instead:

-- >8 --
Subject: [PATCH] document push's new quiet option


Signed-off-by: Jeff King <peff@peff.net>
---
 Documentation/git-push.txt |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
index ba6a8a2..37c8895 100644
--- a/Documentation/git-push.txt
+++ b/Documentation/git-push.txt
@@ -138,6 +138,11 @@ useful if you write an alias or script around 'git-push'.
 --verbose::
 	Run verbosely.
 
+-q::
+--quiet::
+	Suppress all output, including the listing of updated refs,
+	unless an error occurs.
+
 include::urls-remotes.txt[]
 
 OUTPUT
-- 
1.6.5.1.121.g65c47