git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nanako Shiraishi <nanako3@lavabit.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Miklos Vajna <vmiklos@frugalware.org>,
	Sebastian Pipping <webmaster@hartwork.org>,
	git@vger.kernel.org, Bjorn Gustavsson <bgustavsson@gmail.com>
Subject: Re: [PATCH] git push: say that --tag can't be used with --all or --mirror in help text
Date: Thu, 22 Oct 2009 06:21:35 +0900	[thread overview]
Message-ID: <20091022062135.6117@nanako3.lavabit.com> (raw)
In-Reply-To: <20091021144203.GA30485@coredump.intra.peff.net>

Quoting Jeff King <peff@peff.net>

> On Mon, Oct 19, 2009 at 12:57:01PM +0900, Nanako Shiraishi wrote:
>
>> -		OPT_BOOLEAN( 0 , "tags", &tags, "push tags"),
>> +		OPT_BOOLEAN( 0 , "tags", &tags, "push tags (can't be used with --all nor --mirror"),
>
> Hmm. We apparently all managed to miss this typo. It's visually hard to
> notice because of the ")" closing the macro.

How embarrassing. Thank you for a fix.

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

  reply	other threads:[~2009-10-21 21:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11  8:40 [ANNOUNCE] GIT 1.6.5 Junio C Hamano
2009-10-11 16:30 ` Steven Noonan
2009-10-11 16:30   ` Steven Noonan
2009-10-11 18:47   ` Junio C Hamano
2009-10-11 18:57     ` Steven Noonan
2009-10-14 22:11 ` Jakub Narebski
2009-10-18 17:05 ` Sebastian Pipping
2009-10-18 23:52   ` [PATCH] Document git push -q Miklos Vajna
2009-10-19  2:54     ` [PATCH] git push: remove incomplete options list from help text Nanako Shiraishi
2009-10-19  3:13       ` Junio C Hamano
2009-10-19  3:57         ` [PATCH] git push: say that --tag can't be used with --all or --mirror in " Nanako Shiraishi
2009-10-19  4:14           ` Jeff King
2009-10-21 14:42           ` Jeff King
2009-10-21 21:21             ` Nanako Shiraishi [this message]
2009-10-19  4:10       ` [PATCH] git push: remove incomplete options list from " Jeff King
2009-10-19  5:41         ` Junio C Hamano
2009-10-19  4:01     ` [PATCH] Document git push -q Jeff King
2009-10-19  5:58     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091022062135.6117@nanako3.lavabit.com \
    --to=nanako3@lavabit.com \
    --cc=bgustavsson@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=vmiklos@frugalware.org \
    --cc=webmaster@hartwork.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).