git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Voigt <hvoigt@hvoigt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Steven Drake <sdrake@xnet.co.nz>, git@vger.kernel.org
Subject: Re: Re* [PATCH] Add `[decorate]' configuration section.
Date: Sat, 20 Feb 2010 18:17:44 +0100	[thread overview]
Message-ID: <20100220171732.GA15561@book.hvoigt.net> (raw)
In-Reply-To: <7vd403vhrn.fsf@alter.siamese.dyndns.org>

On Wed, Feb 17, 2010 at 10:28:28AM -0800, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:

I have just seen this in Junios tree:

commit 8a3d203bd02bec48a02557961899d81da172fa23 writes:
> Author: Junio C Hamano <gitster@pobox.com>
> Date:   Wed Feb 17 10:20:49 2010 -0800
> 
>     log.decorate: usability fixes
>     
>     The configuration is meant to suppliment --decorate command line option
>     that can be used as a boolean to turn the feature on, so it is natural
>     to expect
>     
>         [log]
>                 decorate
>                 decorate = yes
>     
>     to work.  The original commit would segfault with the first one, and
>     would not understand the second one.
>     
>     Once a user has this configuration in ~/.gitconfig, there needs to be a
>     way to override it from the command line.  Add --no-decorate option to
>     log family and also allow --decorate=no to mean the same thing.  Since
>     we allow setting log.decorate to 'true', the command line also should
>     accept --decorate=yes and behave accordingly.

How about calling that option --plain, --porcelain or similar and have it
disable all configs which change the current output? Because if we can go this
way I would actually like to add more useful configurations. For example I
always find me typing:

git log --decorate --abbrev-commit -p

which in most situations just gives you a nicer overview.

cheers Heiko

  reply	other threads:[~2010-02-20 17:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17  8:22 [PATCH] Add `[decorate]' configuration section Steven Drake
2010-02-17 17:50 ` Junio C Hamano
2010-02-17 18:28   ` Re* " Junio C Hamano
2010-02-20 17:17     ` Heiko Voigt [this message]
2010-02-20 17:49       ` Thomas Rast
2010-02-22  5:52         ` Junio C Hamano
2010-02-25 22:44   ` Steven Drake
2010-02-25 23:12     ` Junio C Hamano
2010-02-26  0:06       ` Steven Drake
2010-02-26  3:57         ` Steven Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100220171732.GA15561@book.hvoigt.net \
    --to=hvoigt@hvoigt.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sdrake@xnet.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).